From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6A2245A52 for ; Thu, 9 Jul 2015 12:06:26 +0200 (CEST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by orsmga101.jf.intel.com with ESMTP; 09 Jul 2015 03:06:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.15,439,1432623600"; d="scan'208";a="725623727" Received: from irsmsx152.ger.corp.intel.com ([163.33.192.66]) by orsmga001.jf.intel.com with ESMTP; 09 Jul 2015 03:06:24 -0700 Received: from irsmsx156.ger.corp.intel.com (10.108.20.68) by IRSMSX152.ger.corp.intel.com (163.33.192.66) with Microsoft SMTP Server (TLS) id 14.3.224.2; Thu, 9 Jul 2015 11:06:23 +0100 Received: from irsmsx102.ger.corp.intel.com ([169.254.2.117]) by IRSMSX156.ger.corp.intel.com ([169.254.3.125]) with mapi id 14.03.0224.002; Thu, 9 Jul 2015 11:06:23 +0100 From: "Gajdzica, MaciejX T" To: "Dumitrescu, Cristian" , Thomas Monjalon , "Singh, Jasvinder" Thread-Topic: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master pipeline Thread-Index: AQHQuI+hF7gWtW3WjU+TFA6lfJVOoZ3SGk+AgACvsYCAAApfIIAABfWAgAARp4A= Date: Thu, 9 Jul 2015 10:06:23 +0000 Message-ID: <9CC680510C0AC140A846FED2EF7F96281384BE04@IRSMSX102.ger.corp.intel.com> References: <1436256575-15107-1-git-send-email-maciejx.t.gajdzica@intel.com> <1436256575-15107-6-git-send-email-maciejx.t.gajdzica@intel.com> <2556845.B31QGe61c9@xps13> <9CC680510C0AC140A846FED2EF7F96281384BDE9@IRSMSX102.ger.corp.intel.com> <3EB4FA525960D640B5BDFFD6A3D89126323985D8@IRSMSX108.ger.corp.intel.com> In-Reply-To: <3EB4FA525960D640B5BDFFD6A3D89126323985D8@IRSMSX108.ger.corp.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Cc: "dev@dpdk.org" Subject: Re: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master pipeline X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 09 Jul 2015 10:06:27 -0000 > -----Original Message----- > From: Dumitrescu, Cristian > Sent: Thursday, July 09, 2015 12:01 PM > To: Gajdzica, MaciejX T; Thomas Monjalon; Singh, Jasvinder > Cc: dev@dpdk.org > Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master pipeli= ne >=20 >=20 >=20 > > -----Original Message----- > > From: Gajdzica, MaciejX T > > Sent: Thursday, July 9, 2015 12:58 PM > > To: Thomas Monjalon; Singh, Jasvinder > > Cc: dev@dpdk.org; Dumitrescu, Cristian > > Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master > > pipeline > > > > > > > > > -----Original Message----- > > > From: Gajdzica, MaciejX T > > > Sent: Thursday, July 09, 2015 10:03 AM > > > To: 'Thomas Monjalon'; Singh, Jasvinder > > > Cc: dev@dpdk.org; Dumitrescu, Cristian > > > Subject: RE: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master > > pipeline > > > > > > > -----Original Message----- > > > > From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com] > > > > Sent: Thursday, July 09, 2015 12:33 AM > > > > To: Gajdzica, MaciejX T; Singh, Jasvinder > > > > Cc: dev@dpdk.org; Dumitrescu, Cristian > > > > Subject: Re: [dpdk-dev] [PATCH v6 05/11] ip_pipeline: added master > > > > pipeline > > > > > > > > 2015-07-07 10:09, Maciej Gajdzica: > > > > > From: Jasvinder Singh > > > > > > > > > > Master pipeline is responsible for command line handling and > > > > > communicationg with all other pipelines via message queues. > > > > > Removed cmdline.c file, as its functionality will be split over > > > > > multiple pipeline files. > > > > > > > > > > Signed-off-by: Jasvinder Singh > > > > > > > > In this v6, it builds well until patch 05 which uses some not > > > > exported > > symbols: > > > > pipeline_common_be.c:(.text+0x51): undefined reference to > > > > `rte_pipeline_port_in_stats_read' > > > > pipeline_common_be.c:(.text+0x91): undefined reference to > > > > `rte_pipeline_port_out_stats_read' > > > > pipeline_common_be.c:(.text+0xd4): undefined reference to > > > > `rte_pipeline_table_stats_read' > > > > > > > > Please check build with shared libraries. > > > > > > There are missing symbols in map file for librte_port and > > > librte_pipeline. I > > will > > > send separate patch for that. > > > > This compilation problem with shared libraries is not because > > something with this patchset is wrong, but because exported symbols in > > map file in earlier patchsets are missing. So after separate patches > > with fix will be applied, could you restore this patchset? > > > > Best Regards > > Maciek >=20 > Hi Maciek, I suggest we add the missing symbols to the librte_port, lib_r= te_table > and librte_pipeline as a new patch; this should fix the v6 patch series o= n > ip_pipeline without any need for v7? Thanks, Cristian Hi Cristian I already sent new patch with this fix: http://dpdk.org/ml/archives/dev/2015-July/021194.html http://dpdk.org/ml/archives/dev/2015-July/021193.html Best Regards Maciek