Re: [dpdk-dev] [RFC 0/1] A Distributed Software Event Device

["Wiles, Keith" <keith.wiles@intel.com>]

> On Jul 11, 2018, at 4:21 PM, Mattias Rönnblom <mattias.ronnblom@ericsson.com> wrote:
> 
> This is the Distributed Software (DSW) event device, which distributes
> the task of scheduling events among all the eventdev ports and their
> lcore threads.
> 
> DSW is primarily designed for atomic-only queues, but also supports
> single-link and parallel queues.
> 
> (DSW would be more accurately described as 'parallel', but since that
> term is used to describe an eventdev queue type, it's referred to as
> 'distributed', to avoid suggesting it's somehow biased toward parallel
> queues.)
> 
> 

Just a quick look at the format of the code I notice a number of places missing a blank line after the declarations in a function e.g. dsw_xstats_port_get() an others. Just to help when you send this in as a real patch. Make sure you run checkpatch.

As for the RFC I like the idea of this RFC, but need to dig into the code.

Thanks

> Short-term TODO
> ===============
> 
> o Figure out which DSW parameters needs to be runtime configurable.
> o Consider adding support for event priority.
> o Add relevant test cases to eventdev unit tests.
> o Convert this massive cover letter into proper DPDK documentation.
> 
> [1] http://www.lysator.liu.se/~hofors/dsw/migration-sequence.svg
> 
> Mattias Rönnblom (1):
>  eventdev: add distributed software (DSW) event device
> 
> config/common_base                            |    5 +
> drivers/event/Makefile                        |    1 +
> drivers/event/dsw/Makefile                    |   28 +
> drivers/event/dsw/dsw_evdev.c                 |  361 +++++
> drivers/event/dsw/dsw_evdev.h                 |  296 ++++
> drivers/event/dsw/dsw_event.c                 | 1285 +++++++++++++++++
> drivers/event/dsw/dsw_sort.h                  |   47 +
> drivers/event/dsw/dsw_xstats.c                |  284 ++++
> .../event/dsw/rte_pmd_evdev_dsw_version.map   |    3 +
> mk/rte.app.mk                                 |    1 +
> 10 files changed, 2311 insertions(+)
> create mode 100644 drivers/event/dsw/Makefile
> create mode 100644 drivers/event/dsw/dsw_evdev.c
> create mode 100644 drivers/event/dsw/dsw_evdev.h
> create mode 100644 drivers/event/dsw/dsw_event.c
> create mode 100644 drivers/event/dsw/dsw_sort.h
> create mode 100644 drivers/event/dsw/dsw_xstats.c
> create mode 100644 drivers/event/dsw/rte_pmd_evdev_dsw_version.map
> 
> -- 
> 2.17.1
> 

Regards,
Keith