From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 42F0EA034F; Mon, 25 Nov 2019 22:55:37 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 19741235; Mon, 25 Nov 2019 22:55:37 +0100 (CET) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by dpdk.org (Postfix) with ESMTP id A643091 for ; Mon, 25 Nov 2019 22:55:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 25 Nov 2019 13:55:34 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.69,242,1571727600"; d="scan'208";a="202509399" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga008.jf.intel.com with ESMTP; 25 Nov 2019 13:55:33 -0800 Received: from fmsmsx123.amr.corp.intel.com (10.18.125.38) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.439.0; Mon, 25 Nov 2019 13:55:34 -0800 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.27]) by fmsmsx123.amr.corp.intel.com ([169.254.7.76]) with mapi id 14.03.0439.000; Mon, 25 Nov 2019 13:55:34 -0800 From: "Wiles, Keith" To: Frank Li CC: "dev@dpdk.org" Thread-Topic: [PATCH] pktgen: Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing Thread-Index: AQHVo9nr2sscYS6nI0q2yeH4xNJwSqec9IeA Date: Mon, 25 Nov 2019 21:55:33 +0000 Message-ID: <9EDA5FBC-89BF-4108-9FBF-1A6C91C72CB4@intel.com> References: <20191125214638.41094-1-frank.li.65@gmail.com> In-Reply-To: <20191125214638.41094-1-frank.li.65@gmail.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.254.1.52] Content-Type: text/plain; charset="us-ascii" Content-ID: <1CDEF558BF989040978E88088BEE094C@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] pktgen: Fix IPv6 addressing for set/sequence/save commands, packet headers, UI printing X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Nov 25, 2019, at 3:46 PM, Frank Li wrote: >=20 > Current IPv6 functionality in pktgen is broken. This fix makes it so that > IPv6 addresses are properly set when using the set, sequence, and save > commands and that the IP header and UDP/TCP psuedo-header IPV6 addresses > are properly set. >=20 > To preserve the runtime commands, the `_atoip` function no longer takes > in flags to specify converting IPv4/6 addresses, and will try both, > returning, 4, 6, or -1 for a valid IPv4/6, invalid address, respectively. >=20 > Also print IPv6 addresses in UI properly. >=20 > Co-authored-by Valentin Andrei >=20 > Signed-off-by: Frank Li >=20 Thanks I will try to find time to pull this into the next release. Regards, Keith