From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id D47772BC9 for ; Fri, 1 Apr 2016 16:07:25 +0200 (CEST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga101.fm.intel.com with ESMTP; 01 Apr 2016 07:06:28 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.24,427,1455004800"; d="scan'208";a="679196249" Received: from irsmsx103.ger.corp.intel.com ([163.33.3.157]) by FMSMGA003.fm.intel.com with ESMTP; 01 Apr 2016 07:06:28 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.157]) by IRSMSX103.ger.corp.intel.com ([169.254.3.239]) with mapi id 14.03.0248.002; Fri, 1 Apr 2016 15:06:25 +0100 From: "Zhang, Roy Fan" To: Thomas Monjalon CC: "dev@dpdk.org" Thread-Topic: [dpdk-dev] [PATCH 3/3] port: code clean-up Thread-Index: AQHRjBxqUyHpQBgp+kukGpShk3dN/591E4EAgAAThTA= Date: Fri, 1 Apr 2016 14:06:24 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C60409D3567D@IRSMSX101.ger.corp.intel.com> References: <1459518117-23944-1-git-send-email-roy.fan.zhang@intel.com> <1459518117-23944-4-git-send-email-roy.fan.zhang@intel.com> <2420426.ojDceOkhvu@xps13> In-Reply-To: <2420426.ojDceOkhvu@xps13> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWI4NDM2MjktOTNiNS00YTM4LWI3NTMtZTZlYzdlZjA0MDE1IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6IlFIQ1Nwa3l2K1FtY0hvdUZ2eFUrcm5VbnphTWdTWlFreTl3N285WWtqK289In0= x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH 3/3] port: code clean-up X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Apr 2016 14:07:26 -0000 Hi Thomas, The reason for removing RTE_NEXT_ABI here is caused by sink port, which is = not wrapped by RTE_NEXT_ABI macro. If the user disable RTE_NEXT_ABI but enable RTE_PORT_PCAP, the original cod= e will cause the compile error as pcap library is missing. Regards, Fan -----Original Message----- From: Thomas Monjalon [mailto:thomas.monjalon@6wind.com]=20 Sent: Friday, April 1, 2016 2:56 PM To: Zhang, Roy Fan Cc: dev@dpdk.org Subject: Re: [dpdk-dev] [PATCH 3/3] port: code clean-up 2016-04-01 14:41, Fan Zhang: > --- a/mk/rte.app.mk > +++ b/mk/rte.app.mk > @@ -92,9 +92,7 @@ endif > ifeq ($(CONFIG_RTE_LIBRTE_VHOST_USER),n) > _LDLIBS-$(CONFIG_RTE_LIBRTE_VHOST) +=3D -lfuse > endif > -ifeq ($(CONFIG_RTE_NEXT_ABI),y) > _LDLIBS-$(CONFIG_RTE_PORT_PCAP) +=3D -lpcap > -endif Why removing NEXT_ABI here? The pcap port cannot work without it because of=20 +#ifdef RTE_NEXT_ABI + + /** The full path of the pcap file to read packets from */ + char *file_name; + /** The number of bytes to be read from each packet in the + * pcap file. If this value is 0, the whole packet is read; + * if it is bigger than packet size, the generated packets + * will contain the whole packet */ + uint32_t n_bytes_per_pkt; + +#endif