From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: "Doherty, Declan" <declan.doherty@intel.com>,
"dev@dpdk.org" <dev@dpdk.org>
Cc: "De Lara Guarch, Pablo" <pablo.de.lara.guarch@intel.com>,
"stable@dpdk.org" <stable@dpdk.org>,
"Doherty, Declan" <declan.doherty@intel.com>
Subject: Re: [dpdk-dev] [PATCH] cryptodev: crypto PMD functions incorrectly inlined
Date: Mon, 23 Jan 2017 12:24:54 +0000 [thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C60409E632CB@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20170123121835.27317-1-declan.doherty@intel.com>
> -----Original Message-----
> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Declan Doherty
> Sent: Monday, January 23, 2017 12:19 PM
> To: dev@dpdk.org
> Cc: De Lara Guarch, Pablo <pablo.de.lara.guarch@intel.com>;
> stable@dpdk.org; Doherty, Declan <declan.doherty@intel.com>
> Subject: [dpdk-dev] [PATCH] cryptodev: crypto PMD functions incorrectly
> inlined
>
> rte_cryptodev_pmd_get_dev, rte_cryptodev_pmd_get_named_dev,
> rte_cryptodev_pmd_is_valid_dev were incorrectly marked as inline and
> therefore not useable from crypto PMDs when built as shared libraries as
> they accessed the global rte_cryptodev_globals device structure.
>
> Fixes: d11b0f30 ("cryptodev: introduce API and framework for crypto
> devices")
>
> Signed-off-by: Declan Doherty <declan.doherty@intel.com>
> ---
> lib/librte_cryptodev/rte_cryptodev.c | 42
> ++++++++++++++++++++++++
> lib/librte_cryptodev/rte_cryptodev_pmd.h | 44 ++++----------------------
> lib/librte_cryptodev/rte_cryptodev_version.map | 3 ++
> 3 files changed, 51 insertions(+), 38 deletions(-)
>
> diff --git a/lib/librte_cryptodev/rte_cryptodev.c
> b/lib/librte_cryptodev/rte_cryptodev.c
> index 6a51eec..42707cb 100644
> --- a/lib/librte_cryptodev/rte_cryptodev.c
> +++ b/lib/librte_cryptodev/rte_cryptodev.c
> @@ -255,6 +255,48 @@ rte_cryptodev_create_vdev(const char *name,
> const char *args)
> return rte_eal_vdev_init(name, args);
> }
>
> +struct rte_cryptodev *
> +rte_cryptodev_pmd_get_dev(uint8_t dev_id) {
> + return &rte_cryptodev_globals->devs[dev_id];
> +}
> +
> +struct rte_cryptodev *
> +rte_cryptodev_pmd_get_named_dev(const char *name) {
> + struct rte_cryptodev *dev;
> + unsigned i;
> +
> + if (name == NULL)
> + return NULL;
> +
> + for (i = 0; i < rte_cryptodev_globals->max_devs; i++) {
> + dev = &rte_cryptodev_globals->devs[i];
> +
> + if ((dev->attached == RTE_CRYPTODEV_ATTACHED) &&
> + (strcmp(dev->data->name, name) == 0))
> + return dev;
> + }
> +
> + return NULL;
> +}
> +
> +unsigned
> +rte_cryptodev_pmd_is_valid_dev(uint8_t dev_id) {
> + struct rte_cryptodev *dev = NULL;
> +
> + if (dev_id >= rte_cryptodev_globals->nb_devs)
> + return 0;
> +
> + dev = rte_cryptodev_pmd_get_dev(dev_id);
> + if (dev->attached != RTE_CRYPTODEV_ATTACHED)
> + return 0;
> + else
> + return 1;
> +}
> +
> +
> int
> rte_cryptodev_get_dev_id(const char *name) { diff --git
> a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> index aabef41..b6dc32c 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_pmd.h
> +++ b/lib/librte_cryptodev/rte_cryptodev_pmd.h
> @@ -160,11 +160,8 @@ extern struct rte_cryptodev_global
> *rte_cryptodev_globals;
> * @return
> * - The rte_cryptodev structure pointer for the given device ID.
> */
> -static inline struct rte_cryptodev *
> -rte_cryptodev_pmd_get_dev(uint8_t dev_id) -{
> - return &rte_cryptodev_globals->devs[dev_id];
> -}
> +struct rte_cryptodev *
> +rte_cryptodev_pmd_get_dev(uint8_t dev_id);
>
> /**
> * Get the rte_cryptodev structure device pointer for the named device.
> @@ -174,25 +171,8 @@ rte_cryptodev_pmd_get_dev(uint8_t dev_id)
> * @return
> * - The rte_cryptodev structure pointer for the given device ID.
> */
> -static inline struct rte_cryptodev *
> -rte_cryptodev_pmd_get_named_dev(const char *name) -{
> - struct rte_cryptodev *dev;
> - unsigned i;
> -
> - if (name == NULL)
> - return NULL;
> -
> - for (i = 0; i < rte_cryptodev_globals->max_devs; i++) {
> - dev = &rte_cryptodev_globals->devs[i];
> -
> - if ((dev->attached == RTE_CRYPTODEV_ATTACHED) &&
> - (strcmp(dev->data->name, name) == 0))
> - return dev;
> - }
> -
> - return NULL;
> -}
> +struct rte_cryptodev *
> +rte_cryptodev_pmd_get_named_dev(const char *name);
>
> /**
> * Validate if the crypto device index is valid attached crypto device.
> @@ -202,20 +182,8 @@ rte_cryptodev_pmd_get_named_dev(const char
> *name)
> * @return
> * - If the device index is valid (1) or not (0).
> */
> -static inline unsigned
> -rte_cryptodev_pmd_is_valid_dev(uint8_t dev_id) -{
> - struct rte_cryptodev *dev = NULL;
> -
> - if (dev_id >= rte_cryptodev_globals->nb_devs)
> - return 0;
> -
> - dev = rte_cryptodev_pmd_get_dev(dev_id);
> - if (dev->attached != RTE_CRYPTODEV_ATTACHED)
> - return 0;
> - else
> - return 1;
> -}
> +unsigned
> +rte_cryptodev_pmd_is_valid_dev(uint8_t dev_id);
>
> /**
> * The pool of rte_cryptodev structures.
> diff --git a/lib/librte_cryptodev/rte_cryptodev_version.map
> b/lib/librte_cryptodev/rte_cryptodev_version.map
> index c581eea..a92df62 100644
> --- a/lib/librte_cryptodev/rte_cryptodev_version.map
> +++ b/lib/librte_cryptodev/rte_cryptodev_version.map
> @@ -51,5 +51,8 @@ DPDK_17.02 {
> global:
>
> rte_cryptodev_pmd_create_dev_name;
> + rte_cryptodev_pmd_get_dev;
> + rte_cryptodev_pmd_get_named_dev;
> + rte_cryptodev_pmd_is_valid_dev;
>
> } DPDK_16.11;
> --
> 2.9.3
Acked-by: Fan Zhang <roy.fan.zhang@intel.com>
next prev parent reply other threads:[~2017-01-23 12:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 12:18 Declan Doherty
2017-01-23 12:24 ` Zhang, Roy Fan [this message]
2017-01-24 10:37 ` De Lara Guarch, Pablo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9F7182E3F746AB4EA17801C148F3C60409E632CB@IRSMSX101.ger.corp.intel.com \
--to=roy.fan.zhang@intel.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).