From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 36820DE0 for ; Mon, 13 Feb 2017 17:07:24 +0100 (CET) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga105.jf.intel.com with ESMTP; 13 Feb 2017 08:07:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,156,1484035200"; d="scan'208";a="64156552" Received: from irsmsx102.ger.corp.intel.com ([163.33.3.155]) by orsmga005.jf.intel.com with ESMTP; 13 Feb 2017 08:07:22 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.112]) by IRSMSX102.ger.corp.intel.com ([169.254.2.230]) with mapi id 14.03.0248.002; Mon, 13 Feb 2017 16:07:21 +0000 From: "Zhang, Roy Fan" To: "Trahe, Fiona" , "dev@dpdk.org" CC: "De Lara Guarch, Pablo" Thread-Topic: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure Thread-Index: AQHSg5JC6vujaRNn/EWPFVIqKhW0RKFiRLoAgATVE4A= Date: Mon, 13 Feb 2017 16:07:21 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C60409E6AC94@IRSMSX101.ger.corp.intel.com> References: <1486726767-81742-1-git-send-email-roy.fan.zhang@intel.com> <348A99DA5F5B7549AA880327E580B43589185800@IRSMSX101.ger.corp.intel.com> In-Reply-To: <348A99DA5F5B7549AA880327E580B43589185800@IRSMSX101.ger.corp.intel.com> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_IC x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOWNmZmI3ZDQtMTRmZC00YWQyLWI4ZDYtNTZlNWI0MTA2YmFhIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX0lDIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE1LjkuNi42IiwiVHJ1c3RlZExhYmVsSGFzaCI6Im43MFdvMTErQndsTXlYOFdERk5FQmxBZ0J4Rmljb1VnQ3JBK1ZkRGRcL0tnPSJ9 x-originating-ip: [163.33.239.180] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 13 Feb 2017 16:07:24 -0000 Hi Fiona, Sorry for my bad English, I will try to explain better here. "cryptodev_configure_t" is a function prototype with only "rte_cryptodev *d= ev" as sole parameter. Structure ``rte_cryptodev_ops`` holds one function point= er "dev_configure" of it.=20 The patch involves in the announcement of adding a parameter of=20 "struct rte_cryptodev_config" pointer so the function prototype could look = like: typedef int (*cryptodev_configure_t)(struct rte_cryptodev *dev, struct rte_= cryptodev_config *config); Without this parameter, a specific crypto PMD may not have enough informati= on to configure itself. Which may not be big problem as other Cryptodevs as all c= onfigures are done in rte_cryptodev_configure(), but it is important for the schedule= r PMD as it needs this parameter to configure all its slaves. Currently the user have t= o configure every slave one by one. The problem is, although I want to change an API of the function prototype = "cryptodev_configure_t", but in order to do that I have to break the ABI of structure "rte_cryptodev= _ops". Any help on the grammar for stating this nicer would be appreciated. Best regards, Fan > -----Original Message----- > From: Trahe, Fiona > Sent: Friday, February 10, 2017 2:00 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: De Lara Guarch, Pablo ; Trahe, Fiona > > Subject: RE: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > structure >=20 > Hi Fan, >=20 > > -----Original Message----- > > From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Fan Zhang > > Sent: Friday, February 10, 2017 11:39 AM > > To: dev@dpdk.org > > Cc: De Lara Guarch, Pablo > > Subject: [dpdk-dev] [PATCH] doc: annouce ABI change for cryptodev ops > > structure > > > > Signed-off-by: Fan Zhang > > --- > > doc/guides/rel_notes/deprecation.rst | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/doc/guides/rel_notes/deprecation.rst > > b/doc/guides/rel_notes/deprecation.rst > > index 755dc65..564d93a 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -62,3 +62,7 @@ Deprecation Notices > > PMDs that implement the latter. > > Target release for removal of the legacy API will be defined once mo= st > > PMDs have switched to rte_flow. > > + > > +* ABI changes are planned for 17.05 in the ``rte_cryptodev_ops`` struc= ture. > > + The field ``cryptodev_configure_t`` function prototype will be > > +added a > > + parameter of a struct rte_cryptodev_config type pointer. > > -- > > 2.7.4 >=20 > Can you fix the grammar here please. I'm not sure what the change is?