From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id AC4DC8E78 for ; Tue, 17 Apr 2018 10:56:42 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga103.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 17 Apr 2018 01:56:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,463,1517904000"; d="scan'208";a="34245083" Received: from irsmsx107.ger.corp.intel.com ([163.33.3.99]) by orsmga008.jf.intel.com with ESMTP; 17 Apr 2018 01:56:40 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.176]) by IRSMSX107.ger.corp.intel.com ([169.254.10.157]) with mapi id 14.03.0319.002; Tue, 17 Apr 2018 09:56:39 +0100 From: "Zhang, Roy Fan" To: Thomas Monjalon CC: "dev@dpdk.org" , "maxime.coquelin@redhat.com" , "shahafs@mellanox.com" , "Richardson, Bruce" Thread-Topic: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile Thread-Index: AQHT1Y2FCwwR1SZTfU6w/MdSuB07JKQD2+WAgADMMfA= Date: Tue, 17 Apr 2018 08:56:39 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C6043311CCA3@IRSMSX101.ger.corp.intel.com> References: <20180416140858.79994-1-roy.fan.zhang@intel.com> <8063790.J3il9MjH7d@xps> In-Reply-To: <8063790.J3il9MjH7d@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiOGRlOGJhYWQtODExOC00ZWIzLTk2Y2QtODM2ODBkM2U2ODY0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjIuNS4xOCIsIlRydXN0ZWRMYWJlbEhhc2giOiJ4NUJ5eTUrNVRGMWoyZU5pTEhJUklJcStTWkNqVit2emhmV1lRemtZRjJRS1Y0XC9rOWF0UmE1NEplQ3R3WFwvY0QifQ== dlp-product: dlpe-windows dlp-version: 11.0.200.100 dlp-reaction: no-action x-originating-ip: [163.33.239.181] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 17 Apr 2018 08:56:43 -0000 Hi Thomas, In fact Meson compile enables all library builds so you cannot turn off cry= ptodev manually. So the condition checking to disable vhost crypto build is not ne= cessary. Regards, Fan > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Monday, April 16, 2018 10:43 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; maxime.coquelin@redhat.com; shahafs@mellanox.com; > Richardson, Bruce > Subject: Re: [dpdk-dev] [PATCH] vhost/crypto: fix Makefile >=20 > 16/04/2018 16:08, Fan Zhang: > > Fixes: d090c7f86a76 ("vhost/crypto: update makefile") > > > > Vhost-Crypto shall not be compiled if rte_cryptodev is disabled. > > This patch fix this by adding checking to Makefile. > > > > Signed-off-by: Fan Zhang > > --- > > lib/librte_vhost/Makefile | 11 ++++++++--- > > 1 file changed, 8 insertions(+), 3 deletions(-) >=20 > What about meson.build? >=20 >=20