From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 2DFE21B136 for ; Fri, 2 Nov 2018 11:02:02 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 02 Nov 2018 03:02:02 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.54,455,1534834800"; d="scan'208";a="270826385" Received: from irsmsx151.ger.corp.intel.com ([163.33.192.59]) by orsmga005.jf.intel.com with ESMTP; 02 Nov 2018 03:01:59 -0700 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.134]) by IRSMSX151.ger.corp.intel.com ([169.254.4.122]) with mapi id 14.03.0415.000; Fri, 2 Nov 2018 10:01:59 +0000 From: "Zhang, Roy Fan" To: Thomas Monjalon CC: "dev@dpdk.org" , "alejandro.lucero@netronome.com" Thread-Topic: [PATCH] bus/pci: fix missing case for virtio-crypto Thread-Index: AQHUcefAzvYT+2UWs0ueVreKXjyjjqU8O8jw Date: Fri, 2 Nov 2018 10:01:59 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C604334D4B41@IRSMSX101.ger.corp.intel.com> References: <20181101121009.86287-1-roy.fan.zhang@intel.com> <2772595.iFPTlCQAWG@xps> In-Reply-To: <2772595.iFPTlCQAWG@xps> Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiNjRjYjhmOWYtYThlNS00MjdlLThiMGYtNGE5NDY5NDdiZDVkIiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoiTTNPdUNOeE92ZjVDUnJmUlgxbkJyWFUxOFBjVXJcL2ZlWEV2UXpIdHhLVGhUeEFOS1owTVgwdXFQN0F4cmhVZXMifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] bus/pci: fix missing case for virtio-crypto X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Nov 2018 10:02:03 -0000 Hi Thomas, You are right, the problem can happen with any PMD falls into RTE_KDRV_UIO_= GENERIC and RTE_KDRV_NIC_UIO driver type. As riginally rte_pci_read_config(= ) only covered 2 out of 4 possible driver types' . The patch was submitted for fixing the Virtio Crypto Initialization Segment= ation Fault problem introduced in 18.11 RC1, and it did. The problem is I d= on't think the patch will fix all problems of rte_pci_read_config(). Even I= added RTE_KDRV_UIO_GENERIC type into the switch case there is a remaining = RTE_KDRV_NIC_UIO type I am not sure where to fit due to the limited knowled= ge. That's why I write the patch title like this. I hope someone else with bett= er bus knowledge could submit a complete fix patch. Best regards, Fan > -----Original Message----- > From: Thomas Monjalon [mailto:thomas@monjalon.net] > Sent: Thursday, November 1, 2018 1:35 PM > To: Zhang, Roy Fan > Cc: dev@dpdk.org; alejandro.lucero@netronome.com > Subject: Re: [PATCH] bus/pci: fix missing case for virtio-crypto >=20 > 01/11/2018 13:10, Fan Zhang: > > The recent change to rte_pci_read_config() caused virtio-crypto device > > initialization always failed as it has a RTE_KDRV_UIO_GENERIC driver > > type. This patch fixes the problem. >=20 > Hi Fan, > this issue is not related at all to virtio-crypto. > It can happen with any PMD, right? >=20 > In the title, we should mention UIO generic driver. >=20 >=20