From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id E380C1B1ED for ; Wed, 9 Jan 2019 12:30:22 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2019 03:30:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,457,1539673200"; d="scan'208";a="124541978" Received: from irsmsx105.ger.corp.intel.com ([163.33.3.28]) by FMSMGA003.fm.intel.com with ESMTP; 09 Jan 2019 03:30:21 -0800 Received: from irsmsx101.ger.corp.intel.com ([169.254.1.213]) by irsmsx105.ger.corp.intel.com ([169.254.7.116]) with mapi id 14.03.0415.000; Wed, 9 Jan 2019 11:30:20 +0000 From: "Zhang, Roy Fan" To: "De Lara Guarch, Pablo" , "dev@dpdk.org" CC: "akhil.goyal@nxp.com" , "Trahe, Fiona" Thread-Topic: [PATCH v3 1/2] cryptodev: change queue pair configure structure Thread-Index: AQHUp6jDg9GIUpezME+VkD2+3ba3oqWmzZRA Date: Wed, 9 Jan 2019 11:30:19 +0000 Message-ID: <9F7182E3F746AB4EA17801C148F3C6043353D7BE@IRSMSX101.ger.corp.intel.com> References: <20181211103402.81914-1-roy.fan.zhang@intel.com> <20181221135550.80745-1-roy.fan.zhang@intel.com> <20181221135550.80745-2-roy.fan.zhang@intel.com> In-Reply-To: Accept-Language: en-IE, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-ctpclassification: CTP_NT x-titus-metadata-40: eyJDYXRlZ29yeUxhYmVscyI6IiIsIk1ldGFkYXRhIjp7Im5zIjoiaHR0cDpcL1wvd3d3LnRpdHVzLmNvbVwvbnNcL0ludGVsMyIsImlkIjoiMDA4ODJkZTktNTNiYS00NGVhLWI5NzctZjIyNTE4Yzc1ODM0IiwicHJvcHMiOlt7Im4iOiJDVFBDbGFzc2lmaWNhdGlvbiIsInZhbHMiOlt7InZhbHVlIjoiQ1RQX05UIn1dfV19LCJTdWJqZWN0TGFiZWxzIjpbXSwiVE1DVmVyc2lvbiI6IjE3LjEwLjE4MDQuNDkiLCJUcnVzdGVkTGFiZWxIYXNoIjoibXF1MENWYTEzaDVmZjIrRFptZEhyQk01MHU2ZWNTMlh6aUl0N0lGVkhjdmlcL2RiK0ZTdXZtbnplKzVtOE1rSUsifQ== dlp-product: dlpe-windows dlp-version: 11.0.400.15 dlp-reaction: no-action x-originating-ip: [163.33.239.182] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 1/2] cryptodev: change queue pair configure structure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 09 Jan 2019 11:30:23 -0000 Hi Pablo, Thanks for the review. Comments inline. > -----Original Message----- > From: De Lara Guarch, Pablo > Sent: Tuesday, January 8, 2019 11:21 PM > To: Zhang, Roy Fan ; dev@dpdk.org > Cc: akhil.goyal@nxp.com; Trahe, Fiona > Subject: RE: [PATCH v3 1/2] cryptodev: change queue pair configure > structure >=20 >=20 >=20 > > -----Original Message----- > > From: Zhang, Roy Fan > > Sent: Friday, December 21, 2018 1:56 PM > > To: dev@dpdk.org > > Cc: akhil.goyal@nxp.com; De Lara Guarch, Pablo > > ; Trahe, Fiona > > Subject: [PATCH v3 1/2] cryptodev: change queue pair configure > > structure > > > > This patch changes the cryptodev queue pair configure structure to > > enable two mempool passed into cryptodev PMD simutaneously. > > > > Signed-off-by: Fan Zhang > > Acked-by: Fiona Trahe >=20 > ... >=20 > > diff --git a/doc/guides/rel_notes/release_19_02.rst > > b/doc/guides/rel_notes/release_19_02.rst > > index 47768288a..4420c2441 100644 > > --- a/doc/guides/rel_notes/release_19_02.rst > > +++ b/doc/guides/rel_notes/release_19_02.rst > > @@ -130,6 +130,11 @@ API Changes > > ``rte_pdump_init()`` and enum ``rte_pdump_socktype`` were deprecated > > since 18.05 and are removed in this release. > > > > +* cryptodev: as shown in the the 18.08 deprecation notice, the > > +structure >=20 > Typo. "the 18.11" deprecation notice. [Fan: Will change]=20 >=20 > > + ``rte_cryptodev_qp_conf`` has been added two parameters of > > + symmetric > > session > > + mempool and symmetric session private data mempool, and the last > > parameter of > > + ``rte_cryptodev_queue_pair_setup()`` is removed. > > + > > > > ABI Changes > > ----------- >=20 > I think we need to bump the ABI version of cryptodev due to this, in rele= ase > notes. > Also, the deprecation notice added for this change, should be removed in > this patch. [Fan: Will do]=20 >=20 > > diff --git a/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > > b/drivers/crypto/aesni_gcm/aesni_gcm_pmd.c > > index ebdf7c35a..abc7a6d5f 100644 >=20 > ... >=20 > > --- a/examples/fips_validation/main.c > > +++ b/examples/fips_validation/main.c > > @@ -39,7 +39,7 @@ static int > > cryptodev_fips_validate_app_int(void) > > { > > struct rte_cryptodev_config conf =3D {rte_socket_id(), 1}; > > - struct rte_cryptodev_qp_conf qp_conf =3D {128}; > > + struct rte_cryptodev_qp_conf qp_conf =3D {128, NULL, NULL}; >=20 > Is this OK? Below, it looks like a mempool was passes (env.mpool), but no= w it > is NULL here. [Fan: we do not need a mempool here as none of the session-less scheme will= be tested]=20 >=20 > > int ret; > > > > ret =3D rte_cryptodev_configure(env.dev_id, &conf); @@ -52,7 +52,7 > @@ > > cryptodev_fips_validate_app_int(void) > > return ret; > > > > ret =3D rte_cryptodev_queue_pair_setup(env.dev_id, 0, &qp_conf, > > - rte_socket_id(), env.mpool); > > + rte_socket_id()); > > if (ret < 0) > > return ret; > >