DPDK patches and discussions
 help / color / mirror / Atom feed
From: "Zhang, Roy Fan" <roy.fan.zhang@intel.com>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
	"dev@dpdk.org" <dev@dpdk.org>
Cc: "stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] examples/vhost_crypto: fix unchecked return value
Date: Mon, 24 Jun 2019 12:25:18 +0000	[thread overview]
Message-ID: <9F7182E3F746AB4EA17801C148F3C60433642F88@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <8bd6f9c1-b788-b569-ec9b-1bececa2bf5f@redhat.com>

Thanks Maxime.

> -----Original Message-----
> From: Maxime Coquelin [mailto:maxime.coquelin@redhat.com]
> Sent: Thursday, June 20, 2019 10:44 AM
> To: Zhang, Roy Fan <roy.fan.zhang@intel.com>; dev@dpdk.org
> Cc: stable@dpdk.org
> Subject: Re: [PATCH] examples/vhost_crypto: fix unchecked return value
> 
> 
> 
> On 5/15/19 6:25 PM, Fan Zhang wrote:
> > This patch tries to fix the coverity issue of unchecked return value.
> > Since the function that causes the problem is unused, it is removed
> > completely.
> >
> > Coverity issue: 336816
> > Fixes: f5188211c721 ("examples/vhost_crypto: add sample application")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Fan Zhang <roy.fan.zhang@intel.com>
> > ---
> >   examples/vhost_crypto/main.c | 6 ------
> >   1 file changed, 6 deletions(-)
> >
> > diff --git a/examples/vhost_crypto/main.c
> > b/examples/vhost_crypto/main.c index ac7118e7e..cfb9dfda2 100644
> > --- a/examples/vhost_crypto/main.c
> > +++ b/examples/vhost_crypto/main.c
> > @@ -354,12 +354,6 @@ static const struct vhost_device_ops
> virtio_crypto_device_ops = {
> >   	.destroy_device = destroy_device,
> >   };
> >
> > -__attribute__((unused))
> > -static void clrscr(void)
> > -{
> > -	system("@cls||clear");
> > -}
> > -
> >   static int
> >   vhost_crypto_worker(void *arg)
> >   {
> >
> 
> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
> 
> I'll change the title to:
> examples/vhost_crypto: remove unused function

  reply	other threads:[~2019-06-24 12:25 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-15 16:25 Fan Zhang
2019-05-15 16:25 ` Fan Zhang
2019-05-16  8:07 ` Jens Freimann
2019-05-16  8:07   ` Jens Freimann
2019-06-17  9:09   ` Zhang, Roy Fan
2019-06-19 11:56     ` Jens Freimann
2019-06-17  9:26 ` Kovacevic, Marko
2019-06-20  9:43 ` Maxime Coquelin
2019-06-24 12:25   ` Zhang, Roy Fan [this message]
2019-06-20  9:59 ` Maxime Coquelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9F7182E3F746AB4EA17801C148F3C60433642F88@IRSMSX101.ger.corp.intel.com \
    --to=roy.fan.zhang@intel.com \
    --cc=dev@dpdk.org \
    --cc=maxime.coquelin@redhat.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).