From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0DBACA0471 for ; Mon, 12 Aug 2019 13:25:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id D5AD21BDFD; Mon, 12 Aug 2019 13:25:10 +0200 (CEST) Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 366EE8F96 for ; Mon, 12 Aug 2019 13:25:08 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga101.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 12 Aug 2019 04:25:08 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.64,377,1559545200"; d="scan'208";a="200090075" Received: from fmsmsx107.amr.corp.intel.com ([10.18.124.205]) by fmsmga004.fm.intel.com with ESMTP; 12 Aug 2019 04:25:07 -0700 Received: from fmsmsx117.amr.corp.intel.com ([169.254.3.69]) by fmsmsx107.amr.corp.intel.com ([169.254.6.225]) with mapi id 14.03.0439.000; Mon, 12 Aug 2019 04:25:03 -0700 From: "Wiles, Keith" To: David Marchand CC: dpdk dev community , "Burakov, Anatoly" , Hemant Agrawal , "Sachin Saxena" , "Yigit, Ferruh" , Stephen Hemminger , "Ma, Liang J" , "Mccarthy, Peter" , "Matan Azrad" , Shahaf Shuler , "Yongseok Koh" , Viacheslav Ovsiienko , Maxime Coquelin , "Bie, Tiwei" , "Wang, Zhihong" , "Xu, Rosen" , "Zhang, Tianfei" , "Ananyev, Konstantin" , "Richardson, Bruce" , Honnappa Nagarahalli Thread-Topic: [dpdk-dev] [PATCH] remove unneeded eal header inclusion Thread-Index: AQHVUNsulgLqZkRoG0CXKoNHWsVnlab31MuA Date: Mon, 12 Aug 2019 11:25:03 +0000 Message-ID: <9FC063DA-0039-4D1F-882C-57945F34D9A2@intel.com> References: <1565592813-5164-1-git-send-email-david.marchand@redhat.com> In-Reply-To: <1565592813-5164-1-git-send-email-david.marchand@redhat.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.255.89.126] Content-Type: text/plain; charset="us-ascii" Content-ID: <572C7FD846637C4784C4230E9FC23223@intel.com> Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH] remove unneeded eal header inclusion X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > On Aug 12, 2019, at 1:53 AM, David Marchand w= rote: >=20 > Restrict this header inclusion to its real users. >=20 > Fixes: 028669bc9f0d ("eal: hide shared memory config") >=20 > Signed-off-by: David Marchand The only thing I would suggest is to add the name of the header file in the= subject or body of the commit, as currently it is not obvious reading the = commit title or body. Regards, Keith