From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM02-CY1-obe.outbound.protection.outlook.com (mail-cys01nam02on0062.outbound.protection.outlook.com [104.47.37.62]) by dpdk.org (Postfix) with ESMTP id 0C611952 for ; Tue, 21 Feb 2017 14:40:57 +0100 (CET) Received: from BN6PR03CA0039.namprd03.prod.outlook.com (10.175.124.25) by DM5PR03MB2954.namprd03.prod.outlook.com (10.175.106.140) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13; Tue, 21 Feb 2017 13:40:55 +0000 Received: from BL2FFO11OLC016.protection.gbl (2a01:111:f400:7c09::101) by BN6PR03CA0039.outlook.office365.com (2603:10b6:404:10c::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.919.13 via Frontend Transport; Tue, 21 Feb 2017 13:40:55 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BL2FFO11OLC016.mail.protection.outlook.com (10.173.160.82) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.919.10 via Frontend Transport; Tue, 21 Feb 2017 13:40:55 +0000 Received: from [10.232.14.39] ([10.232.14.39]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id v1LDeqTR007610; Tue, 21 Feb 2017 06:40:53 -0700 To: References: <1487684578-28656-1-git-send-email-shreyansh.jain@nxp.com> CC: , From: Shreyansh Jain Message-ID: <9a1992c3-d977-4c3f-21cc-7b4bb5a68270@nxp.com> Date: Tue, 21 Feb 2017 19:15:42 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <1487684578-28656-1-git-send-email-shreyansh.jain@nxp.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131321580554426823; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(336005)(7916002)(39400400002)(39410400002)(39380400002)(39450400003)(39840400002)(39860400002)(39850400002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(189002)(377454003)(51914003)(24454002)(199003)(65826007)(50466002)(76176999)(47776003)(50986999)(104016004)(6246003)(31696002)(86362001)(6666003)(54356999)(65806001)(2351001)(85426001)(5660300001)(105606002)(53936002)(23746002)(36756003)(31686004)(83506001)(106466001)(97736004)(189998001)(38730400002)(230700001)(110136004)(229853002)(68736007)(305945005)(65956001)(2950100002)(6916009)(4326007)(64126003)(356003)(92566002)(4001350100001)(8676002)(81156014)(54906002)(33646002)(77096006)(81166006)(8936002)(626004)(2906002); DIR:OUT; SFP:1101; SCL:1; SRVR:DM5PR03MB2954; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BL2FFO11OLC016; 1:hSMDF57mQ10gwDwnEJWzazFsEENKzv0MWXVfHufhRUalwUyI2Xriq9+1p1PQMboYZERhSLiLhiKZ5R1BbQzdDzlToblBDCh0thpEoLkkoPVPs6ML9P6IKv+RSw59ZdsbkcLEbfYtn00arYTSUrHKARRYL5D0BqcZddT1+McErS0/5Kb3QSr18xaIAje8N14dVTcdb3QuFYvppay8OwHOxlSrzrAvoZr2wI5PTuHs+04PcxRHdiTUbLCJ05Ka7DvRhGQ2gOlDyXvIfjVqvhTfGNsQvoyZtyrN0PQ3lJxfasrXDLSj9MN/Rut81gvLYy2YNUsqwzwZWW/t92zP50FeHXFyowvYUWsMb8WK1xgvm1mB5SFJadpJx8GQwt3MnHCDuytnY2w20H+ZHar5cHwjzLu+YgQjj7cc1KZPb4Z4Ufr7k4js42X2ipLWR82/TNGeXkGAgnQc+HhjdceJnlnHaek4qxp64LwVcFq/LQKFhaxZUkdZvUfN7//153y4hmVxie9+pg4p7wy+T0Tlj3oQ9k4yCQCDsN4xxTbO5JNO7SHeZgJWvtgTrh9cJcrlFCnTpGbzH8FyAjPjtjRx7da67QNi62oCcQA8ppK4VLOTuyBcDMR0xsXL5ZIKT2w3BhxR X-MS-Office365-Filtering-Correlation-Id: 035d9ac8-91cf-4236-19c7-08d45a5f42c1 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DM5PR03MB2954; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2954; 3:O4LpwFcdlQFtTq9U3Q2I4q732WKLeRlyVxEXxMGk3/rzkZ+qyXPjgx/GMCT8vazQR3L2PZVBA/+jUtwpBUl7zTtzlhBPL1xVmpnPf0HEej9+JFEsxzQto3r6ZekGUZImmo4+gZxvTe7IFE3/OGtr2bbT/BEFS47f4dkCnH+tGxm0rBh8Ua2QJlhFWeOyB6C6OchX1yCT0rJ/02cQZ6wOV7kTuMYI19JVScJHgt2+KfUhV5BNCYayG/eeOgG8Z9wnC0wBdiEtwk4vnBPUghZcnuoVS8+YOqqC/WY5teiUU3N80X+buxZ8HRLRVj0yHrnLPqhilkkQkZGjLH2zdSn34+Ypk4NqUzHFcVkBHLTpr+O0dHXDDYtIHXAV+Yk+TgLk; 25:4WZ26TGLWbY1mUxLwOwN4iWx1oyQoPEuUreb+HZ9U+zz4nBSkX3vbkDiiHUWDOdFH4FFbGsvFPit57jjit/lN9/bs8FrfoluyNEJHxBATqFyL0YYC63bDYun+tI9J+0fAhjQOxwb1Vriz24v6RZ8ssaZ2bw6XZ3zIK6U09k0ETuUyi3TWdff0cmWmMJSiZ19FHiVTyOAa/zOruBLibaBfzfiR0cWNr89m0TyboeZC7dxZGNdN1p1cd2gP4FVCEqvor7TpPxiwHJCeXyWwxowWOvN0I9RjF3SS8eUwMjEVz1lvnzyaTbhKDQPenqv6kzgte5bDnrWRRnl9Pi0ZTcoBdQbQFK+NXCd3mmXnzWmvWR9pLhVT6XnoUCaeOiaiSWBfBX4oU2119nsfrWcQf9WCubKrQtquuAFUkSzlyE1f9Y2tlNj0n8BECJcCtwa/MPhHgZok962AhTNfTA53HNFWg== X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2954; 31:mOZSbSymL+/0iuFkFAV+dHSPkeun5fXkuynOEDh/cMt/6y27au8NPt5hQ0U3VEbyBoQUI8W0W79wVukS30lkZ38KqINy/TxSYibvVPq4HrvamvXKxHHuIPEqO6MWarYiWyAt+Vs5q0zw8yzwECEWjOUdjJtVjT+tAQLZT59JQIWCvA6y961URoIZtKGQMsXFHPem7omzvWWS+mRbR73MPeSHpJ1iFZ+PnGw6Z6Y4tkc31iiemXbC5wigd2+qtHZen+xTV3SURt/w7PN+ccDVeKoNwC/7CH6I5wquPGntajo= X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6095060)(601004)(2401047)(13018025)(8121501046)(5005006)(13015025)(13023025)(13024025)(13017025)(3002001)(10201501046)(6055026)(6096035)(20161123565025)(20161123563025)(20161123561025)(20161123556025)(20161123559025); SRVR:DM5PR03MB2954; BCL:0; PCL:0; RULEID:(400006); SRVR:DM5PR03MB2954; X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2954; 4:UJ35+zSx3iYdpzMCkhSh2a1evV8AWd+c/7RmgbFweGx2MfuvZeqMGp7u3xdj8pRhtvJAkNAqol8J8wVq+43DL/vKKzN/CWLDhcyluyNWE2G4TCUg7AAIMwJ9b6z3vuJdt+BHBge6+ZoUrpyjrwcUWDz4s4e0OYpN9ax/CVdasly2DwNUMmn+2ZNiGjv2pVvJ3ArsFtuLT5fqAKbvPIbRN0twGhGPaYR/4WZG730mcqJLe6td/12h8FhU/VArSbBVqB2nlZ7mO9+vf0aW3tHH0klp3iFpKiUg1nkur6EaflLjk3K/UE4/Vy8AcShqVxiBKB8rNubb7oJwKdwdun4vRf4AFWmS8LPuDG/T3xt7pssAWw8BNEm5FWvSeTSaUOgXsocoEXL7zaJO6/nYyfZ6kmzVvDajhapGvsEOvcJ/2K4yeB421MtG66gl7Rbb/IWLOeCiFLYDzOuJRLwN0axLXdmSKfBIykcKCzj8ja2vgpugFG8eFCq8IsUMwLd5HiUx/7LzT798AXA6p0VQ7xSFuEvJb0An3Wx1ud++W7jwgklkJbNEzsoQNVRUifcVsznonAfmR7haYPTGOrzz7Ws7K3AFde+3qpVFqHtn5rY7B2aJvdLYET3xgkFDfhqMagoRVrS5xg2CogL1gis+JPxg62zqxhO9hAv8sTVWjFuv3oJv8XiXZyPmXsYvlyZpBSf+PBR7QMyXWS4L7RlIlZ3JTw== X-Forefront-PRVS: 0225B0D5BC X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; DM5PR03MB2954; 23:DYn5G5lW5iJ2IkV6HfuvGR7A6rMylY2TbNs8U?= =?Windows-1252?Q?UDIqgZj5qw1ZSp6Qxgyh2OlMBBI51Rjt7dUJSvewDnViqD0Ydw8Up+Ee?= =?Windows-1252?Q?A2GDDzPeaiyIvcbllSDxqShtqbp6yTrrP79zRrmve6bprMnjBEA3Luli?= =?Windows-1252?Q?QW4YHe/MDC99r489pqGtRQY8eYpKcFTyXwUo0414qJVD2JjoLlqUh54R?= =?Windows-1252?Q?KZaES5ig/olii03dp8TFnWjKvEa4tN57iRyqxHx+8yWGKPal4xgRBzMX?= =?Windows-1252?Q?NPUfT1mZOYeYYtV0tUmDQzPqao43FRmCFRrwb+uaqkAapnPSlsoFaAFM?= =?Windows-1252?Q?z49HPQmm4U+Ts3Rb0uWW/VlxETMjJmKuAXNgrk7dW9EyyVeS0y56en5f?= =?Windows-1252?Q?TIWq+lgQSDoe4Fyv7FQ2ixriTkM0vuuLCaz0TiG6HHaK7NiMghI3p1FK?= =?Windows-1252?Q?dwIqCYfKCTPQDbLt5rCvws5XHup5N2HvpF/keMw/pQ77CmKTJZ8pnnUf?= =?Windows-1252?Q?DRYRG78dgyvrewrbo7VsDyx+X4LXeLUrrHOnx8FEGXVnnegKPDU+I4CY?= =?Windows-1252?Q?6MfP2F263T56MVPTOqPE2DZTsRLc250XFVMbd5kcqyhun2cYkFj5viUl?= =?Windows-1252?Q?mBQ69nMSKJZ6ZfLh1lQ1MfitG+8YJL9X8GwXSW5GscvjKqAC2SKhacbC?= =?Windows-1252?Q?pr8s0C1WwXB/DBl+CUL2jriqj7x3YCJOJK8ox3fQHxxNmgUqok69zQIP?= =?Windows-1252?Q?eKuk3kSuw2Q83KGl5AvcXSiXX5sr/2iK5eP+0//oe+xus+Ior/ZeG3gh?= =?Windows-1252?Q?RI9nF8/IPOn/u+UuGz4lGqEZq59eTo2lfC3xwURGjuaaTk3T2TNmBXG7?= =?Windows-1252?Q?oQs07tBHKXo8jVdBJAcX1/e+6CqKz4uoToPbxQHjwVYRYvihG0W0UGI/?= =?Windows-1252?Q?okiUebzvz7Lx+G89eMLTpHmy/avYILvHQqS/rK90JrbnDYjq/sXv894B?= =?Windows-1252?Q?aD2r/6SeXgvSjpV3QulDHQvNOU62UE3cqajHsvLcJqhRh8FJey8zmH0L?= =?Windows-1252?Q?m79gP9tEgSgt7wk5ZWtBmTg6i1A+mXc6siCu3VlTvuLqgBWrJEAa81hZ?= =?Windows-1252?Q?ZjcqR3Zlxm1B35wOx1MvlX8UzHEC/WWjt9U9mesRwQBy3ymyyvFUdFs/?= =?Windows-1252?Q?XpaaWf3/dDNJUOkahrKut9ZRY5LpwQm4KBTi7Inratq9H5/cqKsb3bxA?= =?Windows-1252?Q?iTgJ74bjqbaA3URB/e7BAWaF0iN9C/qOmymaAp/LHncrxVroU2EBFVbz?= =?Windows-1252?Q?nzreoM6rC5jqykkuVYjtYnub5YWkOyiCThYLXCurvHT4n/+NJte/SmgU?= =?Windows-1252?Q?1l4fwyUlboqcDTXePweXbHOeSW07qDL7xyg/eQ3enWhDCcwx5WSI1fbz?= =?Windows-1252?Q?2YmgHJBZgfMldEgzOKTA6THLrZNUMtr4VX0gT7a9kYbWltLgA1RlYn46?= =?Windows-1252?Q?P8VYfvM6hcCyblITl99SPQ2E9mxjpJb1NZs/7MaTHgKXi5c8xWmyGPy9?= =?Windows-1252?Q?NQHGmW6n2hFfJ7dv8RuraIXzacOWct/qNpMef5gR8g28boBDOWhl3ke8?= =?Windows-1252?Q?0U+Et1xjPopR0iEesTTD8xt5hzMZRQBN/fNAr+flxjyGRKjNYyjJnexs?= =?Windows-1252?Q?3Xz/HUrTXorINl/fmZUmdsy93BOG5Ebwqfn5YDx2PgKGFWRm5iR?= X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2954; 6:V5cGxvxtgEQovX7vt/fKxh0L4w+kFAHMNtGEGh5NNvJFmJVonC6U6DDr6sJrANNlCPtP9Y7NB+1YmhUbdY8Ofam6h4CgFZ7v8MganmDzy6Howj6L/GjwBMP8Qs0bY0zLeLSnMfRb1ENl6cBvH3hVCvhJs+BmXFXaYdHmUfq2EEK3CsEvxAeJW5zxzISLFQh4uANI8d15m9ID6eaWIJ+Fa+QYAcqgpONxH6MJd0Y+BtqCEXXen0yxpfNKqY+e7bhyZD61VnXHA3CVzP8h9STCDMXNY+iYeNd2MjU7v3F/IAlinrcvs1GpfnZkG6f+OmKDt72uQxzsdMhdIAx9aHEGblRqmkq+Kbut9y8OqoJjeMYTPSLBfajRtJjQndr3m76Ubqcr2Jndm8LxDT1JOEnq7/kG2YpEtFgK7+Liektc47o=; 5:ExIzV8mxSvz89uLarLrtUO+coFR62TnLwEJSEONzxC1ZcVfkqQvpfCvsQ5+0oickU/xDV3PYMf5HPL/EwXRVyXiGHI2cS2iE4L0WyDA2acn1jDEMHf4ykzwWM7YpVAjT4C++WBizoDWBwMjXELJr8lAJPRxfK3PFd3eJmul7moh8I8T7T+vL2l1GJA7UUu47; 24:xhcKkNYJxNJYgCKfZIHZkF7jz8MMATavUHae2PKaLcl4W3c3neQgt44vL+iP4iHHBe91UpQQTRSgGBaOjd91OZdkbCfDIoNkaaKhr7sqJSU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; DM5PR03MB2954; 7:MWsmaW29jX7RmmNxSAe6BJLQFa5y2FLeUiB9xgki5GTcAMmbIAd9AqFtv6dHLSLYbEX30689lRA7xMIwq6PIUgZLfkemyiQDM/K+IVhkZ5lQH1411LokO/y3/eQxyUR7DBH71ld1/fo93br7DoWTLgL3kvXMhmamZAVjCii98mq/f/Yg3YY4CAmd2NvPfvwyte1gdBYL/uwsRcu/56UBK+QdcY+4OQQ2hoJWdqxP8plfan21Uyz9qQSGBbSwZ7v8LHQAoAzY9M+FEH5C7iYhPZameYn56R1YkZ9DS0fmGkkP23iJi1DX0slJX1NgcpDOiuxf4oS3d69f4Fu2JkXDug== X-MS-Exchange-CrossTenant-OriginalArrivalTime: 21 Feb 2017 13:40:55.2710 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR03MB2954 Subject: Re: [dpdk-dev] [PATCHv7 03/47] common/dpaa2: adding qbman driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Feb 2017 13:40:57 -0000 (Modified subject to: "Re: [PATCHv7 03/47] common/dpaa2: adding qbman driver") On Tuesday 21 February 2017 07:12 PM, Shreyansh Jain wrote: > Thanks for the suggestions about rte_* renaming in DPAA2 PMD. > I create a draft patch for a single symbol change. (applies over v7 > of DPAA2 PMD) > > Can you tell me if this is the direction you were suggesting? > > I see two issues in this approach which are somewhat problematic for > me to change all the symbols: > 1) We saw a drop of over 5% when I replaced only 3 symbols (one > of the most used ones, just for sampling). This also means that > when more of such symbols are replaced, it would bring further > drop. This was case when I used the Shared library approach. > (*) I am not well versed with gcc symbol aliasing to comment for > why such a drop would happen. But multiple test cycles confirm > this. > 2) I have to include a new header in almost all the source files for PMD/ > Pool/Bus etc. This is besides the STATIC_SYMBOL macros across the > code. Essentially, any internal repo patch cannot be directly > transposed to DPDK repo. Increased effort for each internal-> > external release > > Overall, I would like you to consider if this effort for changing names > for exposed symbols is really useful or not. > > There is another approach - that of not using a drivers/common library. > This again is problematic for us - NXP DPAA2 being a hardware, the lib > and state for Crypto and Net hardware is tied together - so, having > multiple instances of library breaks either of Crypto or Net PMD. > > Any other suggestions? > > - > Shreyansh Apologies for the modified subject in the previous email. While sending out the patch, I didn't pay attention to the 'patch head line'. - Shreyansh