From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6591642D09; Tue, 20 Jun 2023 17:59:58 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3DE39410F6; Tue, 20 Jun 2023 17:59:58 +0200 (CEST) Received: from NAM12-BN8-obe.outbound.protection.outlook.com (mail-bn8nam12on2068.outbound.protection.outlook.com [40.107.237.68]) by mails.dpdk.org (Postfix) with ESMTP id 78596410D7 for ; Tue, 20 Jun 2023 17:59:57 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=dt1M+Fuwce+Gy2z7dHkNzYnUV10aqmsnzR8uzPOrIjWbW4bPUlyBwtucG7PTlssNbTY5fmZbpPKp+Yx0LooZISbsBp/646QzMAn+CvEsqannOzXzPXmU/G2da86py6ZWJ9t4UXp3z0O0sFy7bTnvxLxtj4MpwEFFnYpZKCUKj1gycOUI97PU13M011e3IraMZOU7c1QNO3TqKWlGl5o50cPgxDmcaDaVYToYhWvvEbTT8LCt+X+O+R8frSBF7XxyvxWH70XWAlhTkzxWxPTF/YkAC9RpW56KhTzc8TmXuzG/lez/B5MGEHXSxaWNtj8lQfbT1RoLzGWdLj4Fbw2+gw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=lrKULzVe+XqBUmtFnFIrGeVlCOOXj7f8lPMc2d3buPU=; b=h/E2NSDZ6txRC/HBReWZ6+YxZcRVBl8zC0ZaYu/EDEzVw7C8VH1y00JfPeQ2z+uHHn+1ZASjfbshvBeiR2O2tyok4BAMaa58vo7L5/ivK8Lv4ZVSuyE63e8agPUZUdpdnMjKk028f/sNkCi5YVJdSWugngwI9oOHIApmKRxSBqJ7SLnrbFvyGzYJ1qBGrXoBPYPNcp2gNTGAl63VzbIy2dQPwbiJzdUrJnrzALiqHV+dfQrhHucv6BuFulzqS7OZ9GP4MAQf3a5f2Ofid2qnPWnDdocUTcRCtPQsvG5uLbbnYNOOIj13Tx34/UuYRZMgCPVy+k36edAO8xyy3JCHUw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=lrKULzVe+XqBUmtFnFIrGeVlCOOXj7f8lPMc2d3buPU=; b=P9Rs822e1RZONRHw4Q/rGq2/YTVKciVPAob8ACcaLsjlQ9BDdcAxTohzd+1e5fIVdWJb5Z5pEzgkhQ1ZgdH8r3yzD2V3azQb/fOVfsFGvLvMwO2kHgfssF08sstpcRUabq8EDxqXosbi/0LuG9G69p52iZ6+LI8xGzUf3Idqi2E= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SA1PR12MB7173.namprd12.prod.outlook.com (2603:10b6:806:2b4::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.21; Tue, 20 Jun 2023 15:59:54 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::16e3:326c:5c2a:be42%3]) with mapi id 15.20.6500.036; Tue, 20 Jun 2023 15:59:54 +0000 Message-ID: <9a362506-ffd1-3a22-8f98-2b928f96da01@amd.com> Date: Tue, 20 Jun 2023 16:59:49 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH] ethdev: rename functions checking queue validity Content-Language: en-US To: Andrew Rybchenko , Stephen Hemminger , Thomas Monjalon Cc: dev@dpdk.org, Aman Singh , Yuying Zhang , Dengdui Huang References: <20230614152100.1664198-1-thomas@monjalon.net> <20230614094446.0e5d6047@hermes.local> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0220.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a6::9) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SA1PR12MB7173:EE_ X-MS-Office365-Filtering-Correlation-Id: 391bb2f6-2a9c-4006-4408-08db71a76373 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 5VdNASr1xMR26FHSto8bANIbwmcR775SGQNZkpTmScK3dpBElWQmCQ1/fxFo21xr8TX4D/nn/GZ5EaV2NCu189dRgXv47eWY4JP+R0Oiz9mLGpLtkgONyIzANc209pI1l6GO7o4qF30yx0o89HwmJHlIVGPw3rxUmFtKStwdjGVoRQjctFQ5V7MC2reFjNkAIGdBWCDox9xP/3c3Cg6BiMOCd5glW7xdXW2sWhsri+E4f75rkQS6fpe2/WRYKag0TgYuwCwZqAg8q1J+tSZcnBdqVOY0P2x0t4zql7qtTfV0Hy+RgiYHsE4C9UhOST7wMiPZJalmU/zqkJMQo98KzFWj7osJLIn42nLXV7rU1fak6dlCsOYCdWhFNGWhPOPz55rix33gNXFDfTvqyb96KnCTGGdG7k9cHmrKnDYqLuIdM/yfOU4e+slYLl5zlpdtkhago1PaCIT9z0DXsMZgn5SgPavrFXQ+UniUBuRWPzGguLm8Ah5KqqKoBllls2N5/8UyggTauMsDxmsS3Rz4p+lzLZRn6U7CQLnN4suTCWsIzTiPHCPqDHloKQq6nEw3n/KBh9FqurqHdZVp5tx0Ec4rp2oz7abyvCLgHGAs73Wa0OdjWI/hdbj0xFXDYu8I4ED2BmPx1DUxgV9ppBYOZg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230028)(4636009)(346002)(376002)(366004)(39860400002)(396003)(136003)(451199021)(6486002)(478600001)(6666004)(83380400001)(110136005)(54906003)(2616005)(6512007)(26005)(6506007)(186003)(2906002)(5660300002)(44832011)(36756003)(38100700002)(66946007)(31696002)(4326008)(316002)(8936002)(8676002)(41300700001)(86362001)(66476007)(66556008)(53546011)(31686004)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UmpLNHAzTGVNViswYWYvdnJzd25TWTJ6c1BSUERNWm1BTnR0Z1dmaHBrTkQz?= =?utf-8?B?NVVqM0tQRUQySjlyUkFrL2JuZG5weENYNTVOVE1MU21FWXNwM0pJeE9UN1RM?= =?utf-8?B?dHNxNkcyN1JZbEUyeUZUSUgwb1NFVE1Wd1BWbmdqWjZDWERUMVhFNEljYkR2?= =?utf-8?B?eGVVSWRMZVBNdGd0NXY0WElDWmRUNmE1OUR6UDNBWU9iYzhNeFJlOG1VU24x?= =?utf-8?B?cHB2dU5XZjdqL2s5dEVaK0VXZGEyYmFZZG5VTTlJNHd5VWgzUmNYOWR4TDZW?= =?utf-8?B?RXdybW92VzZsTnRCZ1JNWnkwTVpPd0RsR1laOFdjWm5Dbll3NGlDRFJhQXVC?= =?utf-8?B?WlE1NHZaTThNUmZqWXQrendUNGtHMUNIS3VrenAyQnNtVjc2WHRZMk01Y3FO?= =?utf-8?B?SnY2amlDa01aZFdQbUE0NGQ2dTR6TTYvaWJCcHI2elVSaWtjL3NIWEUvckd5?= =?utf-8?B?MFAvNXZ1UlhVUm5YYzJVMHA4Q3ZTUVpmK1FNWERtM1dKWmIwa3U5MVZhWllO?= =?utf-8?B?U0JlVTVmcFRINGtBSXBHM0dqTURIczBqMjhVa3QxSWlRbmZGMitoaFhMOTFk?= =?utf-8?B?ZUp1RUdXM0N6N3loYjVtYXlhS2FvZmIwRkdxR0hmSjVoVDJ0SEs4S0FvenhR?= =?utf-8?B?QTNNc2ZqSjA1S1lhaUlwMmFkSlR0eGl3dzU0U1ZsNVZlWWRyM3h5dUtOT3Z5?= =?utf-8?B?M25EY1RNTUw4bDQvZ091OFBZYkJFRmRoclpkMFg3QXNpcjNsZ0VqdVlVVnNU?= =?utf-8?B?RktmUWtNL2VUSTExUXluQUI1cDJ3K0R2MHVldEFUN2lYdStGV0ZUb0x2SFB4?= =?utf-8?B?a1ZVeEFuVzV0OFVKRTRjN3lFMjFhaUNwOVdqRDFhR0JCT3dIVnFjUlFFeXdI?= =?utf-8?B?YWNobnNUOEd1VXI4QTRuQ3NUL1F4REYvUDJSVUpnc1k5bXM0SXVBbmgwTkdi?= =?utf-8?B?Nm40c0ZZSDF5VEV1eXowYWJ1YWh4dnFtNkRzdEZSUG1kbDRDUmk0Rms3bUpW?= =?utf-8?B?L0l6VllYakdkS1dUWjRWWmh0aXZ1TTFEcDd4Y3FyOEwzU1hFYVc5S1NzaEx2?= =?utf-8?B?OGxIRmwva2wvTXlqUnZ4UStLSG5WdzRxRkFmWVhVZjdSWXRJWFZPTWdWd3Zy?= =?utf-8?B?SlRBMkRBVHRBU2hMVnhpUkdCZUwwSjdoWXZXclEyZE82MXhPYVRFYzBvMnYr?= =?utf-8?B?TFFmZGhvZEF0c3cvUEoyckRaRkhVMTVnK1duemhzcHlDdU9UODFldkNpbjFJ?= =?utf-8?B?bzd0VDhKVzd0bU15UU1FUll4bWtWVkF2Wi9VdHhmZkZmbjhzSzRXNzhVU1Va?= =?utf-8?B?VVZSNDV6M1hhaG43bGU4eUhTNkt1TTZYZnhldmVLK0NaNnF1NmlQcHdNTkNx?= =?utf-8?B?VDlKZE1PRGZsSUVlS2xSaERncHpVMlVBS1NoYnN2QWdCN0Q2MmZiTERWUFY3?= =?utf-8?B?UnBrQ1JQS3JKSnFhSEhBeCtHWXRFaHQ2SmJrdTJJSWlRVmlkdDNOaUd1UzQ1?= =?utf-8?B?enA2S2M2aFFTd2tQakE2NGFzY1RtQU11dVFwRFEzclluK2IyUHpQNVZBb05U?= =?utf-8?B?N0thUnJFN1J1bGVlMFQ3dEI5YlhDcXM5Y1pobVR1eE9oTVB4T3FYalFmUWxr?= =?utf-8?B?OCtKclBldUVwaTkrMmhrcXovTUpheXg0SUhoeCtlRWJ1L2c1aGdqS0NYVGhJ?= =?utf-8?B?RjVNaWorR3dkUkxWRWppakVudDhyZWlWekRZcDRwRWl0N1BKVnQrMFBtaUxv?= =?utf-8?B?a1lFbUVjaW5TQUs0VkpjbDhPVzB2U0JONUlPVXlkZkw5SUk2eC9EaDBCcTh4?= =?utf-8?B?NGZlNVNjdlk0SVVSSStsUmZzUnk4OGJFT1hDUFlMOVBTcHpMdW5QYTlUSlda?= =?utf-8?B?MVFtWlhjSHlnVmhaNWNvVTZ3RlhoZ0V5ay9OelVmRnBHU3IyeEhaOWhMeVI0?= =?utf-8?B?WEdjL1ZJVi9yWC9PcEhEQjd2ZytuOEd3czFnRDBpUjNOTWlmNG9NRFhvYXB5?= =?utf-8?B?R2ZydnRmZEFGdmY3ZSsxeCt2RXMzRTd0dWd2c2lGR295R0RZdXFGVkdBQk5m?= =?utf-8?B?ancxUjVGNkorRnJnQ0pjUDZ4SWtBditaUXUyK1hINDlYWWdzK2xweUdrK3RN?= =?utf-8?Q?OADFEew+VWrjIvQh2gCPLH82j?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 391bb2f6-2a9c-4006-4408-08db71a76373 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Jun 2023 15:59:54.7019 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: y6W980EHeavF85ecAlasx8J/J7ftWR3OnVWFa3KOBL6YZSrDQx7EylNP6FQpkVFK X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR12MB7173 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 6/19/2023 10:41 AM, Andrew Rybchenko wrote: > On 6/14/23 19:44, Stephen Hemminger wrote: >> On Wed, 14 Jun 2023 17:20:59 +0200 >> Thomas Monjalon wrote: >> >>> Two functions helping to check Rx/Tx queues validity >>> were added in DPDK 23.07-rc1. >>> As the release is not closed, it is still time to rename. >>> >>> The name proposed originally >>>     rte_eth_dev_is_valid_*xq >>> is consistent with this function: >>>     rte_eth_dev_is_valid_port() >>> However, the suffixes "rxq" and "txq" are uncommon in ethdev functions. >>> >>> Also for shortness, many functions are dropping "_dev_" >>> as these functions which manage the queues: >>>     rte_eth_*x_queue_info_get() >>>     rte_eth_*x_queue_setup() >>>     rte_eth_*x_hairpin_queue_setup >>> For completeness, there are some old functions having "_dev_": >>>     rte_eth_dev_*x_queue_start() >>>     rte_eth_dev_*x_queue_stop() >>> Anyway in all above examples, the subject is after the prefix, >>> and the verb is at the end. >>> >>> That's why I propose renaming into: >>>     rte_eth_*x_queue_is_valid() >>> >>> Fixes: 7ea7e0cd3a08 ("ethdev: add functions to check queue validity") >>> >>> Signed-off-by: Thomas Monjalon >> >> Shorter is better. >> Acked-by: Stephen Hemminger > > Acked-by: Andrew Rybchenko > Applied to dpdk-next-net/main, thanks.