From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 778D2A0C41; Wed, 15 Sep 2021 18:57:47 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5A8BC4068F; Wed, 15 Sep 2021 18:57:47 +0200 (CEST) Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by mails.dpdk.org (Postfix) with ESMTP id 779D44014F for ; Wed, 15 Sep 2021 18:57:45 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="222417642" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="222417642" Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga102.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:57:44 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="610253158" Received: from fmsmsx601.amr.corp.intel.com ([10.18.126.81]) by fmsmga001.fm.intel.com with ESMTP; 15 Sep 2021 09:57:44 -0700 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:57:43 -0700 Received: from FMSEDG603.ED.cps.intel.com (10.1.192.133) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:57:43 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.168) by edgegateway.intel.com (192.55.55.68) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:57:43 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VPKRkziheetBaWLJJaXCKVijUH0BpMe1+aaD30ephJqguGr7ePfN61qV49OJdkYaGX5gB9h/aQpzL+9Ui/1h3od0l9PkanzinMijTmFdCgeD4NPqT8ullUAnTxHy12kX6xLBbj/n4ZZfxtbgkfsmU6n/SvTvORy0ts4/1XBLXhwcsTl0srOoiU4H0wR1TSUpZTabonpcWVl3mSvtPjdvS88AXaeOYzc/E6yRsbtQ9fg02JvT8Mpjr1XxLGRyM0V1GBI1r5r9SSUmO9qLfYbf1kKOsejZeaWCvQJ+Z3g/qs8U8plXHPb+euZAFetqqD5Q0N9IShywcBmfGTESTV+FDw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=Tj7V5ntzOxLYIWWN4OmUXM39nqGEoes+gtwZXEqiLyw=; b=Fra0pmOPu21HHuIJAjQv98qzmFwGMNRqlMI8PVfVkaqNd5CLD1IbuJUdcSi/GVgzC09+I6iDy17jP3JeDZ3weqWo4PiwCVvrEKSAv9rNV5iSqGiKCTd1axL8WDqCmUVuGvaFc4AZ/aLL9XEaujfvZFPvbkvcOVmpEvoG4yL66TIrngkydlQVDC/6/VFCRk+cxMBFPj5bdnvF7yAlIeN0ayXHfKDiB/9dAdXpx9U6p2MeA9GsgM5MRxpNwMcJUQR5SCzDJBx+cHPFOIzPWylS2rDk6yxsJhX0W1IJjvuvW+10Synu80I8ty70Xswe5gG01X6d4y5RTW1fGCQNE0CLhg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Tj7V5ntzOxLYIWWN4OmUXM39nqGEoes+gtwZXEqiLyw=; b=ST/indOGdoL2bfGdjw4rhyKX9XgbimC5JNYgf+EqGaozKFpBHaS6jmw5c2ykOBBe2KTvGD3MKq0jOYy8xR2jqeMGbtaVNwQtlR8R9aAJT5X7xLOysS3M3zjFRrkMe5vUyU7+hCR2D4ppWb13LCDwoCOAcowr8KOTV18NMKETfgo= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5111.namprd11.prod.outlook.com (2603:10b6:510:3c::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4500.16; Wed, 15 Sep 2021 16:57:42 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:57:42 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-5-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9a691247-35c9-611f-a870-c4040a1cedd2@intel.com> Date: Wed, 15 Sep 2021 17:57:36 +0100 In-Reply-To: <20210908083758.312055-5-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DBBPR09CA0013.eurprd09.prod.outlook.com (2603:10a6:10:c0::25) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DBBPR09CA0013.eurprd09.prod.outlook.com (2603:10a6:10:c0::25) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:57:41 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 189b28da-d4c9-4fcb-fef0-08d97869eec8 X-MS-TrafficTypeDiagnostic: PH0PR11MB5111: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:2150; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: IiQcd7kYFNqjcHv0COGZNZViVAarKvJAjXpnXluh2L8/qMOsAmcWc/ZY9X+1+Wdmf7BmLARbKahQj7FPMzy4fA7jWWOeplq9aY/iYP/KIF03duPs0uGE4y1J3FBUFxqJtAcbGVHKUVJE637Zt/kOgABn0203xFRc5Z6S/vVJk8shKYaUpdjQhD7awzQJs/Vkwj+X6Oy7fIryEGn2SGqW8Q19baITx0IYbtPbKGVGCeBc9FSG0PvC6Xh2J78dxclxA0GAWSX55ZAOnOxi0TteneGpMQvbODqCaOb6ap1LeDKP2tG6a9Zmxz22DRUZBMOrvWVLL9yMK13SNJNhYB2CWKxxqSUzoJGW5scMadzT4jPlCFZjlqhnmYsOyf5AkIrqxjmK94gVpOaSFCMThUSpBO5FAPa2gvl3DnFf95SqrvBds0ntO5EU+mxRNDY7z1nelSX0y7+ODZ/eenbHGvYqMAcmqRsuYnurKbg2QTkvFH+3w38x+Z0JNfKLu2uJ4jRyHJ7Qu0wr6M1lcEAskGBIt3g3aWN/+krXVqyeT2b9gKvYlt20GUEXp2kS+kRqvIFp8aLZ+VAKf48IF6ueCSA62acNlMuifNtf/KCgVoTYd6icuKrXcyYwta9R0hF+u3mQ5MDdthKTeJ/jR4fqzirMRTWvCRBaQJVeEsiZ8VOsGx/O6o7wzLQJjiU1UNegXPSHW7QdeK5gDkhSviIId1VdpA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(346002)(39860400002)(366004)(396003)(376002)(136003)(66556008)(66476007)(8676002)(2616005)(44832011)(956004)(186003)(53546011)(66946007)(31696002)(26005)(38100700002)(86362001)(31686004)(5660300002)(2906002)(36756003)(6666004)(16576012)(316002)(6486002)(8936002)(478600001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?cXBseklkTUgwVmlNNWplM25lNGNSbjA0WkJLMUs1VlNUeGZVVThrbVJZUkNv?= =?utf-8?B?THAySEU2QnlMSjcxQ25Dd1c1dFVTVTlvaDJXZ29RTDhHODJJWTZGdVgwYU5Y?= =?utf-8?B?aHdPWEMrNm4xazZoRmxBUlBKaEdaME9QcDgrQ2ZKcEhuNDR2bzhFS1VNTCt3?= =?utf-8?B?UGxiK1QwT051ZkFuNDIrQmttQ3JVWGcrR1hab3Z6R0d3WXZ0aUhpU0tSZHRo?= =?utf-8?B?cE9CSjJ0MWtDVHcvR2MyZEcrcGlVN1BFbUhHcFBjUzQyMXlBN3pNdDVjdGlm?= =?utf-8?B?TlJKUTdKbmRBcFQvU1VYL21VRU9wWjc5Y0wrMW9nQzBhM2sxN1lwTnpMK1dw?= =?utf-8?B?M1piQWZHck15K0wwVG5GYjFmcjNlVTJpd1ZGL1FXM0tGUW83N2grdk15M04x?= =?utf-8?B?L0tUVmF6ZGs1azZDQktVVkdRbmQ5ZllZWDd3R3JsL1FCaytwNkZrUUN0Ulg2?= =?utf-8?B?N0V3bTZLei9yQksyS0k3QjNTc0laMi9xRVR3QzB6aFpaMzNmNjJuVjIvNjFn?= =?utf-8?B?MHZxSDJlTkFsdzlNdXBPQXNKbXFyaTd2TGM3VEU0Q0NOZld5eTBXU29QUW1m?= =?utf-8?B?Y3hzYUFkTndDMVQ2M3gzYW83WnZSZEhJMllDMitGVnZPeS9Zeldnd1FicWFP?= =?utf-8?B?cmU5Q1VvU0hZb2cxNzJWdXJFdnExZHM1TFFXSXRmUGNWeW4vWTR1UTM0Y2Nq?= =?utf-8?B?UGphbDI0Ny9LWlA3YlNtUHcvRUxZQ1J0QWdTa3JoNU5nMG9lYTZWMFJwQmFO?= =?utf-8?B?UkFGM2haWktyQkdSOVdiV1ZnOFlLcVgraUtIL2kycitXQ1g3RmtLUGQ2d055?= =?utf-8?B?OGEyWlZ4UUJiQXJkSWM3UU82TVdYV1gzcmFydnNBSENCaFdsVnAxK3NlbXhZ?= =?utf-8?B?RmxWelZFQ3pXYllVMWV5elRUdWdVVEtieGRibjZKMWhSV00rL2ZCc2htTkVU?= =?utf-8?B?TFFuMkNJTVBjNDlxaXlvL2ZyT0xoUTVjQTZySGc0VHBDK0pwdW9KeGNERjJu?= =?utf-8?B?cDdLUFJ0Uy9WaEdBNWliV2RXR2x3ZVpqSjZjR3BDVnZLbkpYUlFLVmJSMGJ6?= =?utf-8?B?ODZwNFhuWkRscm56cjFsY2wwbm83Y1U0dms4V0tqV1k3S3lINkNYWmxrS0tp?= =?utf-8?B?dUZQOTRHRHNSY0R2MGdwa3d1R3FNaVpTWTFudTZlbW5pdHpGZ3YvNzcrMDZR?= =?utf-8?B?OHV4VWFmc1JjQmlva2h3K1lZK28rdjhLS3ZmSmdtOEl4K3ZpT0tReUxyY0V4?= =?utf-8?B?NW93aWlUMDE1RXMzQTdEdkQxeHRGNUIyY0lIcU9MV2tnZVBuQlZKR2FRODlx?= =?utf-8?B?VUtwMWRDeDh2aENmNUZhK0c0NldXVXRSUThXREYxWmlINDdKbWpqZVpsaU50?= =?utf-8?B?eUVoeEpNV040Vm1FODNNdFprZGxDZ01RSzcwWitVaGZtS2dFakxqeUJyRWda?= =?utf-8?B?Tk1qRkhmV0hYODY5bUd5TzJiMXRpS2lCK1huRGRpTmlpcWhCYU1qS3lSTWcy?= =?utf-8?B?UFVTcHE0eG93QjU4cnVDOEZIUnR3N1ViaDNzbnlDSEdBMkNzclNsdTBZaGk2?= =?utf-8?B?djdQcllHUlU0SlI1UUpuZ3VOV2NiNE5KZ1kvdjVBZ3B2S0l5dzFsSlZyRXF5?= =?utf-8?B?aXJsMUtRWXUxVnUrTjZsUHcwM3JHVHVNSVRweHlpdS9VWUZ6cXp2QkJRcUsy?= =?utf-8?B?VGl4Ny9JNzd2Rk85RE1GT1NqTTRnczR5R21NNTh3ajlMVWt2Z1lDSGJ0UVVD?= =?utf-8?Q?jclFNw5nwHPkls2T+RSeBa0S++/RFOm/lxT3az+?= X-MS-Exchange-CrossTenant-Network-Message-Id: 189b28da-d4c9-4fcb-fef0-08d97869eec8 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:57:42.4238 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: +IBJueRIaDL4f8A8MQ1pth0re33q9v6Mhc4ORrs/97IXcpl9yQiEm4bNo87kP8ENIlM73hwXy1Q5Q1wPVkZr7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5111 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 04/32] net/ngbe: support TSO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Add transmit datapath with offloads, and support TCP segmentation > offload. > > Signed-off-by: Jiawen Wu <...> > +/* Takes an ethdev and a queue and sets up the tx function to be used based on > + * the queue parameters. Used in tx_queue_setup by primary process and then > + * in dev_init by secondary process when attaching to an existing ethdev. > + */ > +void > +ngbe_set_tx_function(struct rte_eth_dev *dev, struct ngbe_tx_queue *txq) > +{ > + /* Use a simple Tx queue (no offloads, no multi segs) if possible */ > + if (txq->offloads == 0 && > + txq->tx_free_thresh >= RTE_PMD_NGBE_TX_MAX_BURST) { > + PMD_INIT_LOG(DEBUG, "Using simple tx code path"); > + dev->tx_pkt_burst = ngbe_xmit_pkts_simple; > + dev->tx_pkt_prepare = NULL; > + } else { > + PMD_INIT_LOG(DEBUG, "Using full-featured tx code path"); > + PMD_INIT_LOG(DEBUG, > + " - offloads = 0x%" PRIx64, > + txq->offloads); > + PMD_INIT_LOG(DEBUG, > + " - tx_free_thresh = %lu [RTE_PMD_NGBE_TX_MAX_BURST=%lu]", > + (unsigned long)txq->tx_free_thresh, > + (unsigned long)RTE_PMD_NGBE_TX_MAX_BURST); > + dev->tx_pkt_burst = ngbe_xmit_pkts; > + dev->tx_pkt_prepare = ngbe_prep_pkts; > + } > +} Since driver has multiple Rx/Tx functions now, you may want to implement new APIs to get info about current burst function (in a separate patch): 'rte_eth_rx_burst_mode_get()' 'rte_eth_tx_burst_mode_get()'