From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (xvm-189-124.dc0.ghst.net [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id BECCEA0524; Thu, 7 Jan 2021 11:09:53 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 47088140F1B; Thu, 7 Jan 2021 11:09:53 +0100 (CET) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id CAF65140F0D for ; Thu, 7 Jan 2021 11:09:51 +0100 (CET) Received: from [192.168.1.71] (unknown [188.170.80.211]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id D220B7F4F3; Thu, 7 Jan 2021 13:09:50 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru D220B7F4F3 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1610014191; bh=3ywIoJdL/K/MmfnXml47Rtk4F1EgGhRnvG0vibTgoZI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=cj350WzEzUlcy4sxPsmNfeHKWH/w2dH7lBvxawRVJ9rcGzSPLIHY1LIhVtKYjqMOf SsotqLqfwTekPOm1e0n9yVRCd+W5XHqxpoLbMzu8Eo/8qPwBcXQrq1/zOuFpPVJ1o8 ifold7vU8a+B1wU6vyuZs8LhHQeyQeVnjNt9/IWA= To: "Guo, Jia" , Thomas Monjalon Cc: "Zhang, Qi Z" , "Wu, Jingjing" , "Yang, Qiming" , "Wang, Haiyue" , "dev@dpdk.org" , "Yigit, Ferruh" References: <20201216085854.7842-1-jia.guo@intel.com> <20201224065940.76857-1-jia.guo@intel.com> <20201224065940.76857-2-jia.guo@intel.com> <8091331.oFBQTsvStG@thomas> From: Andrew Rybchenko Message-ID: <9a94cfd4-a529-8271-8c2d-2ac10d9a2236@oktetlabs.ru> Date: Thu, 7 Jan 2021 13:09:48 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.5.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for ecpri X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 1/7/21 12:32 PM, Guo, Jia wrote: > >> -----Original Message----- >> From: Thomas Monjalon >> Sent: Thursday, January 7, 2021 6:12 AM >> To: Guo, Jia >> Cc: Zhang, Qi Z ; Wu, Jingjing >> ; Yang, Qiming ; Wang, >> Haiyue ; dev@dpdk.org; Yigit, Ferruh >> ; andrew.rybchenko@oktetlabs.ru >> Subject: Re: [dpdk-dev] [dpdk-dev v2 1/2] ethdev: add new tunnel type for >> ecpri >> >> 24/12/2020 07:59, Jeff Guo: >>> Add type of RTE_TUNNEL_TYPE_ECPRI into the enum of ethdev tunnel >> type. >>> >>> Signed-off-by: Jeff Guo >>> Reviewed-by: Qi Zhang >> [...] >>> --- a/lib/librte_ethdev/rte_ethdev.h >>> +++ b/lib/librte_ethdev/rte_ethdev.h >>> @@ -1219,6 +1219,7 @@ enum rte_eth_tunnel_type { >>> RTE_TUNNEL_TYPE_IP_IN_GRE, >>> RTE_L2_TUNNEL_TYPE_E_TAG, >>> RTE_TUNNEL_TYPE_VXLAN_GPE, >>> + RTE_TUNNEL_TYPE_ECPRI, >>> RTE_TUNNEL_TYPE_MAX, >>> }; >> >> We tried to remove all these legacy API in DPDK 20.11. >> Andrew decided to not remove this one because it is not yet completely >> replaced by rte_flow in all drivers. >> However, I am against continuing to update this API. >> The opposite work should be done: migrate to rte_flow. >> > > Agree but seems that the legacy api and driver legacy implementation still keep in this release, and there is no a general way to replace the legacy by rte_flow right now. Which legacy API is kept? (I've tried to cleanup drivers, but it is not always easy to do and I relied on driver maintainers) If you are talking about an API to set UDP port for UDP-based tunnels, yes it is kept right now since there is no replacement yet. It looks like eCRPI could be encapsulated in UDP, but I don't know if UDP port is fixed for the tunnel type or requires configuring.