From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 75C8DA034C; Thu, 24 Feb 2022 14:13:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 3FFA141155; Thu, 24 Feb 2022 14:13:40 +0100 (CET) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by mails.dpdk.org (Postfix) with ESMTP id B46DC4114D for ; Thu, 24 Feb 2022 14:13:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1645708418; x=1677244418; h=message-id:date:subject:from:to:cc:references: in-reply-to:content-transfer-encoding:mime-version; bh=7ykcxWPOCJTpghFAGx9xWgUM2PaLEyZs/3+LumQgQuA=; b=WBqYMAEVNmcR1BB+WmnPEwroNIqvagMFFpxG+K0wfPwKyklseKonKk05 XEQthAPaiUNErSqES1+mO85Qz+7tZWuiS4Qi4NyS/n/yrtgvGIvjMnprM tXwmboc+jKgoOLOOUZA19uImkwh97hGV82+G1trMmaFcMXpVKvwCA/D04 vF+Isz8G9U/Ort1rjtX4bl13ea6rd5MeP5UXJFhZ0fsn8YExUaSoZ9cVI sj0oE8NKtpcomKFHYomZOXrQHrJhyyqDJY1LAtkRHGBKeytvIzdFK9UCq kMhhtzdfVK2dQgfaSPJ7Axu9My4A5GZ4xuNgi5M3N8cXx2Y+UzacXJIei g==; X-IronPort-AV: E=McAfee;i="6200,9189,10267"; a="239626283" X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="239626283" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 24 Feb 2022 05:13:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.90,134,1643702400"; d="scan'208";a="533131158" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga007.jf.intel.com with ESMTP; 24 Feb 2022 05:13:37 -0800 Received: from fmsmsx604.amr.corp.intel.com (10.18.126.84) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21; Thu, 24 Feb 2022 05:13:37 -0800 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx604.amr.corp.intel.com (10.18.126.84) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.21 via Frontend Transport; Thu, 24 Feb 2022 05:13:37 -0800 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.174) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Thu, 24 Feb 2022 05:13:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=mto6Nrmw6Rwbtf96nGxLItNJlG7WaXOi0y5fCo77KoUoiW2S62pLw0a7r4XkbFrr0OX5gCLANf7VH0JAIBj4fW/OhbT3GjYSsjeOcW3ByfTftBwjdH28QYeeyqEANuV2gXtfSfWmtY5KkE407zIExg9Ca74yTnSI5D4M1GXnA1Gqdz5LlHbdpLf5rZmuVor7Nn2P/xXXOxVHF+DFPI8ybubOaTbHyJweERoBoxl3Q5vgxvD+3Uaaa0Nr1gVF1as6hx6YW6c+Tj8ec/wIltWyZMCO2fb5WqcOMSf+vnVVOWssPqabwRx0TeUcTCDZgQELwg/DgtvIM6uAyH2TPGlQoQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=EcRkWu8mgzOM81TiUNNybjkNQR5z3z+bKMl+qwIh+oA=; b=dzIOyaV0TRdizmYtzbpWPZx6LnbVBMCuB95pUKH4pyMZgZbvW7Au6JkDWPeAZVXEUt0L2yYd5bCOhGDjPqG0btPf8bcB0Tqh667SF3+/jxo0ioIBnCWMrFCCtJQQRpGGH8V4kr0I0MCBmInb8PnxbMRwU/W47lEjN13Mgj09CPqNEEz8XAjsl81caUX1/aTGpl0G55OQpMVwhGVqomouQzqber9bkCb0733KD4XBsDPuX/jCGzNv0c9H4335acexpOv6y6PLBMleWv97mkJto4EbfWaPkG9UT17W8rWXNUs69KzmnEU8tZ2SG6DWq8ZQZtx4E97Ty0S5PGvXi9XXJA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) by MWHPR1101MB2207.namprd11.prod.outlook.com (2603:10b6:301:58::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4995.16; Thu, 24 Feb 2022 13:13:29 +0000 Received: from SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::950b:2599:c5ab:cfea]) by SJ0PR11MB5005.namprd11.prod.outlook.com ([fe80::950b:2599:c5ab:cfea%4]) with mapi id 15.20.4995.027; Thu, 24 Feb 2022 13:13:29 +0000 Message-ID: <9a95ec1a-e21d-77c9-e6e3-0a8163998b9b@intel.com> Date: Thu, 24 Feb 2022 13:13:22 +0000 Subject: Re: [PATCH v10 00/11] ethdev: datapath-focused flow rules management Content-Language: en-US From: Ferruh Yigit To: Alexander Kozyrev , , Raslan Darawsheh CC: , , , , , , , , References: <20220221230240.2409665-1-akozyrev@nvidia.com> <20220223030240.2506513-1-akozyrev@nvidia.com> <855041b1-a6f6-6a48-8785-70e1c758b175@intel.com> X-User: ferruhy In-Reply-To: <855041b1-a6f6-6a48-8785-70e1c758b175@intel.com> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0352.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:18d::15) To SJ0PR11MB5005.namprd11.prod.outlook.com (2603:10b6:a03:2d3::21) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 388daeee-e446-4115-3ae2-08d9f79772fd X-MS-TrafficTypeDiagnostic: MWHPR1101MB2207:EE_ X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: UVdGmPEQzESsZvYf1jZIUR2UufWxMlovdAyRnf9PbCz4SWNsA6vll83PypRQJa8sH1RaxBE4DnjelBCHVo8VfSYMs213L46m9iyjiZAwUw/w6iU6M0BIMuzF4Tmt8bXJdt1qnGLR4GB1MrjUf/aH/DizYG9xXIpMshNXg5B8WZTf/HB+pic0JkCEcJf0JUiynXAvkhJ27e2Ln39WqWBGveY2RNYfA4hM7BR2k4mRAmDCHtVJxl1JgJyduKzS2TK/HANrdR5eaPCSMIagRcrcDcslzn8xmCAme0xSxq7Y6+JnPRAED8A8Fqiu7PgRUGp7Tt8TxWXB8o0jJEbiZ1GzWEK9oWyWKSFPyttilyAlj592Lr8kP/fzukHCE33OrhlDxUPdp7NbtBElPjtUoKgkMWlDNL5Hgc/gXibZqGjgWhHjU4Ga7CeOK1Z2V0XD9wrxyi6Do+Q08umvfWQdFa2sxnqsgkHCfJtzlXhiE6hQG0jn1gEJIhx5znr4WxV2yayNen5ND419rEIZ9jJF9nZisdpeqM5FAmZaxsd3u8g76URNGGLhXGsFzeiJQPV2t8Te7QzNS6Cop55QO7XQLcgl26MMEmKrt6k0kPMOYF8deCP3Us/aKc/W82Ggnl/oncIK4ncl+cqCSGoAgsNFmQVIUHiVdY2tAaHETLmIHqktXDO5GadgoIf31mzCqexn5jEjkXKTdSGSi8LErcRS3ljQ/rbjVQmrc8PDL4dso+Qku8eDs12sZHPdAZ8hEvVXi0IGFS0L1zjFZR0/awMtivQuVHMDauUKhBp4A6lvrbuW9JU= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ0PR11MB5005.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(31686004)(110136005)(31696002)(36756003)(66556008)(26005)(38100700002)(82960400001)(83380400001)(2906002)(186003)(8936002)(6666004)(107886003)(86362001)(508600001)(4326008)(316002)(66946007)(6486002)(2616005)(44832011)(5660300002)(53546011)(6506007)(6512007)(8676002)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?OFRWZVBieGdQVEpPbSt1MXhhdTc2U2tmdGgzUEFOcGdjMS9HaGVFRWdFWjBa?= =?utf-8?B?alFrajlCbzBsOFZDeEpFWC85bkVqUi9jWnNvMS9NbzZOMksyQTJ2OTRzR3Vz?= =?utf-8?B?VTMvM2YxSFdFMmhyOW5ES3U4VmsyVkVZT2k5Q3RtOVkrNHFGeEp4dytrOXVw?= =?utf-8?B?dm9ka0hJbENVcnNXeFRxaTUyczJtQkVpUjFJS1IvVWdJU1NLcTBWVlQybGxI?= =?utf-8?B?NEJ3WG1nUnZ5Mk5XTEtHZEQzYk9kY2FlbXYvMmRsWWV3QnJqZ3YvTHcwUGxH?= =?utf-8?B?dXFuc24zMEJoMWlsTCtiVVRERE9hOE5mNmlZN3dwYlVKSHVCK3hpc09MOFlY?= =?utf-8?B?S244RFp5a0hzV29jKzFmaWY5aWNrVWcvZWxPQy8rRkFKVHdZbUJjWUk2ZHY4?= =?utf-8?B?VEFwUmZ3S0VzRUw5U1g5b1h1RHhVaDkxMU9pU0pvd3ltYmNHVjcxeVMwK2Zw?= =?utf-8?B?cUc2czJpMDRxYTVvcHhpRktoVjhuY0tpQzh0bHlrcGtJZUl3SnJsemVXNS9x?= =?utf-8?B?cDFLdGNuZGtPL2lIcHBVclJoS1lTL1ViYUJLNDZqbjRRUW13MFl2djVNNUJF?= =?utf-8?B?MndWdzRXUFBFNTNtZWhRY0ZpVy90RkNGL3NmNHZUSFYyVmIwaG9TU1lwaFRJ?= =?utf-8?B?TEtBd2REQXZWUGM2UW0xa29hbDJYREJKajVueW5nck9EOWs3WDFON3ZDbjNm?= =?utf-8?B?QUhxN3krWk5CWVhtU08zQlVBUm1pdS9XNDR6aUV1d2pNQVhSMVlCeXFjaTZz?= =?utf-8?B?aVZuUHpHaUxJRTRCaVhCODJMeDJIelNVVWtURW1RTEVXTmZuODRzVExqSVhj?= =?utf-8?B?dzJOTXJpcnVaWHZOVDZCdm9WNzJOVHNqS2hqY1oxR3loQng2eVBiUGJrUFpx?= =?utf-8?B?MjNNUk1ac0tKc0FuUnZsa1AyZGNvSkN4LzhNaW80eWRkVW5nNWxlK3RGOUV4?= =?utf-8?B?K1cvRDJGRnVpRjhYOWl3cGhSOFhIaHczOElFMVVjNjJIYVZHL2xzUHp2V1l1?= =?utf-8?B?VHpzRWU4MEZaajJsNkZKV0I1MWZrSm5xNzFob2ZMZjJvYW1RVDFpMlQ0R0sz?= =?utf-8?B?UkdEWlFZK003VlBvY3R6Z2tMbEhQSHVmTDJodDhvUitlR2p2M3F0MFhXMm9M?= =?utf-8?B?OFFZUkgxbVlXRzNOOWNLUExEd3RCUVVYY0NZOFRXMVZScmUrbHVDOFVqWXhn?= =?utf-8?B?dHNzSVN5eFYzSzR2VlNoME5GWVRZMXE5Wk04T2N2eDFjaytmSDhHMEtPdzRy?= =?utf-8?B?UFYwT1lUZHE0UXFWYzNYQlFGODgxZ0tVbExCWVZMaVh1bHB5dlJxQ3hVWG1R?= =?utf-8?B?UUNMUVdpdDZ2WFdpZUwrMjNyczExeDRvWndqN09vajh1dC9QQWswRXhuSTgw?= =?utf-8?B?cVhLWC91MlJxOHNNb1FSaHNlb3h3SGxnWFpwT1YzQXJHMkxpeVBDYjJvajdp?= =?utf-8?B?aXlZV2x6dGpzSEVUTWtrdldXQkNaRWFMTEJZR3oyUTkwMDBXak91emZzUUFp?= =?utf-8?B?VWwzTmJEcFNlVzRmNjVWSHNLc0g4SCs2bGhyVURMNWNkOWk1MFkxaDVuTExK?= =?utf-8?B?OFpCS2hoNkZVZ0R5aUhodWVFb0t2YXpJSzNCa05zTENLdkFwcGJPQk5IY0VG?= =?utf-8?B?ZDVZc0h6cXp3cVBHaGs0NzZOTEQzU25aMTQ3aVpwTkJpc3B6K2RPTDhvaTBX?= =?utf-8?B?WE90N3lkQ0tmQkUvTW1ySnpZRzl1VHVhQXVGYUlTVmZwY0ZjeHpPUVQvV2k4?= =?utf-8?B?aEhneHpQdkxiZXNPQ1UyZnVQZnBjbCtPeENCNTdPMlNRWDF4ZWw4VEpBUUVQ?= =?utf-8?B?bVNHQXl4SW1rZU43RFpZaUFka0g3UDhaRHJqY1dOVit4aVd5ZnIrQlNnRk5L?= =?utf-8?B?aHFPMmxiNEl4NlQwNGhxdTBsODBZQnBkRTFMSUZ2dm9jSFBxQjFrSGZBUnlu?= =?utf-8?B?L2FoVzQ1Ymdsei9BSzRURzNWYXY3SDVmTU9VdUtZRElnbnlNbjBzbUE2T0Ux?= =?utf-8?B?V292OTJDT2ZIb3ZEcStVUXVVOEpTd2l2bmo5WTJ4U2xsclNKQVRsYUhTaDRt?= =?utf-8?B?ak5oMXZ4WlRGb2luMVVzTnp5N1poK2xWR29uV1dEelJJVFpnM3hYa094VmpY?= =?utf-8?B?OVlEOENPbFNSelJ4clZXaGtwckRLS2dyQ25IbUhjRnMxNHJ4UFRJRk00N01o?= =?utf-8?Q?k8b/NC/0JbIL6V7MOttMupo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 388daeee-e446-4115-3ae2-08d9f79772fd X-MS-Exchange-CrossTenant-AuthSource: SJ0PR11MB5005.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Feb 2022 13:13:29.3143 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: GRIsmAZGUCsa+lb/kGSMht2Y2osBbb3dagiqoVLoUop6hW8QRq5PsgULLHhWYLlFpk9LuN2q62EIGFb8iRk7LQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR1101MB2207 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/24/2022 1:07 PM, Ferruh Yigit wrote: > On 2/23/2022 3:02 AM, Alexander Kozyrev wrote: >> Three major changes to a generic RTE Flow API were implemented in order >> to speed up flow rule insertion/destruction and adapt the API to the >> needs of a datapath-focused flow rules management applications: >> >> 1. Pre-configuration hints. >> Application may give us some hints on what type of resources are needed. >> Introduce the configuration routine to prepare all the needed resources >> inside a PMD/HW before any flow rules are created at the init stage. >> >> 2. Flow grouping using templates. >> Use the knowledge about which flow rules are to be used in an application >> and prepare item and action templates for them in advance. Group flow rules >> with common patterns and actions together for better resource management. >> >> 3. Queue-based flow management. >> Perform flow rule insertion/destruction asynchronously to spare the datapath >> from blocking on RTE Flow API and allow it to continue with packet processing. >> Enqueue flow rules operations and poll for the results later. >> >> testpmd examples are part of the patch series. PMD changes will follow. >> >> RFC:https://patchwork.dpdk.org/project/dpdk/cover/20211006044835.3936226-1-akozyrev@nvidia.com/ >> >> Signed-off-by: Alexander Kozyrev >> Acked-by: Ori Kam >> Acked-by: Ajit Khaparde >> >> --- >> v10: removed missed check in async API >> >> v9: >> - changed sanity checks order >> - added reconfiguration explanation >> - added remarks on mandatory direction >> - renamed operation attributes >> - removed all checks in async API >> - removed all errno descriptions >> >> v8: fixed documentation indentation >> >> v7: >> - added sanity checks and device state validation >> - added flow engine state validation >> - added ingress/egress/transfer attibutes to templates >> - moved user_data to a parameter list >> - renamed asynchronous functions from "_q_" to"_async_" >> - created a separate commit for indirect actions >> >> v6: addressed more review comments >> - fixed typos >> - rewrote code snippets >> - add a way to get queue size >> - renamed port/queue attibutes parameters >> >> v5: changed titles for testpmd commits >> >> v4: >> - removed structures versioning >> - introduced new rte_flow_port_info structure for rte_flow_info_get API >> - renamed rte_flow_table_create to rte_flow_template_table_create >> >> v3: addressed review comments and updated documentation >> - added API to get info about pre-configurable resources >> - renamed rte_flow_item_template to rte_flow_pattern_template >> - renamed drain operation attribute to postpone >> - renamed rte_flow_q_drain to rte_flow_q_push >> - renamed rte_flow_q_dequeue to rte_flow_q_pull >> >> v2: fixed patch series thread >> >> Alexander Kozyrev (11): >>    ethdev: introduce flow engine configuration >>    ethdev: add flow item/action templates >>    ethdev: bring in async queue-based flow rules operations >>    ethdev: bring in async indirect actions operations >>    app/testpmd: add flow engine configuration >>    app/testpmd: add flow template management >>    app/testpmd: add flow table management >>    app/testpmd: add async flow create/destroy operations >>    app/testpmd: add flow queue push operation >>    app/testpmd: add flow queue pull operation >>    app/testpmd: add async indirect actions operations > > Series applied to dpdk-next-net/main, thanks. +Raslan, As ethdev patches merged, can proceed with driver ones.