DPDK patches and discussions
 help / color / mirror / Atom feed
From: Kevin Traynor <ktraynor@redhat.com>
To: "Zhang, Qi Z" <qi.z.zhang@intel.com>,
	"Su, Simei" <simei.su@intel.com>,
	"Xing, Beilei" <beilei.xing@intel.com>,
	"Zhang, Yuying" <yuying.zhang@intel.com>,
	"david.marchand@redhat.com" <david.marchand@redhat.com>,
	"Jiang, YuX" <yux.jiang@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Yang, Qiming" <qiming.yang@intel.com>,
	"stable@dpdk.org" <stable@dpdk.org>,
	Luca Boccassi <bluca@debian.org>,
	"Mcnamara, John" <john.mcnamara@intel.com>
Subject: Re: [PATCH v6] net/i40e: rework maximum frame size configuration
Date: Thu, 23 Mar 2023 14:50:35 +0000	[thread overview]
Message-ID: <9aa3b88a-5e2f-d857-b554-d88a572b46b2@redhat.com> (raw)
In-Reply-To: <8fecda8e-15b4-63e0-f319-6e4a4a5edf83@redhat.com>

On 22/03/2023 16:50, Kevin Traynor wrote:
> On 27/02/2023 00:35, Zhang, Qi Z wrote:
>>
> 
> Hi Simei/Qi/Yu
> 

Hi Yu,

>>
>>> -----Original Message-----
>>> From: Su, Simei <simei.su@intel.com>
>>> Sent: Monday, February 20, 2023 4:00 PM
>>> To: Xing, Beilei <beilei.xing@intel.com>; Zhang, Yuying
>>> <yuying.zhang@intel.com>; Zhang, Qi Z <qi.z.zhang@intel.com>;
>>> david.marchand@redhat.com
>>> Cc: dev@dpdk.org; Yang, Qiming <qiming.yang@intel.com>; Su, Simei
>>> <simei.su@intel.com>; stable@dpdk.org
>>> Subject: [PATCH v6] net/i40e: rework maximum frame size configuration
>>>
>>> One issue is reported by David Marchand that error occurs in OVS due to the
>>> fix patch in mentioned changes below. The detailed reproduce step and
>>> result are in https://patchwork.dpdk.org/project/dpdk/patch/
>>> 20211207085946.121032-1-dapengx.yu@intel.com/.
>>>
>>> This patch removes unnecessary link status check and directly sets mac config
>>> in dev_start. Also, it sets the parameter "wait to complete" true to wait for
>>> more time to make sure adminq command execute completed.
>>>
> 
>>> Fixes: a4ba77367923 ("net/i40e: enable maximum frame size at port level")
>>> Fixes: 2184f7cdeeaa ("net/i40e: fix max frame size config at port level")
>>> Fixes: 719469f13b11 ("net/i40e: fix jumbo frame Rx with X722")
>>> Cc: stable@dpdk.org
> 
> These patches caused an observable regression in multiple 20.11 and
> 21.11 LTS releases that was only caught a long time after releases.
> 
> Is there anything being added to LTS validation for regression testing
> this issue, so we don't get caught again?
> 

This is the issue I was talking about earlier during the release 
meeting. Not sure if we were talking about the same patch.

I was asking if there are some regression tests added/can be added to 
LTS validation that will be run during each LTS validation cycle so we 
don't have any more regressions on it.

thanks,
Kevin.

> After reverting the original patch and 2 fixes, I'm a bit reluctant to
> take more fixes without some form of regression testing in place.
> 
> thanks,
> Kevin.
> 
>>>
>>> Reported-by: David Marchand <david.marchand@redhat.com>
>>> Signed-off-by: Simei Su <simei.su@intel.com>
>>
>> Acked-by: Qi Zhang <qi.z.zhang@intel.com>
>>
>> Applied to dpdk-next-net-intel.
>>
>> Thanks
>> Qi
>>
> 


  reply	other threads:[~2023-03-23 14:50 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-16 10:53 [PATCH] " Simei Su
2023-01-16 11:18 ` David Marchand
2023-01-16 12:15   ` Su, Simei
2023-01-20  7:33     ` David Marchand
2023-01-20 13:57       ` Su, Simei
2023-01-20 14:46         ` David Marchand
2023-01-20 15:37           ` Su, Simei
2023-01-31  6:52 ` [PATCH v2] " Simei Su
2023-01-31  7:44   ` 答复: [[SPF Failed]][PATCH " 韩爽
2023-01-31 10:31   ` [PATCH v3] " Simei Su
2023-02-02  5:54     ` Yang, Qiming
2023-02-02 12:30     ` [PATCH v4] " Simei Su
2023-02-02 12:36       ` [PATCH v5] " Simei Su
2023-02-02 12:55         ` David Marchand
2023-02-03  3:50           ` Su, Simei
2023-02-02 13:24         ` David Marchand
2023-02-02 13:48           ` David Marchand
2023-02-03  8:38             ` Yang, Qiming
2023-02-03  8:47               ` David Marchand
2023-02-03  4:00           ` Su, Simei
2023-02-20  7:59         ` [PATCH v6] " Simei Su
2023-02-27  0:35           ` Zhang, Qi Z
2023-02-28  9:36             ` David Marchand
2023-03-02  9:51               ` Zhang, Qi Z
2023-03-22 16:50             ` Kevin Traynor
2023-03-23 14:50               ` Kevin Traynor [this message]
2023-03-24  6:32                 ` Jiang, YuX
2023-03-24  9:40                   ` Kevin Traynor
2023-03-24 10:20                     ` Jiang, YuX
2023-03-24 13:07                     ` Su, Simei
2023-03-06 12:18           ` [PATCH v7] net/i40e: fix max " Simei Su
2023-03-07  2:27             ` Zhang, Qi Z
2023-02-02 13:14       ` [PATCH v4] net/i40e: rework maximum " Kevin Traynor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9aa3b88a-5e2f-d857-b554-d88a572b46b2@redhat.com \
    --to=ktraynor@redhat.com \
    --cc=beilei.xing@intel.com \
    --cc=bluca@debian.org \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    --cc=john.mcnamara@intel.com \
    --cc=qi.z.zhang@intel.com \
    --cc=qiming.yang@intel.com \
    --cc=simei.su@intel.com \
    --cc=stable@dpdk.org \
    --cc=yux.jiang@intel.com \
    --cc=yuying.zhang@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).