From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Felix Moessbauer <felix.moessbauer@siemens.com>, dev@dpdk.org
Cc: henning.schild@siemens.com, jan.kiszka@siemens.com,
thomas@monjalon.net,
Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [PATCH v6 1/2] Fix build of apps with external dependencies
Date: Tue, 20 Sep 2022 14:33:03 +0200 [thread overview]
Message-ID: <9aab0a80-0fec-342a-921b-5e79c74eaa4f@redhat.com> (raw)
In-Reply-To: <20220902084533.675698-2-felix.moessbauer@siemens.com>
On 9/2/22 10:45, Felix Moessbauer wrote:
> This fix initializes the dependency object with the external
> dependency list. Previously, the external dependencies were
> just ignored.
>
> Signed-off-by: Felix Moessbauer <felix.moessbauer@siemens.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> app/meson.build | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/app/meson.build b/app/meson.build
> index 93d8c15032..0ea04cadeb 100644
> --- a/app/meson.build
> +++ b/app/meson.build
> @@ -44,7 +44,7 @@ foreach app:apps
> subdir(name)
>
> if build
> - dep_objs = []
> + dep_objs = ext_deps
> foreach d:deps
> var_name = get_option('default_library') + '_rte_' + d
> if not is_variable(var_name)
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2022-09-20 12:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-02 8:45 [PATCH v6 0/2] Add l2reflect measurement application Felix Moessbauer
2022-09-02 8:45 ` [PATCH v6 1/2] Fix build of apps with external dependencies Felix Moessbauer
2022-09-20 12:33 ` Maxime Coquelin [this message]
2022-09-02 8:45 ` [PATCH v6 2/2] Add l2reflect measurement application Felix Moessbauer
2022-09-20 14:01 ` Maxime Coquelin
2022-09-25 8:01 ` Moessbauer, Felix
2022-10-20 12:45 ` Maxime Coquelin
2022-09-21 14:42 ` Jerin Jacob
2022-09-21 15:07 ` Thomas Monjalon
2022-09-21 15:13 ` Henning Schild
2022-09-22 5:55 ` Jerin Jacob
2022-09-21 9:43 ` [PATCH v6 0/2] " Morten Brørup
2022-09-21 11:27 ` Henning Schild
2022-09-21 12:22 ` Morten Brørup
2022-09-21 12:59 ` Henning Schild
2022-09-21 13:48 ` Morten Brørup
2023-09-12 14:30 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9aab0a80-0fec-342a-921b-5e79c74eaa4f@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=felix.moessbauer@siemens.com \
--cc=henning.schild@siemens.com \
--cc=jan.kiszka@siemens.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).