From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2CB42A00C3; Tue, 20 Sep 2022 14:33:13 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C34CF40DFB; Tue, 20 Sep 2022 14:33:12 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mails.dpdk.org (Postfix) with ESMTP id 5C41C4069B for ; Tue, 20 Sep 2022 14:33:10 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1663677190; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=QLskxUNfFFEXTLQFLB660L0vw1oN0qSc+OLQtTSNVFk=; b=MvT1kAs1rbaqXKesAFjdTiUGwiExH5qrkt1MfQysXRidi5+eGHbDutnClAZXKttEgkuOBU 5z02WKd4UHxAiRvzCRjxZcb32DrWk92OdPLy2fo7pK4DGIUFIGYWStjsWy+B6Qjv27fVJ5 3UNe8iXTzuDHaZvm8x1jNxlR8oHKAKY= Received: from mimecast-mx02.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-226-y4hea2INMs-8C33kmIdkPQ-1; Tue, 20 Sep 2022 08:33:07 -0400 X-MC-Unique: y4hea2INMs-8C33kmIdkPQ-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 9C7E53C01E06; Tue, 20 Sep 2022 12:33:06 +0000 (UTC) Received: from [10.39.208.16] (unknown [10.39.208.16]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4ACFD2166B4A; Tue, 20 Sep 2022 12:33:05 +0000 (UTC) Message-ID: <9aab0a80-0fec-342a-921b-5e79c74eaa4f@redhat.com> Date: Tue, 20 Sep 2022 14:33:03 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.0 Subject: Re: [PATCH v6 1/2] Fix build of apps with external dependencies To: Felix Moessbauer , dev@dpdk.org Cc: henning.schild@siemens.com, jan.kiszka@siemens.com, thomas@monjalon.net, Bruce Richardson References: <20220902084533.675698-1-felix.moessbauer@siemens.com> <20220902084533.675698-2-felix.moessbauer@siemens.com> From: Maxime Coquelin In-Reply-To: <20220902084533.675698-2-felix.moessbauer@siemens.com> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.6 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 9/2/22 10:45, Felix Moessbauer wrote: > This fix initializes the dependency object with the external > dependency list. Previously, the external dependencies were > just ignored. > > Signed-off-by: Felix Moessbauer > Acked-by: Bruce Richardson > --- > app/meson.build | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/app/meson.build b/app/meson.build > index 93d8c15032..0ea04cadeb 100644 > --- a/app/meson.build > +++ b/app/meson.build > @@ -44,7 +44,7 @@ foreach app:apps > subdir(name) > > if build > - dep_objs = [] > + dep_objs = ext_deps > foreach d:deps > var_name = get_option('default_library') + '_rte_' + d > if not is_variable(var_name) Reviewed-by: Maxime Coquelin Thanks, Maxime