From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id D40BE2BB9 for ; Thu, 8 Jun 2017 12:02:37 +0200 (CEST) Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 08 Jun 2017 03:02:36 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.39,314,1493708400"; d="scan'208";a="97016884" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.91]) ([10.237.220.91]) by orsmga002.jf.intel.com with ESMTP; 08 Jun 2017 03:02:35 -0700 To: Beilei Xing , jingjing.wu@intel.com Cc: dev@dpdk.org References: <1495606206-72739-1-git-send-email-beilei.xing@intel.com> <1496822996-26398-1-git-send-email-beilei.xing@intel.com> <1496822996-26398-2-git-send-email-beilei.xing@intel.com> From: Ferruh Yigit Message-ID: <9ac3dc45-94a6-bba5-4a34-3c94c7d80d73@intel.com> Date: Thu, 8 Jun 2017 11:02:34 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <1496822996-26398-2-git-send-email-beilei.xing@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v2 1/4] net/i40e: support flexible payload parsing for FDIR X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Jun 2017 10:02:38 -0000 On 6/7/2017 9:09 AM, Beilei Xing wrote: > This patch adds flexible payload parsing support for > flow director filter. > > Signed-off-by: Beilei Xing <...> > /* 1. Last in item should be NULL as range is not supported. > - * 2. Supported flow type and input set: refer to array > + * 2. Supported patterns: refer to array i40e_supported_patterns. > + * 3. Supported flow type and input set: refer to array > * default_inset_table in i40e_ethdev.c. > - * 3. Mask of fields which need to be matched should be > + * 4. Mask of fields which need to be matched should be > * filled with 1. > - * 4. Mask of fields which needn't to be matched should be > + * 5. Mask of fields which needn't to be matched should be > * filled with 0. > */ > static int > @@ -769,15 +948,29 @@ i40e_flow_parse_fdir_pattern(struct rte_eth_dev *dev, > const struct rte_flow_item_tcp *tcp_spec, *tcp_mask; > const struct rte_flow_item_udp *udp_spec, *udp_mask; > const struct rte_flow_item_sctp *sctp_spec, *sctp_mask; > + const struct rte_flow_item_raw *raw_spec, *raw_mask; > const struct rte_flow_item_vf *vf_spec; > + > uint32_t flow_type = RTE_ETH_FLOW_UNKNOWN; > enum i40e_filter_pctype pctype; > uint64_t input_set = I40E_INSET_NONE; > uint16_t flag_offset; > enum rte_flow_item_type item_type; > enum rte_flow_item_type l3 = RTE_FLOW_ITEM_TYPE_END; > - uint32_t j; > + uint32_t i, j; > + enum i40e_flxpld_layer_idx layer_idx = I40E_FLXPLD_L2_IDX; > + uint8_t raw_id = 0; > + struct rte_flow_item_raw raw_arr[I40E_MAX_FLXPLD_FIED]; Hi Beilei, Getting build error [1] with ICC, can you please check? [1] ...dpdk/drivers/net/i40e/i40e_flow.c(2302): error #2405: array of elements containing a flexible array member is nonstandard struct rte_flow_item_raw raw_arr[I40E_MAX_FLXPLD_FIED]; ^