From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D7C6642C08; Thu, 1 Jun 2023 22:00:19 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CAF9840FAE; Thu, 1 Jun 2023 22:00:19 +0200 (CEST) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id 28EE840DDC for ; Thu, 1 Jun 2023 22:00:18 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1685649617; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=q4ZMaGUhOLkrFPPuiev0n8J+QiSb9yuHWNs5FZYVYYw=; b=h2u/ybjzJxl8qxfsRckdHCFSCRANenA85KchOxKHXpJeVg43+bxP+a/YsdtxU37z1lhGUY S0celfagm2Mm6GNEcmIQ2JKsAACDzY36XPXhl5yE58PR7EK+oB8Ig3MUFEse69FS/AN/te GOkvIOeVXlHgg/AkEX1NKzPPH6Yq7aY= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-471-G4jNRO7PMqS2Sqz3y7x7Rw-1; Thu, 01 Jun 2023 16:00:13 -0400 X-MC-Unique: G4jNRO7PMqS2Sqz3y7x7Rw-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 32E2A85A5AA; Thu, 1 Jun 2023 20:00:13 +0000 (UTC) Received: from [10.39.208.25] (unknown [10.39.208.25]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 37A4D14171BB; Thu, 1 Jun 2023 20:00:12 +0000 (UTC) Message-ID: <9ac84bfd-94ea-095c-1c3b-942302963bc9@redhat.com> Date: Thu, 1 Jun 2023 22:00:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH v3 0/4] vhost: add device op to offload the interrupt kick To: Eelco Chaudron , chenbo.xia@intel.com, david.marchand@redhat.com Cc: dev@dpdk.org References: <168431450017.558450.16680518469610688737.stgit@ebuild.local> From: Maxime Coquelin In-Reply-To: <168431450017.558450.16680518469610688737.stgit@ebuild.local> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/17/23 11:08, Eelco Chaudron wrote: > This series adds an operation callback which gets called every time the > library wants to call eventfd_write(). This eventfd_write() call could > result in a system call, which could potentially block the PMD thread. > > The callback function can decide whether it's ok to handle the > eventfd_write() now or have the newly introduced function, > rte_vhost_notify_guest(), called at a later time. > > This can be used by 3rd party applications, like OVS, to avoid system > calls being called as part of the PMD threads. > > v3: > - Changed ABI compatibility code to no longer use a boolean > to avoid having to disable specific GCC warnings. > - Moved the fd check fix to a separate patch (patch 3/4). > - Fixed some coding style issues. > > v2: - Used vhost_virtqueue->index to find index for operation. > - Aligned function name to VDUSE RFC patchset. > - Added error and offload statistics counter. > - Mark new API as experimental. > - Change the virtual queue spin lock to read/write spin lock. > - Made shared counters atomic. > - Add versioned rte_vhost_driver_callback_register() for > ABI compliance. > > Eelco Chaudron (4): > vhost: change vhost_virtqueue access lock to a read/write one > vhost: make the guest_notifications statistic counter atomic > vhost: fix invalid call FD handling > vhost: add device op to offload the interrupt kick > > > lib/eal/include/generic/rte_rwlock.h | 17 +++++ > lib/vhost/meson.build | 2 + > lib/vhost/rte_vhost.h | 23 ++++++- > lib/vhost/socket.c | 63 +++++++++++++++++-- > lib/vhost/version.map | 9 +++ > lib/vhost/vhost.c | 92 +++++++++++++++++++++------- > lib/vhost/vhost.h | 69 ++++++++++++++------- > lib/vhost/vhost_user.c | 14 ++--- > lib/vhost/virtio_net.c | 90 +++++++++++++-------------- > 9 files changed, 278 insertions(+), 101 deletions(-) > Applied to dpdk-next-virtio/main. Thanks, Maxime