From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 39F2CA00C5; Mon, 14 Feb 2022 14:36:05 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28C0D40DDA; Mon, 14 Feb 2022 14:36:05 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 834D64067E for ; Mon, 14 Feb 2022 14:36:03 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1644845763; x=1676381763; h=message-id:date:subject:to:references:from:in-reply-to: content-transfer-encoding:mime-version; bh=8xQy1LNgAPSHdbgzrB3gcKt+UT6DWiD9lvCPZB7qgfo=; b=bSOoEge+ary3VBwrao0TYtNUB2Sihcue1mKgx/LOtRPPJEwBROx0wEpb 2wO7AvIXcz4f0JodQ7L1+5PAmJRsXbfFkbgNyxdM3kmy2yG/rNZSgzjbO gxOjseDRXTPfgubNiTjAH8BBy3QxLevLIq4Sl+dDcZPJDePCFKyyjiHaK LAeD3bhXfJ+P15H2ndZlC4bxxC7roKkgqbcw3xOCHR3FzQw4K75RB0Xby zbWIeIIAeqcDKBbJkWj7vNxGZYWoeXiMiKFJxllzy6YN97fkLgHreh4+J o29o4GDfliCButtpF7NZY5xtEKkyw12p4HmFarJei3U7AxWF7dZ/X8fue A==; X-IronPort-AV: E=McAfee;i="6200,9189,10257"; a="313366043" X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="313366043" Received: from orsmga004.jf.intel.com ([10.7.209.38]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 14 Feb 2022 05:35:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.88,368,1635231600"; d="scan'208";a="635196416" Received: from orsmsx601.amr.corp.intel.com ([10.22.229.14]) by orsmga004.jf.intel.com with ESMTP; 14 Feb 2022 05:35:56 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX601.amr.corp.intel.com (10.22.229.14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 05:35:56 -0800 Received: from orsmsx610.amr.corp.intel.com (10.22.229.23) by ORSMSX610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20; Mon, 14 Feb 2022 05:35:55 -0800 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx610.amr.corp.intel.com (10.22.229.23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.20 via Frontend Transport; Mon, 14 Feb 2022 05:35:55 -0800 Received: from NAM11-CO1-obe.outbound.protection.outlook.com (104.47.56.175) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2308.20; Mon, 14 Feb 2022 05:35:55 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=eiU+BN2J3BSKISYYS/p4KNGSzezgdrKW73Ws8zJt8UIoBHxCEc4n/jm77ionMvx1sON0UrcmPrPM/qUrd2mlo5G1/pGpitp4UJo+lrCAPxERWXyzyYL6UANpxhsBynYTGjRU8uMYwbgaUE3bh4lF9tXdlCJ1rj6PBb6bnk7mhw0wgGG0Hqs5agxcH2Ig7t/SfKuufOTLIwj3pOdFNpYP/gjO61ndLVW9rMISJDEDv4w0if3fW/FnETeHFrVz33+l9+qnP4nS3j+LUjrWZ65RQc39pmzL4UAuk/nZjbaL1496CIHbEpSjl/X/q19ni2x8Up+LCkYuGZCBnQA/82I24g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=7wNJ9CCKq8UQJa1i6S9d+gD8agnmb2UI3p0qPJjL4xU=; b=HbBDUCtkZcvfGiye90sgz3P+v13GA3A6ykt0B7YsK+WhVR2J2X3xu1sNLgJDbtGWEyHHArq9uG/HdShB9igWE7y+VOnUmgQ9IRLwlqix6VoIvTUVniGP1NIGXUU9AdJ89A6/UUulOF5pNT+VZTBk6ux6lmYroZ14DukFYR9v2vBbwR0wmgtC15KDcS/XPEI+Bazl9X7NnXqiE3KqiHlOxRIV8SmOMkwg1RoWsU1pXIpZ0ySAV2vCsVdCJpAisgn8qzljVlhaAw7tgyJ4waxmZ8adrNXO1DW+i2u0Lz3M7r7I2Dock6hqs1+yGS92glA8sGodsZTRYbnWj77NB6FL7w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by CH0PR11MB5236.namprd11.prod.outlook.com (2603:10b6:610:e3::10) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4975.11; Mon, 14 Feb 2022 13:35:53 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::98be:5506:5020:28a2%4]) with mapi id 15.20.4975.019; Mon, 14 Feb 2022 13:35:53 +0000 Message-ID: <9ae7a914-fc0f-f2d9-5e48-00c56676eab1@intel.com> Date: Mon, 14 Feb 2022 13:35:48 +0000 Subject: Re: [PATCH 3/6] drivers/nfb: do not report zero-sized TX burst Content-Language: en-US To: , References: <20220214112541.29782-1-spinler@cesnet.cz> <20220214112541.29782-3-spinler@cesnet.cz> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20220214112541.29782-3-spinler@cesnet.cz> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0018.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:150::23) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7b637010-1a80-475c-cd61-08d9efbeebe3 X-MS-TrafficTypeDiagnostic: CH0PR11MB5236:EE_ X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:83; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: 6bY+/cvCNzZ6QFfrdU/C6VH7/fDhUxOkKShY0ulo2Oyrw8G6A73uSK9vBLjeKKX73LGIfjbPeyQwQ1+xU9GFLnqN1hhTvcKhqQioTvcjmVNe2d5Wo7jJWdXNPTVLJ+EqWA+Lm5kfOIAdBfbzhQXH9stJ7f3uayJsUyYs+FjpMt1ECYri+6PIgePIrvZE2p6f2iKJ3gj1r9R+K6EYLOCyjPEevbmZIyRb/STa0OBPDjgu3Z5H7SkE9P5o529GeqkfsfGAYXAMhSSKiUyd16+iaoqMmIlCnWtFgoC8pMx+xiBbm+Rv0my1E1YO0UV2KZ2ySVGKz4M6FNpiCneL6gyGrvII4Luk6PCQGJ7EdJKqERrzgl4jp9U91HozioGXp7aesdtd29KTmwGvr4MiF3vQIkGAVbE3BtLmk8hje3Twq4NSSK/JcwWzKDVDFGXMIjVVHvuQrQ+KyauV085JzrC5KjHDLpzdMWhK9xhrh/Kf6WLn74BmeNxl1HS5CdNkw/Lv2pFDDTkWIH/XA3BqeX/e0wxDxCKA83sWRUTmlvkiF3HznhcfOFEysSRoshuGF6RRGcE16xMUMGKf52zRgfuULA3tJk9IDOtY/na4ZsIU/qX/ORw7NHAfoMgNHbRk67BADiJ1ocMSHrBF0uZMsHZVUEy+8ihAJWWW0xNgXYaFFHbTY/ECkO/Xwz18Ii+gzfeqz2Y+Ptsu3YwuoCJzenyx/Q== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230001)(366004)(8936002)(2906002)(6506007)(31686004)(5660300002)(38100700002)(316002)(6486002)(186003)(2616005)(36756003)(83380400001)(26005)(6512007)(66556008)(508600001)(53546011)(4744005)(82960400001)(44832011)(8676002)(66946007)(31696002)(6666004)(86362001)(66476007)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aGFnc1hJN3g2c2FzUTZOSTkvd3pMV2dVTUZIWllDQ1VlS210d1RDcWxmdXVZ?= =?utf-8?B?V3pqV2Z2VXg0SWZzcEt1R21FdGtiZ2VHM3huR3M4R2gxOWdjdkdGWDJFL2Fl?= =?utf-8?B?dDNHS1R1Um90NFlQb1NBTU1tUVNwL3NJMk53ZXhxYlNBVCtkdWpHYnBsSTlJ?= =?utf-8?B?N002TFNZSnJ4NzVQZDJhSXlYZlBXY0NGd2hXVFRTZEEzRmY0NlQ0YlVRbTJT?= =?utf-8?B?M1IvY1lRTWJHNjFSUWxHQW85TSs5a01nQlBqbHMvZm5FalN6cFhSd21Fb3M3?= =?utf-8?B?aEhtUEw3bmI1VkxzazVjUHVZWk1xNXJKciszQnVacWNWZzZZN3BJWTZ4WUti?= =?utf-8?B?aUdwMlBZNFdFeHdEckU0eWQ0VUtuKzZZUUE5Ulc5WUUrcnE4U3RKb09lNXlY?= =?utf-8?B?aitkeENQZ1NUdWo2dUVjR0w3RlhBUGJpbGgzVDJNWDlQV3dHcTBUUkxCV3g4?= =?utf-8?B?RHVza21FLzVLN0MyelRWVmJING9XZjVwZUVQaG1zcExrOGVhQkdETUQ4NkZ3?= =?utf-8?B?dFFOeVUzT1dKdHlvWEw5Sjc3dVpmWFYwK1Z5VFBYVFdTVjBjY1ptR0dzeUdt?= =?utf-8?B?SkY1cVNrYU9ST1ZYa2xuMnpqcHprcVVGYnBFT0poUVVSZlY1aGVBck1FM2RC?= =?utf-8?B?cGFISUNoUUNJNHNGNG5kSGdIQnFNQzNXVzNHVGtDSjhocEJ1SE9qVUZibXpQ?= =?utf-8?B?cG1SMG9yZVpzMUp1Y2tHVHhSTTc2Y1hzS1BzdytBN0VNaitoallXbDBSTHFR?= =?utf-8?B?NnVIeDVjOEhudlorQ2tpMklJR2phVFNTMFg5U01pbUhuY1hvUmxYbytjMGkv?= =?utf-8?B?WDk0aFFTRjQ3Z21MZlI0TmdjQWc1ajkzN05kWFczM3RPNlF3MVpJQU9sdWtp?= =?utf-8?B?Y1YxS1QzNDUvN0hOa2FOR3M2WXpqTHJPa2ZWaFpKZk42MGNiZU5rRXBCUkx3?= =?utf-8?B?eXc4OEQ3ZDdhSnFFeURIZldEc3FDQjNEanowUnpuZ3poWWpqeGNQS0NQTWtO?= =?utf-8?B?UjhnQ2VRL2hRaTFCaUZkWUd6aHVwNzJFRGZLMS9jQmF2dGsyd0RWeTJCN1VR?= =?utf-8?B?eEdqNVl1S2NnRTJSVDltekJMNFprT2daMzhYSnJzTXJjMDJKQWRySEQ2YTZa?= =?utf-8?B?VDZhUTVCQldpekd4SlJKU1N6Z05FZ29RNE0vTkMvYS96bWkyY0R6dUVaZ054?= =?utf-8?B?SXVWekZXOXdXWVQ1Z3BkT3RrMCtoZk9zWTJLdXVlMVA1UXc0bnNsSUxXcisz?= =?utf-8?B?TWlpOGU2MTZWc3RRMUJhOXJzK1V3VUZ2dEdNa0RVZGc0ZUtGUHlMaG1Qb2gr?= =?utf-8?B?cXNmVjJnaXhjeE5xMW9GdGp1V2ZWWlhMQXRxcE5VbzdWZGl3VzNYQVlOVVZv?= =?utf-8?B?M0RCUitZdUVKckU2QUh0VGFSZTRoeWg3NE5kWWZYRW9OVEJFRmpGQW10SXJB?= =?utf-8?B?dG1TdEtPSzVuQ0xqMjMvaVVmemZvYnpXZ1F4Q3hiOVZacVptVUZNNmJLbDBG?= =?utf-8?B?ZWkyVjdsdXB1dngvbmZaRGFMYURjZFdYK2pSS0graUtPMFk4OWZaaFN6RDAv?= =?utf-8?B?aGtvTnAxRG0xd0V6cTFQOXluK0xCeW12amVQN2MyMzNNekdNYkFZWFB4RkV2?= =?utf-8?B?d21LOVpKQ0Nidmh2YkN1OThxVlJVSkt1SmRhTU5OWitjN2FGSmRBM2s1bTBl?= =?utf-8?B?Vm9wRU03NTVjODlMSUcyTElUMEk1bXNwWGRKNGpvWS9CdzN2Zzh4ckJaZFJn?= =?utf-8?B?c0JDTmZZaVhoSmZnU0lLR2NWSmtmTktjMVNGL2pvQnZadTNlaVNhK2FlRlBa?= =?utf-8?B?ZExmaTFNZGxUYnNKWXNuVzZpUi92Y0JiSkloSVg5NWNtQnJEcmIxSXFaYXdm?= =?utf-8?B?cWtUOUlIU0tSK3QrN2RQRzNSS0lVaGZwSG0wV2FyNHVRQ0p1TFZHWkd5Y05Y?= =?utf-8?B?b1Uzb3BjUUduVVg1eTNFUENkd1ZVSUNZUVVsR0pDUkFHQzN6R2k3ZzNwUlBI?= =?utf-8?B?WXU2a0NUTThHOVppdGNUVmZZTExFSjE5Q29rVzc4WmFPUG5lWVEzcGRsTkg5?= =?utf-8?B?N3ZZQkZiU1BtSllRU0h3Z3dmajlXVTNMU2RMd0VrR3Z1MkV2VGMvd0taRjBU?= =?utf-8?B?ZklGS1pQK1dDRm5FUWJRRCtpVEhLWFBSQ3lnWG5xVThyTlAyZVpHN01EUlBI?= =?utf-8?Q?S+XNmiEX1bbCdcyHw8pxm9I=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 7b637010-1a80-475c-cd61-08d9efbeebe3 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Feb 2022 13:35:53.2535 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i7LdDAfumMFozKnQWzIKdY8q/vqBuh0+mE8O9ZOLYMdmu8IF3siX6gPOs0RDKFdunn52EyO2VR/ip/givZ15Fw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH0PR11MB5236 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2/14/2022 11:25 AM, spinler@cesnet.cz wrote: > From: Martin Spinler > > Zero-sized TX burst floods the log no more. > If you want this patch to be backported, you can update commit log as fix and add fixes & stable tags. > Signed-off-by: Martin Spinler > --- > drivers/net/nfb/nfb_tx.h | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/nfb/nfb_tx.h b/drivers/net/nfb/nfb_tx.h > index d3cbe3e6b3..910020e9e9 100644 > --- a/drivers/net/nfb/nfb_tx.h > +++ b/drivers/net/nfb/nfb_tx.h > @@ -136,7 +136,10 @@ nfb_eth_ndp_tx(void *queue, > > struct ndp_packet packets[nb_pkts]; > > - if (unlikely(ndp->queue == NULL || nb_pkts == 0)) { > + if (unlikely(nb_pkts == 0)) > + return 0; > + > + if (unlikely(ndp->queue == NULL)) { > RTE_LOG(ERR, PMD, "TX invalid arguments!\n"); > return 0; > }