From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 561C9A0547; Fri, 10 Sep 2021 14:58:14 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D063B40E6E; Fri, 10 Sep 2021 14:58:13 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 059EA40E46; Fri, 10 Sep 2021 14:58:11 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 467987F4FE; Fri, 10 Sep 2021 15:58:11 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 467987F4FE DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631278691; bh=abOoTRjsGXNoVefNz+fwW76KzUwwaBG8RgF0G1TUqjQ=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=a6Fp3iAfQA0grVGQ5kdAd2wjm1cc/ilFzWtFbpSPLWeu9hWuTKvH/8umVnZEatV7L PlB34M6nAsi9swJd0Jzjbj/uZsSp93b8bkDvcvrRhGi7tBvlh8miQEOq1V85lPSnk5 FitfM2oUZh/0M8ham1mDAvRjbV2EODvVheYDBIkg= To: Maxime Coquelin , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com References: <20210910091734.7023-1-maxime.coquelin@redhat.com> <20210910091734.7023-2-maxime.coquelin@redhat.com> <7b22e721-c091-6529-88f0-50169e7ab1ba@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: <9af789b9-78a8-19ff-fc3a-f64dd653b901@oktetlabs.ru> Date: Fri, 10 Sep 2021 15:58:10 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <7b22e721-c091-6529-88f0-50169e7ab1ba@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/10/21 2:44 PM, Maxime Coquelin wrote: > Thanks for the review! > > On 9/10/21 12:06 PM, Andrew Rybchenko wrote: >> On 9/10/21 12:17 PM, Maxime Coquelin wrote: >>> >> I've failed to find F_RSS definion in virtio spec. >> Could you share the reference, please. >> >> Without the sepc it is almost impossible to review the code. > > Sorry, I forgot to add the link, you can find it on the Virtio-spec > github master branch: > > https://github.com/oasis-tcs/virtio-spec/blob/master/content.tex > > For readability, I would suggest you to clone it and build the HTML or > PDF versions. Many thanks. >>> diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini >>> index 48f6f393b1..883dd1426c 100644 >>> --- a/doc/guides/nics/features/virtio.ini >>> +++ b/doc/guides/nics/features/virtio.ini >>> @@ -14,6 +14,8 @@ Promiscuous mode = Y >>> Allmulticast mode = Y >>> Unicast MAC filter = Y >>> Multicast MAC filter = Y >> >> I'd say that >> RSS has = P >> should be added here. > > OK, as I mentionned in the cover letter, I was not sure becasue the doc > says "RSS hash" uses DEV_RX_OFFLOAD_RSS_HASH and provides mbuf.rss, > which this patch does not since it does not support (yet) > VIRTIO_NET_F_HASH_REPORT. > http://doc.dpdk.org/guides/nics/features.html#rss-hash Yes, I've seen question in cover letter. It is some kind of gap in features to claim overall RSS support - just hashing and distribution across queues without hash forwarding to user. The item definition covers both generic support and offload to deliver RSS hash. That's why I suggest P (partial). > I can try to add VIRTIO_NET_F_HASH_REPORT in v2, so that we can set RSS > hash = Y without any doubts :) > > Regards, > Maxime >