From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Andrew Bailey <abailey@iol.unh.edu>
Cc: dev@dpdk.org, dmarx@iol.unh.edu, probb@iol.unh.edu
Subject: Re: [PATCH v4] dts: add missing type hints to method signatures
Date: Wed, 20 Aug 2025 17:16:00 +0100 [thread overview]
Message-ID: <9b104aa4-c5e1-427a-ac23-6e196c9470d7@arm.com> (raw)
In-Reply-To: <20250820151850.484576-1-abailey@iol.unh.edu>
Hi Andrew,
thank you for your v4! Looks good now.
Reviewed-by: Luca Vizzarro <luca.vizzarro@arm.com>
On 20/08/2025 16:18, Andrew Bailey wrote:
> diff --git a/dts/framework/settings.py b/dts/framework/settings.py
> index 3f21615223..74dd96daa9 100644
> --- a/dts/framework/settings.py
> +++ b/dts/framework/settings.py
> @@ -251,13 +254,13 @@ def error(self, message):
> )
>
> print(f"{self.prog}: error: {message}\n", file=sys.stderr)
> - self.exit(2, "For help and usage, " "run the command with the --help flag.\n")
> + self.exit(2, "For help and usage," "run the command with the --help flag.\n")
nit: bad change, I can fix it myself (or Patrick) upon merging, so I
wouldn't worry about it.
prev parent reply other threads:[~2025-08-20 16:16 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-08-06 16:29 [PATCH v2] dts: type hints updated for method arguments and return types Andrew Bailey
2025-08-08 18:21 ` Luca Vizzarro
2025-08-08 20:49 ` Andrew Bailey
2025-08-11 10:13 ` Luca Vizzarro
2025-08-11 10:52 ` Luca Vizzarro
2025-08-18 16:50 ` [PATCH v3] dts: add missing type hints to method signatures Andrew Bailey
2025-08-19 20:46 ` Dean Marx
2025-08-20 9:52 ` Luca Vizzarro
2025-08-20 15:18 ` [PATCH v4] " Andrew Bailey
2025-08-20 16:16 ` Luca Vizzarro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9b104aa4-c5e1-427a-ac23-6e196c9470d7@arm.com \
--to=luca.vizzarro@arm.com \
--cc=abailey@iol.unh.edu \
--cc=dev@dpdk.org \
--cc=dmarx@iol.unh.edu \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).