From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C6745A0562; Fri, 3 Apr 2020 15:29:12 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 026C11C0BD; Fri, 3 Apr 2020 15:29:12 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id C81A11C0BC for ; Fri, 3 Apr 2020 15:29:10 +0200 (CEST) IronPort-SDR: THwhwvUzYj0wa/FeNvs5xzhQu5yNeSzHq5Lo0L03KfSHTYJU5zFzSgx6ndy2cazzVjz6UwS8DU Fu7ssVIxYLKA== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 03 Apr 2020 06:29:09 -0700 IronPort-SDR: EWF6nHjUv+4t4iLCXfaeLC6w/Prngk/jYbEUq1MTZvA1PQMcQ4ohkoqfv/Z9bfolpjXIbrYzRS LtTOMdbDzD2g== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.72,339,1580803200"; d="scan'208";a="238883391" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.251.89.216]) ([10.251.89.216]) by orsmga007.jf.intel.com with ESMTP; 03 Apr 2020 06:29:07 -0700 To: Xueming Li , Wenzhuo Lu , Jingjing Wu , Bernard Iremonger , Anatoly Burakov Cc: dev@dpdk.org, Asaf Penso References: <1585832629-4959-1-git-send-email-xuemingl@mellanox.com> <1585896791-2736-2-git-send-email-xuemingl@mellanox.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJUBBMBCgA+AhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEAFiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl1meboFCQlupOoACgkQ+TPrQ98T YR9ACBAAv2tomhyxY0Tp9Up7mNGLfEdBu/7joB/vIdqMRv63ojkwr9orQq5V16V/25+JEAD0 60cKodBDM6HdUvqLHatS8fooWRueSXHKYwJ3vxyB2tWDyZrLzLI1jxEvunGodoIzUOtum0Ce gPynnfQCelXBja0BwLXJMplM6TY1wXX22ap0ZViC0m714U5U4LQpzjabtFtjT8qOUR6L7hfy YQ72PBuktGb00UR/N5UrR6GqB0x4W41aZBHXfUQnvWIMmmCrRUJX36hOTYBzh+x86ULgg7H2 1499tA4o6rvE13FiGccplBNWCAIroAe/G11rdoN5NBgYVXu++38gTa/MBmIt6zRi6ch15oLA Ln2vHOdqhrgDuxjhMpG2bpNE36DG/V9WWyWdIRlz3NYPCDM/S3anbHlhjStXHOz1uHOnerXM 1jEjcsvmj1vSyYoQMyRcRJmBZLrekvgZeh7nJzbPHxtth8M7AoqiZ/o/BpYU+0xZ+J5/szWZ aYxxmIRu5ejFf+Wn9s5eXNHmyqxBidpCWvcbKYDBnkw2+Y9E5YTpL0mS0dCCOlrO7gca27ux ybtbj84aaW1g0CfIlUnOtHgMCmz6zPXThb+A8H8j3O6qmPoVqT3qnq3Uhy6GOoH8Fdu2Vchh TWiF5yo+pvUagQP6LpslffufSnu+RKAagkj7/RSuZV25Ag0EV9ZMvgEQAKc0Db17xNqtSwEv mfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ESYpV8QWj0xK4YM0dLxnDU2IYxjEshSB1T qAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4AibPtrHuIXWQOBECcVZTTOdZYGAzaYzxiA ONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxDUQljeNvKYt1lZE/gAUUxNLWsYyTT+22/ vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35p iVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVjsM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQ I3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdcq9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYH fVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH71PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZ qw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFBVOQOxCvwRG2QCgcJ/UTn5vlivul+cThi 6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJl Rr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYCGwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNh HwUCXWZ5wAUJB3FgggAKCRD5M+tD3xNhH2O+D/9OEz62YuJQLuIuOfL67eFTIB5/1+0j8Tsu o2psca1PUQ61SZJZOMl6VwNxpdvEaolVdrpnSxUF31kPEvR0Igy8HysQ11pj8AcgH0a9FrvU /8k2Roccd2ZIdpNLkirGFZR7LtRw41Kt1Jg+lafI0efkiHKMT/6D/P1EUp1RxOBNtWGV2hrd 0Yg9ds+VMphHHU69fDH02SwgpvXwG8Qm14Zi5WQ66R4CtTkHuYtA63sS17vMl8fDuTCtvfPF HzvdJLIhDYN3Mm1oMjKLlq4PUdYh68Fiwm+boJoBUFGuregJFlO3hM7uHBDhSEnXQr5mqpPM 6R/7Q5BjAxrwVBisH0yQGjsWlnysRWNfExAE2sRePSl0or9q19ddkRYltl6X4FDUXy2DTXa9 a+Fw4e1EvmcF3PjmTYs9IE3Vc64CRQXkhujcN4ZZh5lvOpU8WgyDxFq7bavFnSS6kx7Tk29/ wNJBp+cf9qsQxLbqhW5kfORuZGecus0TLcmpZEFKKjTJBK9gELRBB/zoN3j41hlEl7uTUXTI JQFLhpsFlEdKLujyvT/aCwP3XWT+B2uZDKrMAElF6ltpTxI53JYi22WO7NH7MR16Fhi4R6vh FHNBOkiAhUpoXRZXaCR6+X4qwA8CwHGqHRBfYFSU/Ulq1ZLR+S3hNj2mbnSx0lBs1eEqe2vh cA== Message-ID: <9b130a91-7d0d-ba3d-a521-64829e34a28c@intel.com> Date: Fri, 3 Apr 2020 14:29:06 +0100 MIME-Version: 1.0 In-Reply-To: <1585896791-2736-2-git-send-email-xuemingl@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v1] app/testpmd: add memory dump command X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 4/3/2020 7:53 AM, Xueming Li wrote: > Introduce new command to dump memory statistics of each socket, > summary, also show changes since last call. > > Usage: > dump_socket > > Signed-off-by: Xueming Li > --- > app/test-pmd/cmdline.c | 52 +++++++++++++++++++++++++++++ > doc/guides/testpmd_app_ug/testpmd_funcs.rst | 6 ++++ > 2 files changed, 58 insertions(+) > > diff --git a/app/test-pmd/cmdline.c b/app/test-pmd/cmdline.c > index 274e391..9bb64bb 100644 > --- a/app/test-pmd/cmdline.c > +++ b/app/test-pmd/cmdline.c > @@ -9568,6 +9568,55 @@ struct cmd_dump_result { > #undef DUMP_SIZE > } > > + > +/* Dump the socket memory statistics on console */ > +static void > +dump_socket_mem(FILE *f) > +{ > + struct rte_malloc_socket_stats socket_stats; > + unsigned int i; > + int64_t total = 0; > + int64_t alloc = 0; > + int64_t free = 0; > + unsigned int n_alloc = 0; > + unsigned int n_free = 0; > + static int64_t last_allocs; > + static int64_t last_total; > + > + > + for (i = 0; i < RTE_MAX_NUMA_NODES; i++) { > + if (rte_malloc_get_socket_stats(i, &socket_stats) || > + !socket_stats.heap_totalsz_bytes) > + continue; > + total += socket_stats.heap_totalsz_bytes; > + alloc += socket_stats.heap_allocsz_bytes; > + free += socket_stats.heap_freesz_bytes; > + n_alloc += socket_stats.alloc_count; > + n_free += socket_stats.free_count; > + fprintf(f, > + "Socket %u: size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf \tcount alloc: %-4u free: %u\n", > + i, > + socket_stats.heap_totalsz_bytes / 1.0e6, > + socket_stats.heap_allocsz_bytes / 1.0e6, > + (double)socket_stats.heap_allocsz_bytes * 100 / > + (double)socket_stats.heap_totalsz_bytes, > + socket_stats.heap_freesz_bytes / 1.0e6, > + socket_stats.alloc_count, > + socket_stats.free_count); This gives an output like [1], can you please divide to (1024*1024) to convert byte to Mb, than it can give more clear numbers. [1] Socket 0: size(M) total: 2933.915648 alloc: 1871.655424(63.794%) free: 1062.260224 count alloc: 2137 free: 36 Socket 1: size(M) total: 2923.429888 alloc: 1863.400064(63.740%) free: 1060.029824 count alloc: 177 free: 1 Total : size(M) total: 5857.345536 alloc: 3735.055488(63.767%) free: 2122.290048 count alloc: 2314 free: 37 Memory total change: 0.000000(M), allocation change: 0.000000(M) > + } > + fprintf(f, > + "Total : size(M) total: %.6lf alloc: %.6lf(%.3lf%%) free: %.6lf \tcount alloc: %-4u free: %u\n", > + total / 1.0e6, alloc / 1.0e6, > + (double)alloc * 100 / (double)total, free / 1.0e6, > + n_alloc, n_free); > + if (last_allocs) > + fprintf(stdout, "Memory total change: %.6lf(M), allocation change: %.6lf(M)\n", > + (total - last_total) / 1.0e6, > + (alloc - last_allocs) / 1.0e6); > + last_allocs = alloc; > + last_total = total; > +} > + > static void cmd_dump_parsed(void *parsed_result, > __attribute__((unused)) struct cmdline *cl, > __attribute__((unused)) void *data) > @@ -9576,6 +9625,8 @@ static void cmd_dump_parsed(void *parsed_result, > > if (!strcmp(res->dump, "dump_physmem")) > rte_dump_physmem_layout(stdout); > + else if (!strcmp(res->dump, "dump_socket")) > + dump_socket_mem(stdout); > else if (!strcmp(res->dump, "dump_memzone")) > rte_memzone_dump(stdout); > else if (!strcmp(res->dump, "dump_malloc")) { > @@ -9604,6 +9655,7 @@ static void cmd_dump_parsed(void *parsed_result, > TOKEN_STRING_INITIALIZER(struct cmd_dump_result, dump, > "dump_physmem#" > "dump_memzone#" > + "dump_socket#" > "dump_struct_sizes#" > "dump_ring#" > "dump_mempool#" > diff --git a/doc/guides/testpmd_app_ug/testpmd_funcs.rst b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > index 1a9879f..d248337 100644 > --- a/doc/guides/testpmd_app_ug/testpmd_funcs.rst > +++ b/doc/guides/testpmd_app_ug/testpmd_funcs.rst > @@ -539,6 +539,12 @@ Dumps the layout of all memory zones:: > > testpmd> dump_memzone > > +dump socket > +~~~~~~~~~~~~ > + > +Dumps the memory usage of all sockets:: > + > + testpmd> dump_socket 'dump_socket' looks like it will list the socket information, what do you think changing the command name to 'dump_socket_mem' to clarify it will dump the memory information? > > dump struct size > ~~~~~~~~~~~~~~~~ >