From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9A10043351; Fri, 17 Nov 2023 10:16:01 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 21A9340648; Fri, 17 Nov 2023 10:16:01 +0100 (CET) Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2053.outbound.protection.outlook.com [40.107.223.53]) by mails.dpdk.org (Postfix) with ESMTP id 0BDF040273; Fri, 17 Nov 2023 10:16:00 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Ggxmq0EeLCYRoQ92YHNRQ7tWnWgha13cdBz7Iegx7MAZFmh18i1phRB6Jt45oOpK0ztIEurz83jeW05fXoy/TzH8ZRXvA16eQM3f0EHXj5OAPA+HYTDBJJwJ1msymZAcgjnLrY/UudTW5u+euuO1jV78lCW7jwQ7f4bdnND1uqR6rYaFIj0yKrPQwfzRDNoycVZHKLotw2yHp5bsde7kR7RGg4jqbLOoxYkDYMWor7jqShlEgr8O7ax6F9274pbuNg4HD+FIVgBQRmgaNkRs8RtSyOB6Y8hNE4JStv7u40/jkiL4eox7Mp+cJ0q8v/+gFIURcl8L7e28j+NOTVcFKw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=awCCLqX1QV17IcmxcqpJ976wEUknuhozxQ25xpwRVl0=; b=jTwmCqSUQ8OV4sAfF8TVfmmdyBCUM6X20YMq6Y3X7xLle4o0+7RNYlHiuG40PYSfOsKPSE4ujyzCHQgubytPlXRJMlxjIE4HGNpJXuLCQFgPZehlfV1Lhl/PKtp8HobiCrnkOOYtuQPQ/V2FPo2PyQm9BtRl3yDvw0WRYYjyQPF2ArKzaZQtNFjAjTwNzEc7+rySgk5ACufSrPRmlFxhVJXrkXZjjH0OBbgTfyIFTHLVaKH2j37cI6fXQDb4nndKa7V8JTzF6gutX2T3PpV+LO7FfP9cB1TYjO9fQFKF2Woa51LNuzeOFD0aKjJAHTtzFh/8q1mdNTghOwBa5RJt3w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=awCCLqX1QV17IcmxcqpJ976wEUknuhozxQ25xpwRVl0=; b=4m30zsuUmEL7/YUeZOBW67UqG3UoE9iRh3qhVBff44E1lJOYtSgeJpr0TqoRJlfyIJkN0fROmuxUAPxA4M2yt7DxC3tEhFc40gg+djH43ng1i2ahjxrQwT4qc6lZoCOuHoIqS/1sWNYe2K8ufcFIcv1rlWLvStLhs4hZ7wbPu4s= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by MW6PR12MB8866.namprd12.prod.outlook.com (2603:10b6:303:24c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7002.21; Fri, 17 Nov 2023 09:15:56 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::2569:edb2:670f:816f%6]) with mapi id 15.20.7002.022; Fri, 17 Nov 2023 09:15:55 +0000 Message-ID: <9b22ba19-3b55-4624-96ea-c85ee541485c@amd.com> Date: Fri, 17 Nov 2023 09:15:20 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/txgbe: fix out of bound access To: Jiawen Wu , 'Jian Wang' , 'Ferruh Yigit' Cc: dev@dpdk.org, stable@dpdk.org, 'Luca Boccassi' References: <20231116140718.4026676-1-ferruh.yigit@amd.com> <0c7201da1900$28c7d450$7a577cf0$@trustnetic.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <0c7201da1900$28c7d450$7a577cf0$@trustnetic.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR2P281CA0177.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:9f::13) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|MW6PR12MB8866:EE_ X-MS-Office365-Filtering-Correlation-Id: f0db1692-6f0d-4282-f32d-08dbe74dcdbf X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: G4WYwsswqG5ZDJUgmLXWkQpphjPB4u8tsQcS8Ur3LDjzCxnWOEvHXAIz9zFyetzeKZjxKtBE+XDZvP6ylVd8p5cfwvMq+U6eTusCIi1WcAZ3JmwP1LeiC3PeeREd8JqmopL1Ciwh14x8v4fcZb29eb7s4c3RuAJNQ6AJHe2l2wnfDyH1+eFg/zwBfCPZuc6+azXfYBzzfqYBJeSit5Pj2eepfAyQnTP5gmiriJji3droXyfDA+aVtxVE3QfgEb5CxgkHz5o/THVJCO20STFqJlGzLpgXQCzDBFYV0tinj6vQ/KXvfsVSWTAycwjjJCX0hfizeTj9HWtejuvxj0kCz/WNX4DJBFrO7TSB4omhFLTezZEXa2vPyyYPVOIp0vZUAUZTHU0zdqcVoJ/psfVoGgbr2b7vOjG1wn6t5uFPNgNkGvz3OP2Y9J5EQwYtizNTo1LbzAfGWBuCFG9hAQu6PpUcb0vSisWqIk2/TetMMgREzDsrpSF2F5+cKAlpxllf3ac9KYkYmiih5lXrgBfwGiOZzoCvsPDeQZRc2NRDZplxVGPTIPsbW2r8cEKZhTbQia/YHhBodm6z+hUeimochrSPdFGh++1MYQcwTDJWyUdFIQ3FZ9UieWxXMRlpA1UFnedp1sUac20DvxC81fAHpg== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(396003)(39860400002)(136003)(366004)(346002)(230922051799003)(451199024)(186009)(1800799009)(64100799003)(66946007)(110136005)(66476007)(41300700001)(66556008)(316002)(5660300002)(86362001)(31696002)(2906002)(4326008)(8936002)(8676002)(44832011)(83380400001)(38100700002)(31686004)(6666004)(966005)(6486002)(478600001)(45080400002)(36756003)(2616005)(6506007)(26005)(6512007)(53546011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TytqV3RMUGdWbzhRYzVZUFRUNXg0ZldVVUl3UGd5Q1pqTUZ5S295VDJELysw?= =?utf-8?B?a3BxQ0E5VVdXaWxoaUh4bnh0aUZXVVZBMXNiZjN0aVVpMU1ZMlhBbHNKYnVN?= =?utf-8?B?UE5PKzlUd2RkblVaSUZiWU44TXVjeVh1YThWYXpzUmJIbVh1K0JLN0xwUUhr?= =?utf-8?B?amNsc0hSWG9uUHNyK0xvbnppVnM1R2tKYmJ5cjBjQW93Z3lUSmJiSlBKcjc1?= =?utf-8?B?SExWQTNLeEEvSHA2ME9waitYQXpvV0N0YW80Q2pnc3ViVVhHR1pZRlYrbUVk?= =?utf-8?B?QmdjbFd3VzRUV0YzVmc3TmVDK2FxdEZhQ2xrRmpNZlJhcnRtTG9rTk9RZVds?= =?utf-8?B?OUhqQUM2ZUx4dUpTQ3JoS3B0SThON0JGemFXMUZIQytLVzNiSlQ1TFdYRjF6?= =?utf-8?B?Z0RqcjBSak1EeFMyTUNKcENhU3FZU0xWK0NkY1FlM0c1azZqUThNdFdhTzFj?= =?utf-8?B?ZXh5TEhqZ0FlUElxREViei8zcnJqcDJyakFCRGt2RExIckhQK1Z4aGpRM2U4?= =?utf-8?B?d2FZb2RXNTN0ZGw1eS93d1BCdVhGV1UydkxVTjV4VzBXbG5mUHcwbUJhR3ZQ?= =?utf-8?B?UHhIbU5YTVR4RDZmOUNxTVJZU2VUbmYvejZKNWhyb1BKYnA3aEdoYi9UYzA5?= =?utf-8?B?ZXFNL0NPeFMzRklGbkYyTnZ0OEl1bmN1amlsNEtOSTdLYlJXUjhBdTRCWXJl?= =?utf-8?B?d284M0pNdWFhSGtDaGFJNGNNNjhKSi9MY3I3aXl5TTR3UVdaOFhXS21Va2hK?= =?utf-8?B?YlhJRUpCVmhMdURVQisybXM5WTlwUHQ4YjNpbEMya0hIMnBOSUpuVDFHbU9S?= =?utf-8?B?VklZY0YrTDJ2TnpCR1FDNWdqdTBoa2F3cDE3VkZzK1BmWE1YYjRubk1LRXB2?= =?utf-8?B?T21JWGp5b3VPRWJuVUtWUElqQ01wK2pXaVpDZnduZkVyR295MGhRYjUyMGxj?= =?utf-8?B?QS80clIvT0N1Y2wxdVFMVTJkVWVkUHRlcENtSlFxQTZNeDlMcG9ldUJuRldO?= =?utf-8?B?UmZNSGsycDVPemVrV0NnNTJXWmpDdVhobGxlZTkrTWVrRy9keWdnSk45U1JL?= =?utf-8?B?c0hSRE9QTnZlTDB1TXNDQ0RYZWFZYjlVbEY1ZTAzNkw5Rk04YVJ1aHNWcGZJ?= =?utf-8?B?RytWVS81em5Lb0lOL1dnVnZHNUw5eFZFV1RlVDRxYWc2ZzJnbzNFQ2VxaFl6?= =?utf-8?B?Mjd4T29OYzM4Vk9Pb1BiZDJHd0xPckwzMndKeit3L1J4aGhkajlXMXpTdnBt?= =?utf-8?B?a2hqL0JZdVA4QWhJVzlwTWM0cTIwUGU3bE43ZFpSTFF2UnZZclM2a24rR0No?= =?utf-8?B?Z3BEVW5NV3llSGdaNjFlZmpqR2ljQUxSSXI0TW9EYUJsY2xMTFpaWENBYnBZ?= =?utf-8?B?clhFdUdlSEtLYnVDSW9YV01SZk15Rm5MNjcrdXlZYjFGWUxMemthQXJVRlls?= =?utf-8?B?aE96VWtJODFsUG5La21ON0FyclZCcDIyTERVUmJsQ3pQTitCK3hvMzg4bk1B?= =?utf-8?B?UWllTzcrUGdDMjZ1cE5nNWRiQ29pZFVpN0NkbHdqQzNWSE41aGtuNDRldnl2?= =?utf-8?B?TndqZ3pEajY3VTFvZk1kNlFVR1FaRkNocnRXY2crM1pLOURTWGdRUHp6SWVa?= =?utf-8?B?eEhmWk0xdGFHallSR2ZrLzR1dlo1N3k5djZ1ckQwVHgxeStUbHJSQlJrOG1n?= =?utf-8?B?WWxwMFZlalJJejRpNHN6cEZhb3NJWjFMUjM3UURwcWJTai9MSW9pajVaaWlo?= =?utf-8?B?eXMxZHVHRStRckhaVHArUUp2UjRPYjZNNC9jdXhzZlR2RVM1U2Fydno1anZv?= =?utf-8?B?T2pHSEtMSjlJMGEzY244dm5QQ2RuU0RQQlBid0h4SlJkdWlyUGE3d3dHSnBJ?= =?utf-8?B?TzZITTBtTkE2RGZvMTBBOHpHY3FnVk5EcnlaVlFqQmh2cmdKZ09vS2RuNGVt?= =?utf-8?B?YzR5cVhSdnNZb3Irbk9Wb1h5OU4xckJxN3dTc0FBNlJqb1VxQXA4YjQvNXFa?= =?utf-8?B?QWc3R0NjUUpncjNYQm0vQWdycUF6K1JlbUR0eGlKSldSeE1tUXpxTFd0MUdl?= =?utf-8?B?SVRTWlpsRUVTczd3YTV6Q1ZybnFlb2ZYdkR1VDI1Rklvb0RjTWo1S3c3WGdI?= =?utf-8?Q?bZ3U=3D?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f0db1692-6f0d-4282-f32d-08dbe74dcdbf X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Nov 2023 09:15:55.6814 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Ffg67W4ba3Ca/JfeNs5zPJuWg5AisgwekSxQZc6M6FYH/9CUTMq2MkyQFtvNzHIw X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW6PR12MB8866 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/17/2023 2:45 AM, Jiawen Wu wrote: > On Thursday, November 16, 2023 10:07 PM, Ferruh.Yigit@amd.com wrote: >> Reported by SuSe CI [1] by GCC [2], possibly false positive. Error: >> >> In function 'txgbe_host_interface_command', >> inlined from 'txgbe_host_interface_command' >> at ../drivers/net/txgbe/base/txgbe_mng.c:104:1, >> inlined from 'txgbe_hic_reset' >> at ../drivers/net/txgbe/base/txgbe_mng.c:345:9: >> ../drivers/net/txgbe/base/txgbe_mng.c:145:36: >> error: array subscript 2 is outside array bounds ofr >> 'struct txgbe_hic_reset[1]' [-Werror=array-bounds=] >> 145 | buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi); >> ../drivers/net/txgbe/base/txgbe_mng.c: In function 'txgbe_hic_reset': >> ../drivers/net/txgbe/base/txgbe_mng.c:331:32: >> note: at offset 8 into object 'reset_cmd' of size 8 >> 331 | struct txgbe_hic_reset reset_cmd; >> | ^~~~~~~~~ >> >> Access to buffer done based on command code, the case complained by >> FW_RESET_CMD has short buffer but this code path only taken with command >> 0x30, so this shouldn't be a problem. >> >> Adding a size check before accessing to the buffer, as this is control >> plane code, additional check shouldn't hurt. >> >> [1] >> https://build.opensuse.org/public/build/home:bluca:dpdk/openSUSE_Factory_ARM/armv7l/dpdk-20.11/_log >> >> [2] >> gcc 13.2.1 "cc (SUSE Linux) 13.2.1 20230912 >> >> Fixes: 35c90ecccfd4 ("net/txgbe: add EEPROM functions") >> Cc: stable@dpdk.org >> >> Reported-by: Luca Boccassi >> Signed-off-by: Ferruh Yigit >> --- >> Cc: jiawenwu@trustnetic.com >> Cc: jianwang@trustnetic.com >> >> @Luca, I am not sure if this additional check will satisfy the compiler, >> can you please verify the patch? >> >> @Jiawen, there is a specific handling for command 0x30, from comment it >> looks like it is Read Flash command, but it looks like this command is >> not used by the driver, if this is correct can we remove the check >> completely? Removing can be simpler way to fix the compiler error. > > Thanks Ferruh. This command has been removed because flash can be read > directly by the driver. The check can be simply removed. > OK, I will send a new version for it. >> --- >> drivers/net/txgbe/base/txgbe_mng.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/drivers/net/txgbe/base/txgbe_mng.c b/drivers/net/txgbe/base/txgbe_mng.c >> index df7145094f84..9797b1b8b5da 100644 >> --- a/drivers/net/txgbe/base/txgbe_mng.c >> +++ b/drivers/net/txgbe/base/txgbe_mng.c >> @@ -147,6 +147,10 @@ txgbe_host_interface_command(struct txgbe_hw *hw, u32 *buffer, >> * two byes instead of one byte >> */ >> if (resp->cmd == 0x30) { >> + if (length < ((dword_len + 2) << 2)) { >> + err = TXGBE_ERR_HOST_INTERFACE_COMMAND; >> + goto rel_out; >> + } >> for (; bi < dword_len + 2; bi++) >> buffer[bi] = rd32a(hw, TXGBE_MNGMBX, bi); >> >> -- >> 2.34.1 >> >