From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 99C34A0C41;
	Wed,  6 Oct 2021 11:09:56 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 63AA641101;
	Wed,  6 Oct 2021 11:09:56 +0200 (CEST)
Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113])
 by mails.dpdk.org (Postfix) with ESMTP id 5BCFF40688
 for <dev@dpdk.org>; Wed,  6 Oct 2021 11:09:54 +0200 (CEST)
Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by shelob.oktetlabs.ru (Postfix) with ESMTPSA id DBC147F4E2;
 Wed,  6 Oct 2021 12:09:53 +0300 (MSK)
DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru DBC147F4E2
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru;
 s=default; t=1633511393;
 bh=5wWXkhvvFB0ETPyXdtHPRsVLeYAD8OvuAthnn/2nRgg=;
 h=Subject:To:Cc:References:From:Date:In-Reply-To;
 b=scJmxUUR4KYUjprrjrh7T19lgcWe8W2d5dt7S25P5y5gjlLHfMJlWAuYMC1Fp3nmD
 6cvv2nANsm820enHoGu+DVKDaK6d+9VtH9vg1htfadcIH3wtELBBmik5OprQLEtO9J
 BnQu4GF1CLfiPrxVGL3H0VfVV8jZfRWQPE3dDfbE=
To: Ferruh Yigit <ferruh.yigit@intel.com>, Ray Kinsella <mdr@ashroe.eu>,
 Haiyue Wang <haiyue.wang@intel.com>, Qi Zhang <qi.z.zhang@intel.com>,
 Xiao Wang <xiao.w.wang@intel.com>, Beilei Xing <beilei.xing@intel.com>,
 Jerin Jacob <jerinj@marvell.com>, Nithin Dabilpuram
 <ndabilpuram@marvell.com>, Kiran Kumar K <kirankumark@marvell.com>,
 Maxime Coquelin <maxime.coquelin@redhat.com>,
 Chenbo Xia <chenbo.xia@intel.com>, Thomas Monjalon <thomas@monjalon.net>
Cc: dev@dpdk.org
References: <20210928154856.1015020-1-andrew.rybchenko@oktetlabs.ru>
 <c1a848bb-e401-6813-1f1f-6b5b70d342df@intel.com>
From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Organization: OKTET Labs
Message-ID: <9b5b19c0-aa85-3502-0718-81e5f33a03f4@oktetlabs.ru>
Date: Wed, 6 Oct 2021 12:09:53 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <c1a848bb-e401-6813-1f1f-6b5b70d342df@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: remove legacy Rx descriptor done API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 10/6/21 11:51 AM, Ferruh Yigit wrote:
> On 9/28/2021 4:48 PM, Andrew Rybchenko wrote:
>> diff --git a/drivers/net/virtio/virtio_ethdev.c
>> b/drivers/net/virtio/virtio_ethdev.c
>> index da1633d77e..c82089930f 100644
>> --- a/drivers/net/virtio/virtio_ethdev.c
>> +++ b/drivers/net/virtio/virtio_ethdev.c
>> @@ -1894,7 +1894,6 @@ eth_virtio_dev_init(struct rte_eth_dev *eth_dev)
>>       }
>>         eth_dev->dev_ops = &virtio_eth_dev_ops;
>> -    eth_dev->rx_descriptor_done = virtio_dev_rx_queue_done;
> 
> Checking twice, should 'virtio_dev_rx_queue_done()' declaration and
> definition be removed?
> It seems there is no user of the function except here.

Yes, I lost it from my view.