From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga05.intel.com (mga05.intel.com [192.55.52.43])
 by dpdk.org (Postfix) with ESMTP id C7E2A1B256
 for <dev@dpdk.org>; Fri,  6 Oct 2017 20:43:13 +0200 (CEST)
Received: from fmsmga003.fm.intel.com ([10.253.24.29])
 by fmsmga105.fm.intel.com with ESMTP; 06 Oct 2017 11:43:12 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.42,484,1500966000"; d="scan'208";a="907519435"
Received: from unknown (HELO [10.241.225.2]) ([10.241.225.2])
 by FMSMGA003.fm.intel.com with ESMTP; 06 Oct 2017 11:43:10 -0700
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
 Olivier Matz <olivier.matz@6wind.com>, dev@dpdk.org
References: <20170911151333.5727-1-olivier.matz@6wind.com>
 <20170911151333.5727-4-olivier.matz@6wind.com>
 <d1a39436-c52a-b8a0-14f2-0089ef903f24@redhat.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9b6787da-1879-2ec3-aab6-655d92504d88@intel.com>
Date: Fri, 6 Oct 2017 19:43:10 +0100
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.3.0
MIME-Version: 1.0
In-Reply-To: <d1a39436-c52a-b8a0-14f2-0089ef903f24@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH 03/10] net/virtio: fix compilation with -Og
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Fri, 06 Oct 2017 18:43:14 -0000

On 10/6/2017 7:43 AM, Maxime Coquelin wrote:
> 
> 
> On 09/11/2017 05:13 PM, Olivier Matz wrote:
>> The compilation with gcc-6.3.0 and EXTRA_CFLAGS=-Og gives the following
>> error:
>>
>>    CC virtio_rxtx.o
>>    virtio_rxtx.c: In function ‘virtio_rx_offload’:
>>    virtio_rxtx.c:680:10: error: ‘csum’ may be used uninitialized in
>>                          this function [-Werror=maybe-uninitialized]
>>         csum = ~csum;
>>         ~~~~~^~~~~~~
>>
>> The function rte_raw_cksum_mbuf() may indeed return an error, and
>> in this case, csum won't be initialized. Fix it by initializing csum
>> to 0.
>>
>> Fixes: 96cb6711939e ("net/virtio: support Rx checksum offload")
>> Signed-off-by: Olivier Matz <olivier.matz@6wind.com>

> Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>

Applied to dpdk-next-net/master, thanks.