DPDK patches and discussions
 help / color / mirror / Atom feed
From: Hemant Agrawal <hemant.agrawal@oss.nxp.com>
To: Akhil Goyal <gakhil@marvell.com>, dev@dpdk.org
Cc: anoobj@marvell.com, radu.nicolau@intel.com,
	declan.doherty@intel.com, hemant.agrawal@nxp.com,
	matan@nvidia.com, konstantin.ananyev@intel.com,
	thomas@monjalon.net, roy.fan.zhang@intel.com, asomalap@amd.com,
	ruifeng.wang@arm.com, ajit.khaparde@broadcom.com,
	pablo.de.lara.guarch@intel.com, fiona.trahe@intel.com,
	adwivedi@marvell.com, michaelsh@marvell.com,
	rnagadheeraj@marvell.com, jianjay.zhou@huawei.com
Subject: Re: [dpdk-dev] [PATCH v4 1/4] test/crypto: remove illegal header include
Date: Wed, 8 Sep 2021 12:08:15 +0530	[thread overview]
Message-ID: <9be3eba3-e98b-fdee-f0a8-34b589696ddc@oss.nxp.com> (raw)
In-Reply-To: <20210907192246.3010653-2-gakhil@marvell.com>


On 9/8/2021 12:52 AM, Akhil Goyal wrote:
> rte_cryptodev_pmd.h is an interface between
> driver and library and it is mentioned in the
> file that application cannot use it directly.
> Hence, removing the include.
>
> Signed-off-by: Akhil Goyal <gakhil@marvell.com>
> Acked-by: Matan Azrad <matan@nvidia.com>

Series-

Acked-by: Hemant Agrawal <hemant.agrawal@nxp.com>



> ---
>   app/test/test_cryptodev.c               | 1 -
>   app/test/test_cryptodev_asym.c          | 1 -
>   app/test/test_cryptodev_blockcipher.c   | 1 -
>   app/test/test_cryptodev_security_pdcp.c | 1 -
>   app/test/test_ipsec.c                   | 1 -
>   5 files changed, 5 deletions(-)
>
> diff --git a/app/test/test_cryptodev.c b/app/test/test_cryptodev.c
> index 843d07ba37..9e823db1e6 100644
> --- a/app/test/test_cryptodev.c
> +++ b/app/test/test_cryptodev.c
> @@ -16,7 +16,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_string_fns.h>
>   
>   #ifdef RTE_CRYPTO_SCHEDULER
> diff --git a/app/test/test_cryptodev_asym.c b/app/test/test_cryptodev_asym.c
> index 847b074a4f..9d19a6d6d9 100644
> --- a/app/test/test_cryptodev_asym.c
> +++ b/app/test/test_cryptodev_asym.c
> @@ -12,7 +12,6 @@
>   #include <rte_pause.h>
>   
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_crypto.h>
>   
>   #include "test_cryptodev.h"
> diff --git a/app/test/test_cryptodev_blockcipher.c b/app/test/test_cryptodev_blockcipher.c
> index 53fd4718af..1c948eb008 100644
> --- a/app/test/test_cryptodev_blockcipher.c
> +++ b/app/test/test_cryptodev_blockcipher.c
> @@ -11,7 +11,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   
>   #include "test.h"
>   #include "test_cryptodev.h"
> diff --git a/app/test/test_cryptodev_security_pdcp.c b/app/test/test_cryptodev_security_pdcp.c
> index 30f3eb892c..a7641bab7a 100644
> --- a/app/test/test_cryptodev_security_pdcp.c
> +++ b/app/test/test_cryptodev_security_pdcp.c
> @@ -17,7 +17,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_security.h>
>   
>   #include <rte_lcore.h>
> diff --git a/app/test/test_ipsec.c b/app/test/test_ipsec.c
> index fb90130ae2..c6d6b88d6d 100644
> --- a/app/test/test_ipsec.c
> +++ b/app/test/test_ipsec.c
> @@ -15,7 +15,6 @@
>   
>   #include <rte_crypto.h>
>   #include <rte_cryptodev.h>
> -#include <rte_cryptodev_pmd.h>
>   #include <rte_lcore.h>
>   #include <rte_ipsec.h>
>   #include <rte_random.h>

  reply	other threads:[~2021-09-08  6:38 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-08-05 20:02 [dpdk-dev] [PATCH 0/4] cryptodev: expose driver interface as internal Akhil Goyal
2021-08-05 20:02 ` [dpdk-dev] [PATCH 1/4] test/crypto: remove illegal header include Akhil Goyal
2021-08-30 20:16   ` Zhang, Roy Fan
2021-08-05 20:02 ` [dpdk-dev] [PATCH 2/4] cryptodev: change valid dev API Akhil Goyal
2021-08-30 20:16   ` Zhang, Roy Fan
2021-08-05 20:02 ` [dpdk-dev] [PATCH 3/4] examples/fips_validation: remove illegal usage of APIs Akhil Goyal
2021-08-05 20:02 ` [dpdk-dev] [PATCH 4/4] cryptodev: expose driver interface as internal Akhil Goyal
2021-08-10 19:50 ` [dpdk-dev] [PATCH v2 0/4] " Akhil Goyal
2021-08-10 19:50   ` [dpdk-dev] [PATCH v2 1/4] test/crypto: remove illegal header include Akhil Goyal
2021-08-11  6:52     ` Matan Azrad
2021-08-10 19:50   ` [dpdk-dev] [PATCH v2 2/4] cryptodev: change valid dev API Akhil Goyal
2021-08-11  6:54     ` Matan Azrad
2021-08-11  8:12       ` Akhil Goyal
2021-08-10 19:50   ` [dpdk-dev] [PATCH v2 3/4] examples/fips_validation: remove illegal usage of APIs Akhil Goyal
2021-08-11  6:56     ` Matan Azrad
2021-08-11  8:19       ` Akhil Goyal
2021-08-30 20:27         ` Zhang, Roy Fan
2021-08-31  7:03           ` Akhil Goyal
2021-08-31  8:38             ` Zhang, Roy Fan
2021-08-10 19:50   ` [dpdk-dev] [PATCH v2 4/4] cryptodev: expose driver interface as internal Akhil Goyal
2021-08-11  7:00     ` Matan Azrad
2021-08-11  8:20       ` Akhil Goyal
2021-08-30 20:30     ` Zhang, Roy Fan
2021-09-07 19:00   ` [dpdk-dev] [PATCH v3 0/4] " Akhil Goyal
2021-09-07 19:00     ` [dpdk-dev] [PATCH v3 1/4] test/crypto: remove illegal header include Akhil Goyal
2021-09-07 19:00     ` [dpdk-dev] [PATCH v3 2/4] cryptodev: change valid dev API Akhil Goyal
2021-09-07 19:00     ` [dpdk-dev] [PATCH v3 3/4] examples/fips_validation: remove illegal usage of APIs Akhil Goyal
2021-09-07 19:00     ` [dpdk-dev] [PATCH v3 4/4] cryptodev: expose driver interface as internal Akhil Goyal
2021-09-07 19:22     ` [dpdk-dev] [PATCH v4 0/4] " Akhil Goyal
2021-09-07 19:22       ` [dpdk-dev] [PATCH v4 1/4] test/crypto: remove illegal header include Akhil Goyal
2021-09-08  6:38         ` Hemant Agrawal [this message]
2021-09-08  8:05           ` [dpdk-dev] [EXT] " Akhil Goyal
2021-09-07 19:22       ` [dpdk-dev] [PATCH v4 2/4] cryptodev: change valid dev API Akhil Goyal
2021-09-08 15:16         ` Akhil Goyal
2021-09-07 19:22       ` [dpdk-dev] [PATCH v4 3/4] examples/fips_validation: remove illegal usage of APIs Akhil Goyal
2021-09-07 19:22       ` [dpdk-dev] [PATCH v4 4/4] cryptodev: expose driver interface as internal Akhil Goyal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9be3eba3-e98b-fdee-f0a8-34b589696ddc@oss.nxp.com \
    --to=hemant.agrawal@oss.nxp.com \
    --cc=adwivedi@marvell.com \
    --cc=ajit.khaparde@broadcom.com \
    --cc=anoobj@marvell.com \
    --cc=asomalap@amd.com \
    --cc=declan.doherty@intel.com \
    --cc=dev@dpdk.org \
    --cc=fiona.trahe@intel.com \
    --cc=gakhil@marvell.com \
    --cc=hemant.agrawal@nxp.com \
    --cc=jianjay.zhou@huawei.com \
    --cc=konstantin.ananyev@intel.com \
    --cc=matan@nvidia.com \
    --cc=michaelsh@marvell.com \
    --cc=pablo.de.lara.guarch@intel.com \
    --cc=radu.nicolau@intel.com \
    --cc=rnagadheeraj@marvell.com \
    --cc=roy.fan.zhang@intel.com \
    --cc=ruifeng.wang@arm.com \
    --cc=thomas@monjalon.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).