From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id D044345658; Fri, 19 Jul 2024 22:39:15 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8BAAD40E0F; Fri, 19 Jul 2024 22:39:15 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2073.outbound.protection.outlook.com [40.107.94.73]) by mails.dpdk.org (Postfix) with ESMTP id E16224026B; Fri, 19 Jul 2024 22:39:13 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=G8FnpHNP9q4tDDQeoVXqRyLADC1p7hbkO9w9anFhgXkbabE5Z5cAnL2VGP/MJO3uYtczvO51EpZaISm9Nudbu+/pozqigo0FUqh21tIcwpKoDgunzQ0Or5qcpGnQ7UFrRoTfyue9Q2aWRSzppoAKSJfI+OWiK05gz1wGqOEu4aIv7LFCjMhAG7TbFP5nnUHxOpdavx9zn/+ntsiCBz7kJ6AK0fJuHF7pGC31zUWFWUK/X5Z7PuAbAw1bjC4YYecQmx2jMp+lgEPRb7davzagBzWfshsLv8M+wbr93rDP+svbMRPIPst+pWb/tyFyX0jRyGyFi0KR+z3maovFgA29xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=DeuEnDNaRQ8bJ/+1maxah+XjdzC2abS8HsPMA9QOs3Q=; b=qldb7RL+rQf9mCdqDNEyeq9TwdZH0z0ybDvYBvrBr2G/KT/iTIG3XmEpGCByDpw6QeMvFbyqht6ENqlgMyJH/vWKEW1e731HJOaN8CPFWlH3oa3mskAbtV61BBjAAZhQ9VZ/KDAvpqsPzD3TIOO4b7xUP6mqDH6l/PvS0FDK/QMQiUKRTO/JutZ63M92qTl7uyLLGKez9b7UU2A4j7pqLxk0FcCawBvAuLSq2wqXiM6mlbzDRBkyuhc1brkzYsxT2xzSdP0AFN3yAfRrec99egGGT2/ytvo98KaoQpYqYWbcLI9vZZreRDWHAZj30y5YeHB8z+A6csAnLCA5A/Tolw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=DeuEnDNaRQ8bJ/+1maxah+XjdzC2abS8HsPMA9QOs3Q=; b=S9Pl6rMCamenfGhWi3t24Y2subQEPIzOjXkHheMbDkHQz5YOpzu28qiB5q+cSk1KmimIRpq6/X7w6pdi1H5c4TG+iNQj5S5/wp3L/1fpldfuATEXv/ih/lcSe+cN3XYR7yTQpjTkEXgxJkHPthzGP/j4zGIQUDPTaVKgC7M6ihY= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SN7PR12MB8132.namprd12.prod.outlook.com (2603:10b6:806:321::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.20; Fri, 19 Jul 2024 20:39:11 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7784.017; Fri, 19 Jul 2024 20:39:11 +0000 Message-ID: <9c0c9e2e-3179-419e-9f0c-bd24984ee45f@amd.com> Date: Fri, 19 Jul 2024 21:39:04 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] net/netvsc: use rte_eth_dev_set_mtu to set VF MTU To: longli@linuxonhyperv.com, Andrew Rybchenko , Wei Hu Cc: dev@dpdk.org, Stephen Hemminger , stable@dpdk.org, Long Li References: <1721331316-8821-1-git-send-email-longli@linuxonhyperv.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: <1721331316-8821-1-git-send-email-longli@linuxonhyperv.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR0P281CA0246.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:af::11) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SN7PR12MB8132:EE_ X-MS-Office365-Filtering-Correlation-Id: f658c815-879f-4ea8-35ef-08dca832d87b X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?VFMvdkVoN2ZDVEdlbmFGdlZtNnpyV3ZwTDBKSVF4TG9kVWhFQkdWT1lPcGRW?= =?utf-8?B?ZHdDUjZ5UXRyQWlRZDFUdkxDWHdkbXIvRnFJQ1prK05pUTZNVVBVNStjVDhE?= =?utf-8?B?V3JKVFAwRE1xNWdCOXhoOUx1dm1Yb01oV2pVVGRzbDltVC9jdXNlQ2dZZXB3?= =?utf-8?B?QW9Rd3FEUm9hOXI1U1BncWNBRUdxN2h0Y1llZ1ByckRraGFjRzZQSzNobXp3?= =?utf-8?B?akFXZk9DalhBTmVPa3RwN2JRejBGMTgybkpZcWFQTWtqekpqWlVDS2pwMDRx?= =?utf-8?B?VjNBekdvTldWT0ZIekEwMWZ3TzJURVRJMENIbjREbWlXbGdHeDM3S0ZGK0hM?= =?utf-8?B?ZjNaY0MzWmpPK1kwcWJSb0plWkJ1SXZQbXlsOGVmV0JmdkpJU2o1OXRnRUxI?= =?utf-8?B?c0U0YmNWQ0JDaHA1NmJXMk1ZQmRmODBoQTlIWlJTcCs0WXFCM1FrUTI3Wk9l?= =?utf-8?B?S3p1UzA1S0pLMTRCR0VRQ1JhbkxldHBIZjU3QmhSL3RsaDZDazZEL1Via0pu?= =?utf-8?B?N0JIUkNTQk5vdHo4amQ2dkhNZmlybndEN0pTZjIyenBJLzlKaGVWNjZMUWMw?= =?utf-8?B?U2NJeUJ2SkkyQmpON09OaXJZL2J5eERxeDUxQUtXc09GRm5ub2tEL3JYSVJw?= =?utf-8?B?d2syVDdNRHVYZ1M5cEJRYUN5eWdTSlIwUmU0ZmlVcU1HUGZsQlBOMG9pQTJy?= =?utf-8?B?S2VKaVNES2NYbDZqVUZhT2lIcTAzTXRlL3JWOUpncHo0UmpWb1hENnRWMUNJ?= =?utf-8?B?SXFQckFlcGdGMGg1dXl4em5YNmhrS0NXY1pZdnJTUFdvMTBpbWs0VzE2QXVI?= =?utf-8?B?UEZEYVpXWkxRTzJTQUxQS0pYdUR6aGhUeTllRkFkdTRwQklRN0ZGNnV0eXNx?= =?utf-8?B?cFA0dURJQmFxTjFRRUNZWWp4ZlhSQXdFSyt6UTNLd3NHRzV6ZElkT3pFaEMy?= =?utf-8?B?dUp5WDE3L2orZGxDcExoOHljM3M2T2pTNDZ4dTd1Y0pidXNYbm03NWpYME1w?= =?utf-8?B?clFpSldrelN2cW1YYm5pS2J5RGVNMjBvMGZPMjBjaWlJYlVOS2lJb1AyRUY0?= =?utf-8?B?clV0TjJXMGEyMHpoZlFTNVo4bmxmUVBWS3ZxR1NIeVM2Vmt3SnBORnRpdDlS?= =?utf-8?B?Z3dEcHVrT3JvT0FkV2JCMEsrTlpHUzU5M1ZXTVpVQWVZY3loUHFVNlNxOUdz?= =?utf-8?B?a0tVc1R4SE9rK2UxNmlDbVRmUzlsbEZiTWRaNDRyRmRsRnpGZVp3V0dLOXc0?= =?utf-8?B?bzlieVV6VXRTRmdhcGFzYlZpNVdQb1pQbDd5UzI1UFlRelRzWnlranBlOXhN?= =?utf-8?B?NkhibUk4MWpzNmYxdSt1c2F4d1kraUFhSVJUSmc2aFpoVW1tQ2JVZllSdlh0?= =?utf-8?B?NjlpV1JFUlpzSkVybUJybWhESlFkZ3FRYTZWY1A1MEQ1YmpiMlBiR2dnaWQz?= =?utf-8?B?UGVyTkQ1T3BJaEtGZUhLalJTZEdxZ3hXZnk3bHM0Yng5WEk4aGVFbmxoTSsy?= =?utf-8?B?aEpGVmJPUUg0Y3F6S3k0aTMrK0ZuWG9oaVFQSmNCUmg4WFNRS0xYSTdmNW0y?= =?utf-8?B?VVE0a2hVY2kvYzlWSUZQczVOT01QbE9rTTM3OWFCV3dGWnYrYnZlV1ZYemJH?= =?utf-8?B?TUdERWlSR1UrdzJ2TzZRVjdWQk9TajVvbWdZTjNWcTNXZXk0MEpmaEgyUVNi?= =?utf-8?B?SXpIUTVGdFJHelBzM1lWVjBqVjJScE1EVzV3VDNndTNtVnhWVmFQZXh1Wnpq?= =?utf-8?B?Lzc5SDFkS3EzV2ZzNE83T1hESnUwUXZnZ3lkVUVndXNJRTZiZGxYc0E2dDhY?= =?utf-8?B?bDVjVVhYdXRCRm5tV3NCZz09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UysrRTZFL3ozeVl1b3hoOWplUkVkVmRhVXpqcnpwekNtbVdMNm05ajYyMWxI?= =?utf-8?B?SmtBbGl0dTNCUjJyTjFkZlhsZXVSTzZBN2xkQzJPS1lhenlYcnJYQmtlNW5U?= =?utf-8?B?QXR3TEpXaTAyOElGaW1rQkxIT0M3R0YydU14QnJMZHlIU0IvNDl6UzNnVkZ1?= =?utf-8?B?NlU3OWpMVkZHT3lkZ3lJTkhEd2VJZFNRbU9JdzVISWFvSzZNaStmMFh4Qlhi?= =?utf-8?B?Zk13cXg3Q2NuQVl6NHlVMW5kU3hTNVh0VW5rMmFNM0FtSU9HM2dlVFJOYUZl?= =?utf-8?B?c21BNElMUnJYMHgyTjg2RVFINTh4azdWL2ZOZDRqcWVVVFdsb2JFUTROMUdl?= =?utf-8?B?aUpGdkl3dHhwaXZSRXl0Z3E0UHNqTGpEcktvSzRTNVI0V3lyNEZ4Njl4Z1Q1?= =?utf-8?B?aEE5WkdmSFdWQk5NNHR1UUQxS0IwcnFtVWZ2YnZUYlNCSThCL01xNnBHRkJn?= =?utf-8?B?OCtONjJOOUhoNTl6Z0Q4MDI0S3loWkZ1RkcxMFZYQmY4SmEvOEhwcXRyZTY4?= =?utf-8?B?VC9xQ3FxY1pIR09pbVVialY0K2xodXRwM21XQ3IzMlBkbnR0Q3k2QUt5TnZo?= =?utf-8?B?dDg1KzFTQ0dTRXUzYkg2V3hvd0pOTlhnTnQ0Qnk2dXJpc2lDT0hMNHlMU3Nz?= =?utf-8?B?QjdvS1Raam5QNDBrQ1FoYkZmejhZOUtRUzFNd2ljMjdISzFwMW8xUE50ck5u?= =?utf-8?B?SjAybTQ5YWdLa09wY2VFcUZ3ZXhCL3NVQ2h2TnoyUEVROVZKUG9rc1lUOUpR?= =?utf-8?B?NGw3aUtUVzVibnJVdzIwbENFWk9TdjBKNkJkSWtveFNUY2JsTGwvNHNOYjU3?= =?utf-8?B?YVB3V0tIa0VtVkR1czVJcHlhWjZPWGw3RkZRZDJDYjdoLzF4aHA5bStUMmJl?= =?utf-8?B?bWRCVEdsbW5nSWlaejluSmR1clhlVXJYM1EyZHBQMDRsUnk0VXdscnJQa2xi?= =?utf-8?B?S3YvTjVSb1lqZFBzdDdhUlozbDQ5RzJiVU1NZk5YWTlTZmdJbE1LaVN1S3Fj?= =?utf-8?B?QjI3cEl5RHVJQ3d4dVIyU1lRNnErTEV5eGcxNk1Wd0VUMFRKY2dpNFk0Zm40?= =?utf-8?B?VmlKRDhRZGloZkpVbThKb2thUmJBbEJOK09aV0Z0Ty9GNUVGTUJIR1oydWhv?= =?utf-8?B?Qi9IOUMxS1pUaThzSW1WbkNHa0pDVXFpaG1vSVV3THd5azZ2cy9JL2hjMkVU?= =?utf-8?B?WUIzZEU2Zk5BbE1LaEhTcnd6RDVMdmcxV3Vad0ZzNVFRb0dEU0t3UVVmR25E?= =?utf-8?B?K2pieSt3dHhPYS9iNWVHZW9NclZwbDB4VXBGNHdMbURnZHkybGE2L2tnb0lL?= =?utf-8?B?RlkvVWd3dGloTmFXN1NvOWNDN2FaUm5nZnZtSzcvcW5VU0dSYnRxYWRrUzNm?= =?utf-8?B?dFhYdzhUMzdremR1MGhuSWxNNkU5cXNEM3ljUjhvVXFRTzMwV3dUcU9ySGRB?= =?utf-8?B?azRXSzhQd0tXMGVOeEFGZXI0Z1Nsc1FwanBDT3U1QlpCcTk2MDJFc3J1bGJT?= =?utf-8?B?eWRTcXZxbW01eDJzYXBWbE5MenlSOWVVV3d5YWhjL0xyaGt4aEV2NzA2MTlO?= =?utf-8?B?QzIzZ1oyYUw3MDFSQ3oyd2o5b1ZycDU0VVo3dFdIdTJlOWxHd2pwRXA0YVUr?= =?utf-8?B?MERGNDN6QWFHVzliQm4yMjFNcmpoMkhLK0lLenBrMy9CTWlMNFQzdWR6eXV3?= =?utf-8?B?K3hJQnh0NFNMSnl4eEw3b09EQnpENmJReUk3bmpjOWsyTFdjZWdLQ05lR1ZV?= =?utf-8?B?NW1tSml5WFY2aXJGdS91OVFZVGlCeUg4VWFYNUhPTlNWcmlmUVlITEhYNlBs?= =?utf-8?B?d1JLd0NtUFNDeDFUTi9Gbk14VGg2bGM4QnAzdnBSMlFpb2NBV2hwWHlIV25F?= =?utf-8?B?c1VKUW9IV3VRZWpqdEJwT0pMWGlyRG93VGh0VWlHd3hUSG5LUnNhYnlTOWVS?= =?utf-8?B?eWViY0VHcTRRd0tWU2NaNElyUzZkVVhHWHFnMVRPdExFRVpDbkxMQXVOQ1I0?= =?utf-8?B?NEpmNHdGZWx6bFBpMmdkejBmQ1R2NG55UGlUcktHSDZMZ1NZSmZRSEV1Rm9M?= =?utf-8?B?Um1rUEsvU1RWSGVNVkk4RkZIaTM2MTRhVXAzWTQ0Z1QyZWhYYjg1UUZmNVhi?= =?utf-8?Q?KyioWIB/AJ1QCQMJeAZucXgT0?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: f658c815-879f-4ea8-35ef-08dca832d87b X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2024 20:39:11.5296 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: R8T/YJvGZjFmS33NPY10KLau88weFnCVOzisxdm+mMWw69VeP3YrP7Sfc/cr5HUB X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8132 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/18/2024 8:35 PM, longli@linuxonhyperv.com wrote: > From: Stephen Hemminger > > The current code uses unnecessary locking to set VF MTU, resulting in > deadlock on hot add/remove path. Fix this by using rte_eth_dev_set_mtu() > to set VF MTU. > > Signed-off-by: Stephen Hemminger > > Fixes: 45c83603087e ("net/netvsc: support MTU set") > Cc: stable@dpdk.org > Signed-off-by: Long Li > --- > drivers/net/netvsc/hn_vf.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/netvsc/hn_vf.c b/drivers/net/netvsc/hn_vf.c > index 6b3d0eb0c8..b664beaa5d 100644 > --- a/drivers/net/netvsc/hn_vf.c > +++ b/drivers/net/netvsc/hn_vf.c > @@ -264,7 +264,7 @@ int hn_vf_add(struct rte_eth_dev *dev, struct hn_data *hv) > goto exit; > } > > - ret = hn_vf_mtu_set(dev, dev->data->mtu); > + ret = rte_eth_dev_set_mtu(port, dev->data->mtu); > As 'rte_eth_dev_set_mtu()' calls 'hn_vf_mtu_set()' in the call chain, won't it cause same problem? Does it help to make unlocked version of 'hn_vf_mtu_set()': ``` _hn_vf_mtu_set() // set mtu without lock hn_vf_mtu_set() lock() _hn_vf_mtu_set() unlock() ``` > if (ret) { > PMD_DRV_LOG(ERR, "Failed to set VF MTU"); > goto exit; > @@ -796,7 +796,7 @@ int hn_vf_mtu_set(struct rte_eth_dev *dev, uint16_t mtu) > rte_rwlock_read_lock(&hv->vf_lock); > vf_dev = hn_get_vf_dev(hv); > if (hv->vf_ctx.vf_vsc_switched && vf_dev) > - ret = vf_dev->dev_ops->mtu_set(vf_dev, mtu); > + ret = rte_eth_dev_set_mtu(vf_dev->data->port_id, mtu); > Won't this cause a cyclic call: rte_eth_dev_set_mtu() hn_dev_mtu_set() hn_vf_mtu_set() rte_eth_dev_set_mtu() > rte_rwlock_read_unlock(&hv->vf_lock); > > return ret;