From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48359A0C43; Fri, 22 Oct 2021 15:22:08 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF7C84114A; Fri, 22 Oct 2021 15:22:07 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id E127A41149 for ; Fri, 22 Oct 2021 15:22:05 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10144"; a="229570355" X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="229570355" Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2021 06:22:04 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,172,1631602800"; d="scan'208";a="484678314" Received: from fmsmsx605.amr.corp.intel.com ([10.18.126.85]) by orsmga007.jf.intel.com with ESMTP; 22 Oct 2021 06:22:04 -0700 Received: from fmsmsx607.amr.corp.intel.com (10.18.126.87) by fmsmsx605.amr.corp.intel.com (10.18.126.85) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 06:22:04 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx607.amr.corp.intel.com (10.18.126.87) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Fri, 22 Oct 2021 06:22:03 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Fri, 22 Oct 2021 06:22:03 -0700 Received: from NAM10-MW2-obe.outbound.protection.outlook.com (104.47.55.108) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Fri, 22 Oct 2021 06:22:00 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=lCkJBaDMAO1m6BQMdtQZjwN5pP93p0EOm+iroz+WRGjZUffsFXYOc2EJF1ZRcKCukvj2wHlL1FUihF2jDkdaEvBmZfLwKDCu4zHw8IRUVlZkcFLqcYiZq73fqyPf0jzWQCu5XFQjO8nq4IKHYljXF8n7VX3sq6ZUXsFhdXZc9jlw7GKfEr6UEpa1RDJss5KFfJDTINWvF22vjte98EsDttQXj7rsgxUZOAAIJ0tcsitm46cGSEsnYyKYJqnUFLDj6v8WRi5+iKK1LNqy0UX+AO3bGMVPapiZzH442rQyu1ZenpJQR4gb7uUYwIl6aEfCcFpB2Cpnrj+O7i4DY+KZQg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rXpy3YHcEFylpv6+0aFQRtyvR9TYMPXbA41IoL0BNZI=; b=LIGyZsmHc0lGDcUhL3mxRV8ribFATCzIMOZlIDFU4rPvCFYv7xMg9NiIPT/jzWtxAcQ8rOI4q8bwPt1eQOpM1KafmGVtCT7X7qn8abPAqKI0h3ZkbNTIpW82MkbsRe9A9+/bJq6C/ZNS9h2wgZw5p+ne66idE5M4lKQH0v//vY1X0Ycm40b2EF5kiuRP7xSJpZEeeDom9dvBihoSA4I/7697FFleRDrDy3OpaXaXPZ4JXkALjMsqhN7AMiOutXX5xBlwmlviZau6tqNqPThlvuvt6hIme26RIimfZ9qQx5zAwXORDy16Hf6vov0bIgexciM0ZRIkFfOJvA/tjPEbNg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rXpy3YHcEFylpv6+0aFQRtyvR9TYMPXbA41IoL0BNZI=; b=pqqrUH95fx9Wdrk1LrlMBJ38t1fewJvkH1hrqzZBfESJ7zEwYr9wXkwBfafmo2ZQ43kSPdfuqKq+gq6EFtv4kS8tWgqZtSpPl7B/8NfNLyoUgNrAAS9nma0UoIoP0h+rhbv+dwoKl/QRh1qpquAXy0wCstrQf0GkwXQmVGuvlko= Authentication-Results: oktetlabs.ru; dkim=none (message not signed) header.d=none;oktetlabs.ru; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (20.182.107.83) by PH0PR11MB4917.namprd11.prod.outlook.com (20.182.124.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.15; Fri, 22 Oct 2021 13:21:59 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4628.018; Fri, 22 Oct 2021 13:21:59 +0000 Message-ID: <9c354744-c1b3-5254-7b95-00c3d035dbb3@intel.com> Date: Fri, 22 Oct 2021 14:21:50 +0100 Content-Language: en-US To: Andrew Rybchenko , Thomas Monjalon , Ajit Khaparde , Huisong Li , Konstantin Ananyev , Rosen Xu CC: , Ivan Ilchenko References: <20211022101828.649441-1-andrew.rybchenko@oktetlabs.ru> From: Ferruh Yigit X-User: ferruhy In-Reply-To: <20211022101828.649441-1-andrew.rybchenko@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DU2PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:10:3b::19) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DU2PR04CA0014.eurprd04.prod.outlook.com (2603:10a6:10:3b::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4628.18 via Frontend Transport; Fri, 22 Oct 2021 13:21:57 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: e7e63cd6-7f0c-42d3-6c96-08d9955eed2a X-MS-TrafficTypeDiagnostic: PH0PR11MB4917: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:751; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: WAnvaNoX9uE6E6BmpftpScGqA7pJ1OppS/g8slXkNesmlEtR9FM9zr47OE4Sqq/4ZyJcuiC+wh5ZO9Bgf7k83skWtQdP0AP3NLIcvWSIvH7lOsiqGxyMLsAFWypKn72UEUZb642yDP2ip8pnuAA/5ommZwixDEE8TAugkPkVShN7q8wGRomWCPm1r/uQvidBJLtYlu+YXDqtQCf8rHMRdFxpq8DIl/SwFgjJbNI3Q7q2621mjrKK3+k0MG6cDK6XW07B9HImQGCI/6vNIdZuVolu8HylNia04ulz1byAz1ogzdWgTlbhzhcqiQYB2Fzw8adTZNHD/BiH0eTT9YLShaRUfOsLEfQXOtuTe8aJ6ASHP6tBvz6qzXCKtDlxZJ2jFG8s8Ldnv5uemQTw9ITJrMr3XedETG1xYTsrbV7gY2rLlT/0P5+PnTDMZIRAOYioKhch0x/1J6ReQS+uOlAz4CaRuWnK4ACvzQdDnZ4WmeH/5E0ZV+uA0DQEyiI+eN5z/e+4imSR/+jKO7QFRW7E+NEU1AxN2ntCihJu6Yr7Gk9oTVWRfz2FlUnzLf3pRJx9Im64ZmJFADUt5NkYByyy7jqBGdZ3oiqktIuF4Ud2q7Q9uoMuWpE+Ey3hReCeBETSOs1GhbK95F9s5Mf1a7CTjKjoJeIUqslycK3LrtHYDWVQSXwcpiuRED1CshVCegoEYIL83gtB7ss5S2qGL1X9yA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(2906002)(6486002)(8676002)(38100700002)(66946007)(66556008)(66476007)(86362001)(6666004)(82960400001)(4744005)(4326008)(53546011)(186003)(26005)(316002)(2616005)(956004)(36756003)(5660300002)(16576012)(110136005)(6636002)(44832011)(31686004)(31696002)(508600001)(8936002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TVUrYnpNS0M2dXNCdFArWVlCeGQ4MDBIY3NMU2x2eVZBSW1TTXU0bVFuUDZG?= =?utf-8?B?SnBUNFVFallHRHozenhjRFV3L1lNV1FZU3BmVFdqVGVKbDVDYzl3eFlUd2c0?= =?utf-8?B?VEdCaVdaR1NucEhNbWxMQjU0akNMdW1vK3R0R2ZReTAwOEw0ams1bm9ocFk1?= =?utf-8?B?cDFITmZiSHI5T1RqSWtadDZHa3gzSEhJOXhCeVo1ZEpwVkJXU3JhbG5Iblpk?= =?utf-8?B?RzNHcXFCSFRpdjFUdDVnMWNaaE5GdEg2WG0zbVZWeW5vcUVaUDMrWlViemJq?= =?utf-8?B?SXMxNG9MT3R3WGM4S0RwQzBiTTJIbHNzWFExckpNWWd4RjBON3FhckUrRVdM?= =?utf-8?B?WkxiRjFBRDFSUTh2TXFmYjZ5RjR5aGRYOGFkY2EwaFJPVGh5N3Nac2hqb0Ey?= =?utf-8?B?US9Gc0UvY2Z4Ti8vdnNBSWh5bTJkT0ZJMzlRYWFvODhsMUUvZHhjYUJWK2p3?= =?utf-8?B?RkR1aFg5b2lvN3ZnaFQ3UkZzYUNYc3EyTzAvd0R0Qk9Tdlo0UVp0RjQ0SFA5?= =?utf-8?B?dlZGdkF0dkdIN05jQWdhOXllY0RmbHJRZWRwSXdXdFhkRkZRUnp3aHFneGZ3?= =?utf-8?B?KzExV1g2UXlCVWNnVUtXYkZwMkl4b0psczdXdm9TZ0NJMjdyMklrM3MxckJS?= =?utf-8?B?UlI5L01zejJaNElrV3YrVnFxZHNoU3JaYm5GZGUva2xReThWaHBad0ZTZSs0?= =?utf-8?B?ZkhVdGo0Z0NLUXNSWUZSck42YjFFOUIyWUdpWmhRc0tKdlhGdVk4ZnlGYkJX?= =?utf-8?B?dUlXS0syVk96VGF0Rnd5cFRMMHN3eG1jSlpKdTl1cm56bHViQUZPbTFDM1lR?= =?utf-8?B?VHl2OVZHQ1pJQ2xiNzF1S3NIOWw5bUhqOHFwbzFhY29jdXFWODZrR3ZYSDFp?= =?utf-8?B?eWlEeEtTV2JlZjFFNHFsNG83a1hTaloxMnR6TDRROTZJV21LR0dFMHI4WDAy?= =?utf-8?B?UzdLK0NqOHR0Skt3eDVxYTRTQWtHUVNMY3p2eW8vaVlzWFdkY3oxV09tbWl5?= =?utf-8?B?bmhjd3NYd0drNTdaV3BJSFN3SlU4SkRvc2JaUjRYQ0RpVGd0ejdudkU1Zmh5?= =?utf-8?B?RVQ4VC95ekZ2Qlhwbm1pb29QVTNRUERweG9ObDQ0bVI3S3AzaFRmNkE5QTBY?= =?utf-8?B?eEpYdi9jclNubC9kUlpUREJQa2Fsc08zQ2tKcGJjSXRVU0V3K1JRZm8yc3E1?= =?utf-8?B?d21pcUJqUXRIOEZoMlh0cm9YLzNzK0d3Sk1ncUdVK28zOU9ucE5Kam5kbmVB?= =?utf-8?B?VUpuUS9CeVVuMElpMTdTeDgyeERNaXY1SUxxeEVLUXdIdmhlVUIvYlV3MUF1?= =?utf-8?B?V2VMNG9QTDAvdXl6dUVVbGdaRVc2dU1NcXdZY003UTdjTDZJY2ZDdnczQ2hj?= =?utf-8?B?cFpxK0VLcEdLek5Nb0t0VXBCSkFneWhwSUlHZHE0RUlsMStkR0tNMHd2R2M2?= =?utf-8?B?cUUrVy9HMkVIZndBaEZPcXIzeUM2MHgzTmZoeUgxdHkzZ0JyTmxMUjkxd3RT?= =?utf-8?B?MEpWWlVUQmk3bXlWMlVHT0ZDcG4vaXpvUGVISFhqUmU0aUtmRk9NVGtoYm1p?= =?utf-8?B?MzdCR3ZDWi9oR2pBUUJFUEJFaGdQOGVuaC9xNTNlVXhNZjlGQ21OcUh5bXRh?= =?utf-8?B?RW5sZmlsb0x0TGFqSWFPWm9Jb3Fhc0tHQy9mcS9ueXYyL3RHNitqWER5aDVO?= =?utf-8?B?bXpqdFNoeThDbllKVzZsK1VoSzVUWnJ4S1JlNk00cFU5U0ZRMXkvQlpsZ3JZ?= =?utf-8?B?bmpVdEkzMm4rdVJCKzRiVER0SlpWcEhZcWpsWklZaURZQXFzUTRoUCtJa0FX?= =?utf-8?B?bFhMdEZxYS9OK0VJamsrUVdaWDd6enJHMWJuV2poRjhGcHgzZTZ5cE5xdjhI?= =?utf-8?B?cS9Ddis3b0kvMmtxb1NEK0JnblhwN0c0Zkp2c2VaUGlNeEtlcWpGMi9taWM2?= =?utf-8?Q?PQRzMEGrG3FAnP9r16SYeu5V79AvcK/M?= X-MS-Exchange-CrossTenant-Network-Message-Id: e7e63cd6-7f0c-42d3-6c96-08d9955eed2a X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Oct 2021 13:21:59.0639 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: ferruh.yigit@intel.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4917 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH] ethdev: forbid MTU set before device configure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/22/2021 11:18 AM, Andrew Rybchenko wrote: > From: Ivan Ilchenko > > rte_eth_dev_configure() always sets MTU to either dev_conf.rxmode.mtu > or RTE_ETHER_MTU if application doesn't provide the value. > So, there is no point to allow rte_eth_dev_set_mtu() before since > set value will be overwritten on configure anyway. > > Fixes: 1bb4a528c41f ("ethdev: fix max Rx packet length") > > Signed-off-by: Ivan Ilchenko > Signed-off-by: Andrew Rybchenko Reviewed-by: Ferruh Yigit