From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by dpdk.org (Postfix) with ESMTP id EEA49591E
 for <dev@dpdk.org>; Tue,  3 Jan 2017 16:04:27 +0100 (CET)
Received: from orsmga001.jf.intel.com ([10.7.209.18])
 by orsmga105.jf.intel.com with ESMTP; 03 Jan 2017 07:04:26 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,455,1477983600"; d="scan'208";a="1078729292"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga001.jf.intel.com with ESMTP; 03 Jan 2017 07:04:25 -0800
To: Qiming Yang <qiming.yang@intel.com>, dev@dpdk.org,
 thomas.monjalon@6wind.com
References: <1481008582-69416-1-git-send-email-qiming.yang@intel.com>
 <1482841816-54143-1-git-send-email-qiming.yang@intel.com>
 <1482841816-54143-4-git-send-email-qiming.yang@intel.com>
Cc: remy.horton@intel.com
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9c401d90-0264-8fc8-3733-abb59bfd277e@intel.com>
Date: Tue, 3 Jan 2017 15:04:25 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.5.1
MIME-Version: 1.0
In-Reply-To: <1482841816-54143-4-git-send-email-qiming.yang@intel.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 3/4] net/ixgbe: add firmware version get
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 03 Jan 2017 15:04:28 -0000

On 12/27/2016 12:30 PM, Qiming Yang wrote:
> This patch add a new function ixgbe_fw_version_get.
> 
> Signed-off-by: Qiming Yang <qiming.yang@intel.com>

<...>

>  
>  static void
> +ixgbe_fw_version_get(struct rte_eth_dev *dev, __rte_unused u32 *fw_major,
> +	__rte_unused u32 *fw_minor, __rte_unused u32 *fw_patch, u32 *etrack_id)

This API at least provide major and minor fw versions I think. Isn't
there any kind of FW version information for ixgbe? Just providing
etrack_id is not looking good.

> +{
> +	struct ixgbe_hw *hw = IXGBE_DEV_PRIVATE_TO_HW(dev->data->dev_private);
> +	u16 eeprom_verh, eeprom_verl;
> +
> +	ixgbe_read_eeprom(hw, 0x2e, &eeprom_verh);
> +	ixgbe_read_eeprom(hw, 0x2d, &eeprom_verl);
> +
> +	*etrack_id = (eeprom_verh << 16) | eeprom_verl;
> +}
> +
> +static void
>  ixgbe_dev_info_get(struct rte_eth_dev *dev, struct rte_eth_dev_info *dev_info)
>  {
>  	struct rte_pci_device *pci_dev = IXGBE_DEV_TO_PCI(dev);
>