From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 2E48AA05A1;
	Wed, 22 Apr 2020 04:07:25 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 2BCB51D417;
	Wed, 22 Apr 2020 04:07:24 +0200 (CEST)
Received: from mga01.intel.com (mga01.intel.com [192.55.52.88])
 by dpdk.org (Postfix) with ESMTP id 2C42C1D40B
 for <dev@dpdk.org>; Wed, 22 Apr 2020 04:07:21 +0200 (CEST)
IronPort-SDR: YO7ilLnMg4czVdNP64BTs/GV8TM1n7XB17oaZ65Fj9Aolbs/ggqKnJPJnrlJIvulpI805MEffu
 69gCGVaS4h0g==
X-Amp-Result: SKIPPED(no attachment in message)
X-Amp-File-Uploaded: False
Received: from orsmga006.jf.intel.com ([10.7.209.51])
 by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 21 Apr 2020 19:07:21 -0700
IronPort-SDR: /1DFu3IqNXMfS99uzP4cSisfOxCI+/I5xPBMC+BoSzJLbSc34wywjw3gIrfpo7doACvNgKyOGC
 cMY9F55T17gQ==
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.72,412,1580803200"; d="scan'208";a="258906793"
Received: from rmenon-mobl.amr.corp.intel.com (HELO [10.251.1.78])
 ([10.251.1.78])
 by orsmga006.jf.intel.com with ESMTP; 21 Apr 2020 19:07:20 -0700
To: Dmitry Kozlyuk <dmitry.kozliuk@gmail.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Dmitry Malloy (MESHCHANINOV)" <dmitrym@microsoft.com>,
 Narcisa Ana Maria Vasile <Narcisa.Vasile@microsoft.com>,
 Fady Bader <fady@mellanox.com>, Tal Shnaiderman <talshn@mellanox.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 "Burakov, Anatoly" <anatoly.burakov@intel.com>,
 Harini Ramakrishnan <harini.ramakrishnan@microsoft.com>,
 Omar Cardona <ocardona@microsoft.com>,
 "Kadam, Pallavi" <pallavi.kadam@intel.com>
References: <20200410164342.1194634-1-dmitry.kozliuk@gmail.com>
 <20200414194426.1640704-1-dmitry.kozliuk@gmail.com>
 <20200414194426.1640704-7-dmitry.kozliuk@gmail.com>
From: Ranjit Menon <ranjit.menon@intel.com>
Message-ID: <9c5212ba-57be-7d21-9541-171f61f97f95@intel.com>
Date: Tue, 21 Apr 2020 19:07:20 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101
 Thunderbird/68.7.0
MIME-Version: 1.0
In-Reply-To: <20200414194426.1640704-7-dmitry.kozliuk@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v3 06/10] eal: introduce memory management
	wrappers
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

<Snip!>

On 4/14/2020 12:44 PM, Dmitry Kozlyuk wrote:
> diff --git a/lib/librte_eal/windows/eal_memory.c b/lib/librte_eal/windows/eal_memory.c
> new file mode 100644
> index 000000000..5697187ce
> --- /dev/null
> +++ b/lib/librte_eal/windows/eal_memory.c
> @@ -0,0 +1,437 @@

<Snip!>

> +
> +	if ((flags & EAL_RESERVE_EXACT_ADDRESS) && (virt != requested_addr)) {
> +		if (!VirtualFree(virt, 0, MEM_RELEASE))

Microsoft documentation suggests that we use VirtualFreeEx() to free 
memory allocated by VirtualAlloc2(). VirtualFreeEx() would require the 
handle to the current process that was passed into VirtualAlloc2()

There are 6 other such occurrences in this file.

ranjit m.