From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)"
<jgrajcia@cisco.com>,
Stephen Hemminger <stephen@networkplumber.org>,
"dev@dpdk.org" <dev@dpdk.org>
Subject: Re: [dpdk-dev] [RFC v3] net/memif: allow for full key size in socket name
Date: Fri, 13 Sep 2019 19:47:21 +0100 [thread overview]
Message-ID: <9c577458-7410-71d2-2a67-e28fcefecf62@intel.com> (raw)
In-Reply-To: <55a3d547efc04ad48ea416aae76cf0e0@XCH-ALN-004.cisco.com>
On 8/30/2019 8:17 AM, Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at
Cisco) wrote:
>
>
>> -----Original Message-----
>> From: Stephen Hemminger <stephen@networkplumber.org>
>> Sent: Tuesday, July 16, 2019 7:21 PM
>> To: dev@dpdk.org; Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at
>> Cisco) <jgrajcia@cisco.com>
>> Cc: Stephen Hemminger <stephen@networkplumber.org>
>> Subject: [RFC v3] net/memif: allow for full key size in socket name
>>
>> The key size for memif is 256 but the unix domain socket structure has
>> space for 100 bytes. Change it to use a larger buffer and not hard
>> code the keysize everywhere.
>>
>> Not sure what purpose of socket is anyway since there is no code
>> which connects to it in the current tree anyway?
>
> See memif_connect_slave in memif_socket.c
>
>>
>> Still an RFC, have no way to test.
>>
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Tested-by: Jakub Grajciar <jgrajcia@cisco.com>
>
Applied to dpdk-next-net/master, thanks.
next prev parent reply other threads:[~2019-09-13 18:47 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-08 16:06 [dpdk-dev] [RFC] " Stephen Hemminger
2019-07-16 17:18 ` [dpdk-dev] [RFC v2] " Stephen Hemminger
2019-07-16 17:20 ` [dpdk-dev] [RFC v3] " Stephen Hemminger
2019-08-30 7:17 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-09-13 18:47 ` Ferruh Yigit [this message]
2019-10-04 12:41 ` Yigit, Ferruh
2019-10-07 9:01 ` Jakub Grajciar -X (jgrajcia - PANTHEON TECHNOLOGIES at Cisco)
2019-10-07 15:21 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9c577458-7410-71d2-2a67-e28fcefecf62@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).