From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC05EA0A02; Thu, 25 Mar 2021 16:44:04 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 41C6F140E43; Thu, 25 Mar 2021 16:44:04 +0100 (CET) Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by mails.dpdk.org (Postfix) with ESMTP id 8BF8E140DF7 for ; Thu, 25 Mar 2021 16:44:02 +0100 (CET) IronPort-SDR: w0WQtwB6t3KAdBqKt7F90MOqxPyBbvrdMb/PV5KNlfpqylLyIv1/l4S/MYgwsaU4Xwr8wdcEEm 6SFmnPMb/WrA== X-IronPort-AV: E=McAfee;i="6000,8403,9934"; a="254953040" X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="254953040" Received: from orsmga002.jf.intel.com ([10.7.209.21]) by orsmga105.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:44:01 -0700 IronPort-SDR: JRyLQCYa+FeqxCNvz8jZZRXWoyDQkYqCWPZcFbmfqpjyNeG8A0joBjmmI/Lvlhm7O2lzzbYsoe VH9XiEplEYyQ== X-IronPort-AV: E=Sophos;i="5.81,277,1610438400"; d="scan'208";a="391782108" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.15.136]) ([10.252.15.136]) by orsmga002-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 25 Mar 2021 08:43:58 -0700 To: David Marchand Cc: Qi Zhang , dev , Thomas Monjalon , Bruce Richardson , Xiao Wang , Jingjing Wu , Beilei Xing , Jeff Guo , Qiming Yang , "Wang, Haiyue" , "Chen, Zhaoyan" , Aaron Conole References: <20210310121626.2019863-1-qi.z.zhang@intel.com> <20210323110749.2306452-1-qi.z.zhang@intel.com> <20210323110749.2306452-9-qi.z.zhang@intel.com> <536d43c2-bb7b-7a0e-1ea7-a1fa4c4d7422@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9c61411a-7088-45fd-7085-e6fe1f8b4af1@intel.com> Date: Thu, 25 Mar 2021 15:43:54 +0000 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 8/8] net/igc: refine debug build option X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 3/24/2021 8:31 PM, David Marchand wrote: > On Wed, Mar 24, 2021 at 8:27 PM Ferruh Yigit wrote: >> >> On 3/23/2021 11:07 AM, Qi Zhang wrote: >>> 1. replace RTE_LIBRTE_IGC_DEBUG_RX with RTE_ETHDEV_DEBUG_RX. >>> 2. replace RTE_LIBRTE_IGC_DEBUG_TX whth RTE_ETHDEV_DEBUG_TX. >>> 3. merge RTE_LIBRTE_ETHDEV_DEBUG into RTE_ETHDEV_DEBUG_TX >>> >>> Signed-off-by: Qi Zhang >> >> CI is reporting a build error [1], I don't reproduce the error and I assume it >> is false positive but can you please check it? >> >> Also cc'ed Zhaoyan & Aaron for the possible CI issue. >> >> [1] >> http://mails.dpdk.org/archives/test-report/2021-March/184153.html >> > > Not sure what gcc+debug target is, but I guess it passes the old config item. > The compat stuff should be placed in rte_config.h (or something > similar to config/rte_compatibility_defines.h) and not in > lib/librte_ethdev/rte_ethdev.h. > > To reproduce: > $ meson configure $HOME/builds/build-gcc-static/ > -Dc_args="-DRTE_LIBRTE_ETHDEV_DEBUG=1" > $ ./devtools/test-meson-builds.sh Thanks for the steps, I can reproduce it. The alias is not working because 'rte_ethdev.h' where the alias is defined is not included in this path. Following update should fix it, what do you think? diff --git a/drivers/net/e1000/base/meson.build b/drivers/net/e1000/base/meson.build index d13f693d3eb8..a9f92cbc4770 100644 --- a/drivers/net/e1000/base/meson.build +++ b/drivers/net/e1000/base/meson.build @@ -33,6 +33,6 @@ foreach flag: error_cflags endforeach base_lib = static_library('e1000_base', sources, - dependencies: static_rte_eal, + dependencies: [static_rte_eal,static_rte_ethdev], c_args: c_args) base_objs = base_lib.extract_all_objects() diff --git a/drivers/net/e1000/e1000_logs.h b/drivers/net/e1000/e1000_logs.h index 86f546b0f9ed..210c3447c66c 100644 --- a/drivers/net/e1000/e1000_logs.h +++ b/drivers/net/e1000/e1000_logs.h @@ -7,6 +7,9 @@ #include +/* included because of RTE_LIBRTE_ETHDEV_DEBUG alias */ +#include + extern int e1000_logtype_init; #define PMD_INIT_LOG(level, fmt, args...) \