From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DDC4AA0C41; Wed, 15 Sep 2021 18:55:11 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFFC54068F; Wed, 15 Sep 2021 18:55:11 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id B67964014F for ; Wed, 15 Sep 2021 18:55:10 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10108"; a="222038826" X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="222038826" Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 15 Sep 2021 09:54:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.85,295,1624345200"; d="scan'208";a="434205427" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga003.jf.intel.com with ESMTP; 15 Sep 2021 09:54:49 -0700 Received: from fmsmsx612.amr.corp.intel.com (10.18.126.92) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:54:48 -0700 Received: from fmsmsx601.amr.corp.intel.com (10.18.126.81) by fmsmsx612.amr.corp.intel.com (10.18.126.92) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 15 Sep 2021 09:54:48 -0700 Received: from fmsedg601.ED.cps.intel.com (10.1.192.135) by fmsmsx601.amr.corp.intel.com (10.18.126.81) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 15 Sep 2021 09:54:48 -0700 Received: from NAM04-DM6-obe.outbound.protection.outlook.com (104.47.73.43) by edgegateway.intel.com (192.55.55.70) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 15 Sep 2021 09:54:48 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=PPEpfzXj3exjtPiqpnXdck1f6gUGV962Idw1omb70iUEpBFwSvylD1H1OisJUUMEEHKiWbL5kXNSMXnhpIT1P1hzh+7WKNtNmNy4tlkVVPIZx4DHfU1W1CWsmxjUyv8Z6CnJpZ4cJ9qkbhBbgcQpzvk9NQcPuN0ooCYPojW+qJKU0FDLA1jQdwaATYcw4gziu5iLnIt2Ku+PmiWZsYv9UilVo4OSfg3/FLbkfIEAYZevIDy84d0D+mQj7zb8x/Wfabw5OIDFeMs0T1B9+8SKVUPPWSxuQdyb0ogLFhpdDUOyupW5HWKRe+XkJ4wGUI83sznUAt0R2XuaQbCtDUZvtQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=HqJHKTa9LqpIdHNYep1YKR4qcuJ6t5Y6ox1+o11uOg0=; b=nfEuzGUC2EaUuZL8bPTnHTnHLP/JNbO7vY7SnSAihZd3X1+qUYbP8wQbwXsv2nLu2ogUQx/DiRtIrKl53GYzunbCjEdmbtoM7oFZ0yA0dyg55epkFqNenMXOK7JVWpwLlntmBjfI38B11yO/rBKOenvGYGhKowCcUGRexj/kzVufPzb8XQ55J0wy9+w1/py3mnPZE7cOVXO1IHrUHs+HtcTQ64fgP5yJeCzhlKbH1pdhTKhUh9QL2xUtDfV41ElEXkLjct9MiRDgPr61nVzU2kv4lJVvHluuMnLGslvldigElPPxEhwQX44u41f5kzgktYowkTo5U61+MusRAppckw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=HqJHKTa9LqpIdHNYep1YKR4qcuJ6t5Y6ox1+o11uOg0=; b=A+gNvXNuoZ3VICypyJgR7WcaBlDux+iyukx3rjARceNeWdLixN4XS6RtNa4U6Ljg+W60govpNMvvaE9UIqwD10/xidlo9E9OjuCnLYamIzMIzHjYyyKN9qY1SWwxL6T/g0gn2+XCImdKMpQR4Wf7YVSawevnFuzbgMtKlKMnS98= Authentication-Results: dpdk.org; dkim=none (message not signed) header.d=none;dpdk.org; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4902.namprd11.prod.outlook.com (2603:10b6:510:37::5) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14; Wed, 15 Sep 2021 16:54:45 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::747b:3a08:d1ec:31fc%5]) with mapi id 15.20.4500.019; Wed, 15 Sep 2021 16:54:45 +0000 To: Jiawen Wu , References: <20210908083758.312055-1-jiawenwu@trustnetic.com> <20210908083758.312055-17-jiawenwu@trustnetic.com> From: Ferruh Yigit X-User: ferruhy Message-ID: <9c73703f-2052-492c-338f-8e72a5a4d171@intel.com> Date: Wed, 15 Sep 2021 17:54:40 +0100 In-Reply-To: <20210908083758.312055-17-jiawenwu@trustnetic.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DB9PR01CA0025.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::30) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by DB9PR01CA0025.eurprd01.prod.exchangelabs.com (2603:10a6:10:1d8::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4523.14 via Frontend Transport; Wed, 15 Sep 2021 16:54:44 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: f62b5bd1-db00-4bdf-0d30-08d978698560 X-MS-TrafficTypeDiagnostic: PH0PR11MB4902: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:451; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: C9par2YwDrJ8lHG+WoWacseDINWxQfN+ubGBPXhuOXc/hgvFbl7pmgghcRO0b5qaxgfkHB6Hh03700I29sqIF9r+QiZrMzM0dK6cdAV4Wm2FhTQMtO/sGFQ5IoBF05qSuLzXZyXZnctbVX2AXDoyT1TQvulr7CSW5ZY15H2TRvdULNLskplXwYW9X3cvdOJOOUSCw//c7LGrnEFsv0wS+U9De/CafB8JDIT6A5dpQ+60l8N+ntAFUvQLDPgG8lY0jYW+s8Yi/4icyeWPRDQUo1MltTtGQQMpdC3B6AMinkBVrSlowR8HiZuQE7mRUd8xaDs/YPywuZAGfysqaxzg4Qqch+UVj+GSI+DORlONvRcvjMoIrx8XWabvBXDqQ7WBSUAYzDevmGxn+4hEYNLTwrZQgOZ6MNyucQoZoOUSuPOOENlB8UX0odqxCROLQnrTKRgZ2/z0EEfjCAy2qqL022ZMn83tLdAWxXiXtkwAZsLVopGGsYz4u8iV+FY71XylbP8OQgWqPLIRIWtsYesLQq3eRm5YKh1CtEoItR8MpXQ4Kl620/3ydhJ8KmM8+EqGkqDV/fs92e2Lsgut47dbD7V7kA+tbrDhAz71CHMiFRkBb3Sx1jOWjHW1RTpkHHsXyEaNrkogcdMXOwg02cOM+w== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(376002)(136003)(39860400002)(396003)(366004)(346002)(4744005)(6486002)(66556008)(66946007)(2906002)(6666004)(66476007)(8936002)(38100700002)(44832011)(53546011)(956004)(2616005)(8676002)(26005)(186003)(36756003)(316002)(16576012)(31686004)(86362001)(5660300002)(478600001)(31696002); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?aHVTamFhcVEzRXBSL2R6WDBTN2ZhbWtPUVBSN0loZmdacXBJMVZhOG1FbVFk?= =?utf-8?B?cGJFZVFERlV6ZkptdWY1SnZmMjd0ZFlmOUFUVlB4WDdxd2t0MlhuTzVUYURQ?= =?utf-8?B?My9KRWxrejN3VFAwZHVRS29scjFkRlZBdjlyaEdmZllpbnd5VFAxcWZoTm5Q?= =?utf-8?B?SjROWXBpMFJQdVFRZjZvTk1NWmVleFhuQ1g5QnBBbkFnOFlGbk5ZMlZLNW8w?= =?utf-8?B?TGhLZHNNaWFpZ0dzU3dMb3NqS3d6a0tSQVlkMFZOVk4zNTZiTi9LVHl4SHJX?= =?utf-8?B?R0VUbElVNVF6UDJtakh0U0U2cUJzdmpOcUgzVnVqNTl3WE1ON3BGMnFvMXp1?= =?utf-8?B?K1Q0Lzd1VG5nRENsclVrcllxRjZ1K2xlNUR2enNrd1lSR0VEUHlOdCtCU1Q4?= =?utf-8?B?cG1Cc1ExTlFYQmNHUUFyUnpsUkRrYjI3TTNoSFJJb2VGeDBhUXg0VCtWcjJH?= =?utf-8?B?RGFhcHFnWUdkcCs4ODhGQ1BnZVM3UkIybjExc0ttdmJpNjNQaWw2biszRU5J?= =?utf-8?B?ckFMK0NmdW40Sk9UTCs4cXY2UkUwN3YvTUg5T2tlTnJpemora1h4VEtxTFAx?= =?utf-8?B?dEI2MXMxc2llMWt4Vm9ReXhRVHRJdytRWkdCUngydFB6bVN4TzNrdHJ6UnpJ?= =?utf-8?B?ZG1kVEI0ekcxTjkrZDNRRGF3VmJkaXJPUnFFWE16SFBFcks5ak43MUlUb0ZU?= =?utf-8?B?R3hYNkF5SVg0NG5MUlR5MG1oallJeXpHTTNFWEduR285b2hVby9aaHBGUVJJ?= =?utf-8?B?dVBmYmYydjc1ZVdFTDltWmJzTUFjb0NGU1pkRDIyOWhzQnNsc3A5cTNQWUhM?= =?utf-8?B?bTFQbENpcjllNXozeTNzOWtxNVd5bGJLM3ZMcTc1N3luN0l4enc2eFZkQkxH?= =?utf-8?B?K0x4dkxBUUlpQlZ1L2VZaDQzN1d6MnNEV0xEZ0FJQS9FcHFqSTZOUWV6b3Rw?= =?utf-8?B?Q2hpS0l2Q0RXN2w3eG1iQ05kdDNuQ1JlcXZ0a0xCUnJOdmZXQTFiVTdFME03?= =?utf-8?B?dFFFQXF2aEV1TVo2aUhibEhCTnJPWmNaS2p6dnNEMThmNmFiZHU2QWdwRkFt?= =?utf-8?B?WlRJRHFkdkZFdlE5TFZ3VVAyUWdFMUdJbjFLTnBQRm9qVmRvTHlSV0Urc3M4?= =?utf-8?B?U0NHbjlKRlhCWEhWWFpSbWZYTnpOM01zRGVuZFVldFFBcjdYNk1zRm9vbXVL?= =?utf-8?B?OUhjWmF1REZMQll6Yk9xMWxiRkozSlNQaSsveE51dlZuRUNBZHIwU3BkOEhW?= =?utf-8?B?d1JnRys0TWpJWTE1cGpldi9QNlE4RUp0TlhXTTVaTlpWdlZYNDFUZVkrcjVq?= =?utf-8?B?WGpjcFVOT0krNkpvV3ZGdU9FTTRnVklJZTZjd0FEQmhWbGhFVU43WHNQaDlL?= =?utf-8?B?UXl2cFBhTVk3Z2E2MDBtbGRGNHdyUEtEcVlnTlBOdnBDWWJCVlE0YTlOenFV?= =?utf-8?B?RjQ3RmVmdHp6OWIvaU9aWHdtdzhpeFA3eTJPUTlweTQ4cnhJeTNYQ1hZN3Br?= =?utf-8?B?enM4RWx6OHVZOEd2WFpwZmU1OEZIV2xoeE9MeTlONUE2dXBMM3BSVGprRkJF?= =?utf-8?B?aElhdTRsejk4WDhLREMwL3B0SEg4TDBXSHh1SFFHK3BaczRYRjRmenNpQ2dx?= =?utf-8?B?VGpTRW9ONDNXUGJadTNYdTRDcnhnT1BmbWZRakMyNnhTUWdNTUZ0ZVJWVFcy?= =?utf-8?B?anBkcFdwWUozVm1kQWpKY05ESkg1b2w4UHdidWxVT0tVbTh6M3hXeXNtcHVo?= =?utf-8?Q?NjNn7IIBToZwclg2F/YlRJXPwzV3G6Irrll8+Qc?= X-MS-Exchange-CrossTenant-Network-Message-Id: f62b5bd1-db00-4bdf-0d30-08d978698560 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Sep 2021 16:54:45.5683 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: V0iOHA+lCpf2RZijOqn2EIInh6OdZt8nJ6Am65/l2bOEDAIMCN6ZTJcU8wf6ivqtE01RBgiTNOJfUsiHAs3V/w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4902 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH 16/32] net/ngbe: support VLAN filter X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/8/2021 9:37 AM, Jiawen Wu wrote: > Support to filter of a VLAN tag identifier. > > Signed-off-by: Jiawen Wu <...> > @@ -2411,7 +2536,10 @@ static const struct eth_dev_ops ngbe_eth_dev_ops = { > .queue_stats_mapping_set = ngbe_dev_queue_stats_mapping_set, > .fw_version_get = ngbe_fw_version_get, > .mtu_set = ngbe_dev_mtu_set, > + .vlan_filter_set = ngbe_vlan_filter_set, > + .vlan_tpid_set = ngbe_vlan_tpid_set, > .vlan_offload_set = ngbe_vlan_offload_set, > + .vlan_strip_queue_set = ngbe_vlan_strip_queue_set, Since this enable/disables VLAN strip per queue, does the feature fits better to patch 7/32 which enable/disables VLAN filter?