From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) by dpdk.org (Postfix) with ESMTP id 2F991325F for ; Tue, 9 Jan 2018 21:17:13 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga008.jf.intel.com ([10.7.209.65]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 09 Jan 2018 12:17:12 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.46,336,1511856000"; d="scan'208";a="9447645" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.48]) ([10.237.220.48]) by orsmga008.jf.intel.com with ESMTP; 09 Jan 2018 12:17:12 -0800 To: Ravi Kumar , dev@dpdk.org References: <1512047472-118050-1-git-send-email-Ravi1.kumar@amd.com> <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com> From: Ferruh Yigit Message-ID: <9c8d5f85-387f-7669-e703-26e416b429cc@intel.com> Date: Tue, 9 Jan 2018 20:17:11 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <1515145938-97474-1-git-send-email-Ravi1.kumar@amd.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v2 01/16] net/axgbe: add minimal dev init and uninit support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 09 Jan 2018 20:17:14 -0000 On 1/5/2018 9:52 AM, Ravi Kumar wrote: > Signed-off-by: Ravi Kumar lgtm except below comments. At least share build error needs a new version of the patch. Can you able to complete licensing updates for next version? <...> > @@ -445,6 +445,12 @@ CONFIG_RTE_LIBRTE_AVP_DEBUG_DRIVER=y > CONFIG_RTE_LIBRTE_AVP_DEBUG_BUFFERS=n > > # > +# Compile AMD PMD > +# > +CONFIG_RTE_LIBRTE_AXGBE_PMD=n Why disabled by default? > +CONFIG_RTE_LIBRTE_AXGBE_DEBUG_INIT=n As far as I can see dynamic logging implemented, is this config option still needed? If you will remove this please remember to clean up the documentation too. <...> > +include $(RTE_SDK)/mk/rte.vars.mk > + > +# > +# library name > +# > +LIB = librte_pmd_axgbe.a > + > +CFLAGS += -O3 > +CFLAGS += $(WERROR_FLAGS) > + > +EXPORT_MAP := rte_pmd_axgbe_version.map > + > +LIBABIVER := 1 > + Need to add dependent libraries [1] or causing a build error for shared library build [2]. [1] Something like: LDLIBS += -lrte_eal -lrte_mbuf -lrte_mempool -lrte_ring LDLIBS += -lrte_ethdev -lrte_net -lrte_kvargs LDLIBS += -lrte_bus_pc [2] build error: .../drivers/net/axgbe/axgbe_ethdev.c:(.text+0x16): undefined reference to `rte_pci_register' To enable shared build, update config file: CONFIG_RTE_BUILD_SHARED_LIB=y <...>