From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 8ABDCA09E4;
	Fri, 29 Jan 2021 17:54:45 +0100 (CET)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 1612B4069F;
	Fri, 29 Jan 2021 17:54:45 +0100 (CET)
Received: from mga11.intel.com (mga11.intel.com [192.55.52.93])
 by mails.dpdk.org (Postfix) with ESMTP id 86B3040696
 for <dev@dpdk.org>; Fri, 29 Jan 2021 17:54:43 +0100 (CET)
IronPort-SDR: ObzolHegtSRmd+hxlCYJhh5bWE9goK3yPs5haPx3G/YtjIq6BFb/xZGX97vsvlJBvEC8AqA0FC
 fBcX77Sy/nDw==
X-IronPort-AV: E=McAfee;i="6000,8403,9879"; a="176945044"
X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; d="scan'208";a="176945044"
Received: from orsmga008.jf.intel.com ([10.7.209.65])
 by fmsmga102.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 29 Jan 2021 08:54:42 -0800
IronPort-SDR: +cHnwimaA3Uw68TO/x+iJbxMG+cbqTVRuXC1eGN7DKnY15V89odpfxFZ3FjuTrZulS8aL36WYE
 VbrQ021Uahdg==
X-IronPort-AV: E=Sophos;i="5.79,386,1602572400"; d="scan'208";a="389373101"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.197.204])
 ([10.213.197.204])
 by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384;
 29 Jan 2021 08:54:38 -0800
To: "Min Hu (Connor)" <humin29@huawei.com>,
 Thomas Monjalon <thomas@monjalon.net>,
 Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
Cc: dev@dpdk.org, Wei Hu <xavier.huwei@huawei.com>,
 Chengwen Feng <fengchengwen@huawei.com>,
 Chengchang Tang <tangchengchang@huawei.com>,
 Andrew Rybchenko <arybchenko@solarflare.com>,
 Ajit Khaparde <ajit.khaparde@broadcom.com>
References: <20210115155232.1406688-1-ferruh.yigit@intel.com>
 <6b95ed0f-a6ec-a259-37fc-3ce6b74dd43b@huawei.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9cc5b878-fc98-82a6-cb2d-88045134f2fc@intel.com>
Date: Fri, 29 Jan 2021 16:54:38 +0000
MIME-Version: 1.0
In-Reply-To: <6b95ed0f-a6ec-a259-37fc-3ce6b74dd43b@huawei.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] ethdev: rename FEC API parameters
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 1/16/2021 1:48 AM, Min Hu (Connor) wrote:
> Hi, Ferruh,
>      this change origin from the opinions by Andrew Rybchenko
> <arybchenko@solarflare.com>. snippets like this:
> 
>  > +__rte_experimental
>  > +int rte_eth_fec_get(uint16_t port_id, uint32_t *mode);
>  > +
>  > +/**
>  > + * @warning
>  > + * @b EXPERIMENTAL: this API may change, or be removed, without prior notice
>  > + *
>  > + * Set Forward Error Correction(FEC) mode.
>  > + *
>  > + * @param port_id
>  > + *   The port identifier of the Ethernet device.
>  > + * @param mode
>  > + *   The FEC mode.
> 
> mode -> fec_capa
> A bitmask of enabled FEC modes. If AUTO bit is set, other
> bits specify FEC modes which may be negotiated. If AUTO
> bit is clear, specify FEC modes to be used (only one valid
> mode per speed may be set).
> 
>  > + * @return
>  > + *   - (0) if successful.
>  > + *   - (-EINVAL) if the FEC mode is not valid.
> 
> Much more info could be referred to the patch:
>   Re: [dpdk-dev] [PATCH V13 1/3] ethdev: introduce FEC API
>      from arybchenko@solarflare.com
> 
> thanks.
> 

Got it, if the parameter name explicitly selected this way, dropping this patch.