From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga03.intel.com (mga03.intel.com [134.134.136.65])
 by dpdk.org (Postfix) with ESMTP id 5DCE5200
 for <dev@dpdk.org>; Wed, 22 Nov 2017 01:04:17 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga103.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384;
 21 Nov 2017 16:04:16 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,432,1505804400"; 
   d="scan'208";a="4997811"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.243])
 ([10.241.224.243])
 by orsmga003.jf.intel.com with ESMTP; 21 Nov 2017 16:04:16 -0800
To: Jingjing Wu <jingjing.wu@intel.com>, dev@dpdk.org
Cc: wenzhuo.lu@intel.com, Shahaf Shuler <shahafs@mellanox.com>
References: <1508488012-82704-1-git-send-email-jingjing.wu@intel.com>
 <1508488012-82704-4-git-send-email-jingjing.wu@intel.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <9ce13ce0-4c31-13bb-1e93-747cc1179ab0@intel.com>
Date: Tue, 21 Nov 2017 16:04:15 -0800
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <1508488012-82704-4-git-send-email-jingjing.wu@intel.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [RFC 3/9] net/avf: enable queue and device
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Wed, 22 Nov 2017 00:04:17 -0000

On 10/20/2017 1:26 AM, Jingjing Wu wrote:
> enable device and queue setup ops like:
> 
>  - dev_configure
>  - dev_start
>  - dev_stop
>  - dev_close
>  - dev_infos_get
>  - rx_queue_start
>  - rx_queue_stop
>  - tx_queue_start
>  - tx_queue_stop
>  - rx_queue_setup
>  - rx_queue_release
>  - tx_queue_setup
>  - tx_queue_release
> 
> Signed-off-by: Jingjing Wu <jingjing.wu@intel.com>

<...>

>  static int
> +avf_dev_configure(struct rte_eth_dev *dev)
> +{
> +	struct avf_adapter *ad =
> +		AVF_DEV_PRIVATE_TO_ADAPTER(dev->data->dev_private);
> +	struct rte_eth_conf *dev_conf = &dev->data->dev_conf;
> +
> +	/* Initialize to TRUE. If any of Rx queues doesn't meet the bulk
> +	 * allocation or vector Rx preconditions we will reset it.
> +	 */
> +	ad->rx_vec_allowed = true;
> +	ad->tx_simple_allowed = true;
> +	ad->tx_vec_allowed = true;
> +
> +	/* Vlan stripping setting */
> +	if (dev_conf->rxmode.hw_vlan_strip)

What about using new method for offloading configuration:
ce17eddefc20 ("ethdev: introduce Rx queue offloads API")
cba7f53b717d ("ethdev: introduce Tx queue offloads API")

cc'ed Shahaf if support needed.