From: Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>
To: Pankaj Gupta <pagupta@vmware.com>,
jbehrens@vmware.com, yongwang@vmware.com
Cc: dev@dpdk.org
Subject: Re: [PATCH 7/8] vmxnet3: Set packet for fragmented packet
Date: Wed, 4 May 2022 18:07:59 +0300 [thread overview]
Message-ID: <9cec61d7-15f0-0272-7ba4-f87b5634d276@oktetlabs.ru> (raw)
In-Reply-To: <20220503042257.15626-8-pagupta@vmware.com>
On 5/3/22 07:22, Pankaj Gupta wrote:
> The packet type is set even if it is a fragmented packet
I'm wondering if is really IPv4/IPv6 fragmented packets or just
scattered on Rx across many Rx buffers.
I'm asking since fragmented sounds weird with TCP, since TCP
spec forbids fragmentation.
>
> Tested, using testpmd, for different hardware versions on
> ESXi 7.0 Update 2.
>
> Signed-off-by: Pankaj Gupta <pagupta@vmware.com>
> ---
> drivers/net/vmxnet3/vmxnet3_rxtx.c | 17 +++++++++++++++++
> 1 file changed, 17 insertions(+)
>
> diff --git a/drivers/net/vmxnet3/vmxnet3_rxtx.c b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> index a6665fbf70..5e177400c0 100644
> --- a/drivers/net/vmxnet3/vmxnet3_rxtx.c
> +++ b/drivers/net/vmxnet3/vmxnet3_rxtx.c
> @@ -759,6 +759,23 @@ vmxnet3_rx_offload(struct vmxnet3_hw *hw, const Vmxnet3_RxCompDesc *rcd,
> /* Check packet type, checksum errors, etc. */
> if (rcd->cnc) {
> ol_flags |= RTE_MBUF_F_RX_L4_CKSUM_UNKNOWN;
> +
> + if (rcd->v4) {
> + packet_type |= RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
> + if (rcd->tcp)
> + packet_type |= RTE_PTYPE_L4_TCP;
> + else if (rcd->udp)
> + packet_type |= RTE_PTYPE_L4_UDP;
> + } else if (rcd->v6) {
> + packet_type |= RTE_PTYPE_L3_IPV6_EXT_UNKNOWN;
> + if (rcd->tcp)
> + packet_type |= RTE_PTYPE_L4_TCP;
> + else if (rcd->udp)
> + packet_type |= RTE_PTYPE_L4_UDP;
> + } else {
> + packet_type |= RTE_PTYPE_UNKNOWN;
> + }
> +
> } else {
> if (rcd->v4) {
> packet_type |= RTE_PTYPE_L3_IPV4_EXT_UNKNOWN;
next prev parent reply other threads:[~2022-05-04 15:08 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-03 4:22 [PATCH 0/8] vmxnet3 version V5 and V6 Pankaj Gupta
2022-05-03 4:22 ` [PATCH 1/8] vmxnet3: Added V5 support Pankaj Gupta
2022-05-03 4:22 ` [PATCH 2/8] vmxnet3: implement reta query and reta update Pankaj Gupta
2022-05-04 14:23 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 3/8] vmxnet3: add rx queue usage count utility Pankaj Gupta
2022-05-04 14:27 ` Andrew Rybchenko
2022-05-04 14:35 ` Morten Brørup
2022-05-04 17:58 ` Pankaj Gupta
2022-05-03 4:22 ` [PATCH 4/8] vmxnet3: add get hw version api Pankaj Gupta
2022-05-04 14:35 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 5/8] vmxnet3, version 6 Pankaj Gupta
2022-05-04 14:46 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 6/8] vmxnet3: set reta size Pankaj Gupta
2022-05-04 15:05 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 7/8] vmxnet3: Set packet for fragmented packet Pankaj Gupta
2022-05-04 15:07 ` Andrew Rybchenko [this message]
2022-05-04 20:40 ` Pankaj Gupta
2022-05-05 8:45 ` Andrew Rybchenko
2022-05-03 4:22 ` [PATCH 8/8] vmxnet3: Fix merge error in initialization for rxDataRing feature Pankaj Gupta
2022-05-04 15:09 ` Andrew Rybchenko
2022-05-04 20:37 ` Pankaj Gupta
2022-05-05 8:37 ` Andrew Rybchenko
2022-05-03 18:50 ` [PATCH 0/8] vmxnet3 version V5 and V6 Jochen Behrens
2022-05-04 14:28 ` Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 1/9] net/vmxnet3: add version 5 support Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 2/9] net/vmxnet3: implement RETA query and RETA update Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 3/9] net/vmxnet3: add Rx queue usage count utility Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 4/9] net/vmxnet3: fix ethdev callbacks init order Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 5/9] net/vmxnet3: report HW version on FW version get Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 6/9] net/vmxnet3: add version 6 support Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 7/9] net/vmxnet3: advertise RETA size in device info Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 8/9] net/vmxnet3: set packet type for fragmented packet Andrew Rybchenko
2022-05-19 8:04 ` [PATCH v6 9/9] net/vmxnet3: fix merge error in Rx data ring initialization Andrew Rybchenko
2022-05-19 8:07 ` [PATCH v6 0/9] net/vmxnet3: support versions 5 and 6 Andrew Rybchenko
2022-05-23 20:56 ` Pankaj Gupta
2022-05-24 6:46 ` Andrew Rybchenko
-- strict thread matches above, loose matches on Subject: below --
2022-05-02 19:45 [PATCH 0/8] vmxnet3: V5 and V6 Pankaj Gupta
2022-05-02 19:45 ` [PATCH 7/8] vmxnet3: Set packet for fragmented packet Pankaj Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9cec61d7-15f0-0272-7ba4-f87b5634d276@oktetlabs.ru \
--to=andrew.rybchenko@oktetlabs.ru \
--cc=dev@dpdk.org \
--cc=jbehrens@vmware.com \
--cc=pagupta@vmware.com \
--cc=yongwang@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).