From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id BF0EBA04DB; Thu, 15 Oct 2020 12:31:33 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5F7C61DE5C; Thu, 15 Oct 2020 12:31:23 +0200 (CEST) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by dpdk.org (Postfix) with ESMTP id C0F391DE5A; Thu, 15 Oct 2020 12:31:20 +0200 (CEST) Received: by mail-wr1-f65.google.com with SMTP id g12so2763465wrp.10; Thu, 15 Oct 2020 03:31:20 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=ifHC+E9xu3PTI6oTZ8Np9L2iXlg15l65yIOt8+XNCi4=; b=MKWyY9qzQWTIBXFpWff/QwkEUw1w38m8mBythBhA2IMaW0ipjq01neoWsP5gbxtiku WFZPPBrNDEfmPJowXhlI11842pE0AXYSjz+75CheoKM82o5jrB5XAQrwApTsr0hn3cnc tgaWVhz4+K1jPEZfrSidYItb9b6WADz8pdGg64SHAE12PoyvCWnue8VSOfpPX31FPlcK npfdlHzYzWoEDp5NfVAGcW46aP6qBLcpN/awy3hngGJpvCX+0UT5XXgsToZYWEN1RG33 Fbmcp2jv0spIOivWC556isRd3CZkX59//3vIB15YJl+AYaMHV3Zb1QZ5l4HFNJPw9ytF i6Hg== X-Gm-Message-State: AOAM532w+KrM+wRQFPa/ch75tU20m1hUiZVx4vdh1hKw4d58gfy4JwV9 53quJ+6xs2hUbfVVBQhrvbM= X-Google-Smtp-Source: ABdhPJxEKFbqf/mFyCE29fNt300hFQI8yao90DuZJJy6n1O0BkQq0RgOVQS4BvoAv/KnophRPc38uA== X-Received: by 2002:a5d:410a:: with SMTP id l10mr3509985wrp.274.1602757879507; Thu, 15 Oct 2020 03:31:19 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id a127sm4035825wmh.13.2020.10.15.03.31.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 15 Oct 2020 03:31:18 -0700 (PDT) Message-ID: <9d06a3d9eb1792c02e909d44fdcfd527531c4848.camel@debian.org> From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: david.marchand@redhat.com, arybchenko@solarflare.com, ferruh.yigit@intel.com, thomas@monjalon.net, stable@dpdk.org Date: Thu, 15 Oct 2020 11:31:18 +0100 In-Reply-To: <20201014141304.632120-4-bruce.richardson@intel.com> References: <20200916164429.244847-1-bruce.richardson@intel.com> <20201014141304.632120-1-bruce.richardson@intel.com> <20201014141304.632120-4-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v3 3/7] build: add defines for compatibility with make build X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-10-14 at 15:13 +0100, Bruce Richardson wrote: > The defines used to indicate what crypto, compression and eventdev driver= s > were being built were different to those used in the make build, with mes= on > defining them with "_PMD" at the end, while make defined them with "_PMD" > in the middle and the specific driver name at the end. This might cause > compatibility issues for applications which used the older defines, which > switching to build against new DPDK releases. >=20 > As well as changing the default to match that of make, meson also > special-cases the crypto/compression/event drivers to have both defines > provided. This ensures compatibility for these macros with both meson and > make from older versions. >=20 > For a selection of other libraries and drivers, there were other > incompatibilities between the meson and make-defined macros which were no= t > previously highlighted in a deprecation notice, so we add per-macro > compatibility defines for these to ease the transition from make to meson= . >=20 > Fixes: 5b9656b157d3 ("lib: build with meson") > Fixes: 9314afb68a53 ("drivers: add infrastructure for meson build") > Fixes: dcadbbde8e61 ("crypto/null: build with meson") > Fixes: 3c32e89f68e1 ("compress/isal: add skeleton ISA-L compression PMD") > Fixes: eca504f318db ("drivers/event: build skeleton and SW drivers with m= eson") >=20 > Cc: stable@dpdk.org >=20 > Signed-off-by: Bruce Richardson > --- > app/test/meson.build | 1 + > config/meson.build | 3 +- > config/rte_compatibility_defines.h | 129 +++++++++++++++++++++++++++++ > config/rte_config.h | 1 + > drivers/compress/meson.build | 2 +- > drivers/crypto/meson.build | 2 +- > drivers/event/meson.build | 2 +- > drivers/meson.build | 15 ++++ > 8 files changed, 151 insertions(+), 4 deletions(-) > create mode 100644 config/rte_compatibility_defines.h >=20 > diff --git a/app/test/meson.build b/app/test/meson.build > index dedf29dd7..fc90a1909 100644 > --- a/app/test/meson.build > +++ b/app/test/meson.build > @@ -415,6 +415,7 @@ endif > =20 > if dpdk_conf.has('RTE_LIBRTE_PMD_CRYPTO_SCHEDULER') > driver_test_names +=3D 'cryptodev_scheduler_autotest' > + test_deps +=3D 'pmd_crypto_scheduler' > endif > =20 > foreach d:test_deps This change looks out of place in this patch? Was it supposed to be part of one of the previous commits maybe? Other than that, Acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi