From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM03-CO1-obe.outbound.protection.outlook.com (mail-co1nam03on0070.outbound.protection.outlook.com [104.47.40.70]) by dpdk.org (Postfix) with ESMTP id A0B4D2716 for ; Thu, 1 Sep 2016 15:55:04 +0200 (CEST) Received: from BN6PR03CA0059.namprd03.prod.outlook.com (10.173.137.21) by MWHPR03MB2445.namprd03.prod.outlook.com (10.169.200.139) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.587.13; Thu, 1 Sep 2016 13:55:02 +0000 Received: from BN1BFFO11OLC002.protection.gbl (2a01:111:f400:7c10::1:137) by BN6PR03CA0059.outlook.office365.com (2603:10b6:404:4c::21) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.599.9 via Frontend Transport; Thu, 1 Sep 2016 13:55:02 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=fail action=none header.from=nxp.com; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1BFFO11OLC002.mail.protection.outlook.com (10.58.145.13) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.587.6 via Frontend Transport; Thu, 1 Sep 2016 13:55:01 +0000 Received: from [10.232.14.87] ([10.232.14.87]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u81Dsw7V018261; Thu, 1 Sep 2016 06:54:58 -0700 To: Ferruh Yigit , References: <1466510566-9240-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-1-git-send-email-shreyansh.jain@nxp.com> <1472219823-29486-23-git-send-email-shreyansh.jain@nxp.com> <57C5AA99.7030005@intel.com> CC: , , , From: Shreyansh Jain Message-ID: <9d0aa9a3-6238-b341-e739-dcee1f3d83d9@nxp.com> Date: Thu, 1 Sep 2016 19:24:57 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <57C5AA99.7030005@intel.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131172117020463731; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1110001)(1109001)(3190300001)(339900001)(377454003)(189002)(199003)(24454002)(76104003)(7846002)(23746002)(4001350100001)(5660300001)(85426001)(33646002)(19580395003)(230700001)(64126003)(83506001)(19580405001)(31686004)(586003)(76176999)(2950100001)(54356999)(11100500001)(104016004)(5001770100001)(77096005)(36756003)(97736004)(50986999)(65826007)(31696002)(189998001)(86362001)(2906002)(626004)(93886004)(4326007)(105606002)(92566002)(50466002)(81156014)(8666005)(87936001)(65956001)(356003)(65806001)(106466001)(8676002)(81166006)(68736007)(8936002)(47776003)(305945005)(7059030); DIR:OUT; SFP:1101; SCL:1; SRVR:MWHPR03MB2445; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1BFFO11OLC002; 1:XDQF4ioZWNr0J6Gl246yNhuELkADPAfUK7UrOR+EK7sSbmkI7H3MCkaYGsGKqyNKPhRfqWhOelh47/JxOsC0eotPQXcDQRENc9HQBVQWoPrs1Y/gstWB/HdLPWgo1qNPPsWQwRMvZC1x4TSjACvrGDHHQ7oFA7+bfWka23KQx3MBYMDZDB/34Ulp+kBHyrDPi1vUrRbeif6hG60wEPIRTWFq8ZP3Nb1Ccnc+LtDykbaajglpFalqb+N5We4Bo3iPzVxKtfF9HfknV5DvwJDmHusgFnAxxF6AcP2jXHAF/Dqaw2lrx+diynyHTx0vyXxLCZOXo6CKdtmto21zjmRX0XjV//e97u6D4ATp6g0WJxoXstb4roQkpLxE/PFbIRjlc+lSdvAHzW5qRyE4YfagbUep7exeLbadm4B3cb1dWAbYVzeqzLtYBiaKdW3OYoqVA8GZAyKpDIlnKWtT9m9quHNcv8o1hpMfVzV374INVit/pYbMJcfqKdHAk+O2Dbei2Z+IDcKx49n7guTF5bOCJTzV5rWrC7sp/7LaLC7DB3IPjv+IEN4dZRdAzUqAgmTThVI0bmptFwgGCj/oXd1kk3gVw9MGTeN90txk0V0V9ezoK16ooPGxz2t7wR7A6q6AOub0VVweEpPuOz+Qpd6DxA== X-MS-Office365-Filtering-Correlation-Id: 7030e7ae-fc7f-4da7-d273-08d3d26f91e7 X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2445; 2:yj4COUQmEi18vxYzdL8nNHCVaDkzJGBvqrHc8DVUktq++/79rghKGMfko7721QMI7WqcbRXZZlEtEaNwTIitavguQy8WQQE9rQvcpN2zeex7QKNIpnN/9zEgV6It7RM4huJCbdKhB6q/Fv1y5kvCLKBoLMbhVLfzPsKEyMQ/AWHtW+T7m63A0MHhoR7ek0La; 3:UgfpMlC/+HY+N0F5kQhXqxhlGiyReFK1S7/oJqyJxFMi+E1Yo4Wo9MlvVjy3TtqcIn2mGOSeGVoTi2BEj+Ym4KxoszLnkt+xP6jDH5e19QwAHIkiLtFHgWqvNxqmAZb2ejMAktRkmYwuQUcdOaVErOitzG2M6gcMjf2Fv3Y3dh875DTMznbB+UisBE7hO1zLEUIgZ0kO1B72wcOkilKgy5OvVLSz0N7Nc4LiimI8cbA=; 25:n/cuFLZCCqhNn8gE1Y/qWDipTRwRkCp8poCPRZenPDfYEZkZoRk7392XgMrhrd2oydYdfHz4bsePoOBgavuQDAa6901KfuN22fnQPwd3Xgo9nDWC8A/qW6ezZqqVJ7rJ7eLuZyJMcaf6yX98Pu6m9eyHlFXKIUCEjjez/EqOJar7Ztz5kbYJsyKLMmQ0uV1FcDdbJVuefZoL6LC2e8t+WTiRrSJR5a7mBy0VjvRcbwsmEz4JhOTTm47l2zeUn8mnwTd5k3d6okZL/MKxSWMPLZnfAWbvp8xH5K/aw7WhQDfGhNJYigg5lUWWm7eV1s3eiDhMZSxBOkR6XKlmUTXFEdfA8gpIRlJr9H8sBAbnLFJGSF1mKsVcSSRKPqcIib6n4lO/IF0RHiwXHKFoad6OzpmYJJEAXCP2RFdnqlDE1NE= X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:MWHPR03MB2445; X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2445; 31:+n+kb46aw7TyKPv7F8dQChbgSYDzSVRxaq6FpWnlNEi0Zx+xbl/A5pmaciBnlTNswNOUnOpWpYKibfXticsfKLlAmC0rYmt9duNG+0jssr5hyvkgXbPvYR5/tzLJb0GTj7XPtfpciEQggXjVfud8QpmCL9rctEgHFbxoXwTdzA6tUHlUmZRWyOEwrBHS4I6xqwOqVJrmCU6pdvwOBBN9B8VGqhSA0syGELF/T75/W8Q=; 4:cvlvOoYd6DJncfls2XaTVMr9lVzp1/RUJfE5ODn6dV5hAQGs0szj5FCoP1uDHUooR48CJCAdOChFlY93P1PuGBJqRSWLJkOvE3Pu4tpjYx3aWnHK2MN8VBqkTOk8rlHdJDB7SWlYK3TZQYIrGYpYu4xDy6dfYB8LkwT7NDeg3yp9NwnRcZmZq0Gc2Kx6fiXg54qoR3ybaFWCYNqDymtScVZDxXvLNLII/DegMyVEFlaOTlf8trKOORd9Wa5nyK3JV5g84JlwQiwll6LBBtwL9HQuUKVsT4mMSRh4IhDihu3kS5G9RmutGiFMFGKHRA9yjhahUZNdAPoCfGBII2lNhAeA1SGsNH+zZ7oIqsXmKlS+D7K0WotvA4BFX8L/e+EiDVFk2f6A4WiRuxXA+mdtnE4A8+eBEVf4Y6Yd5lFQnfTd3vO2/0kGkd8ZIxCi1ycww0e7iGrs+D/Be7AX5LcJX/OXG5xt//Th36BdbaieQGBzFl3qzzZzBTrs2hy/8iyqJ875mtsCZk+j6eACVKD0DgqyhNl9cS8FDotgK5oTfcB8/KtUyxofWQjqQLb7g3I2 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197)(788757137089); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(5005006)(13015025)(13017025)(13024025)(13023025)(13018025)(10201501046)(3002001)(6055026); SRVR:MWHPR03MB2445; BCL:0; PCL:0; RULEID:(400006); SRVR:MWHPR03MB2445; X-Forefront-PRVS: 0052308DC6 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; MWHPR03MB2445; 23:LEDv28dblYlQgq3j5R4zGnOqZtrlj88cGvxd1?= =?Windows-1252?Q?NI8cdgAqtk3ZOQFAhrhwGYobdojYbLNCJ1a72hJE3azNM9F/26RvXVOZ?= =?Windows-1252?Q?S01galCdyWyXQbOT2oziW+TRgkDEJ76Ev4wQd27/g4n4q0iNzyHE1V3Y?= =?Windows-1252?Q?0qzdQdSC57599T1u8hVBJAEsV2NvHTe80UdfRXC/yEhFAcbDMi96pKSz?= =?Windows-1252?Q?9UxKt/TOXqZdV+REvyK3ML9NEktOk5oSVN1xpHINFtpZZ9IfO5RAIGoJ?= =?Windows-1252?Q?NrCQ0PNEVLvVV2EtKlZo02pkHtwWFNTykFWAnJ7eHU1zoyKdK/HDzWy4?= =?Windows-1252?Q?6epb/pgYu1K80JIJh7dNR4sxH4SNnGAgp1taP2QaQbuUhfq4Zkr2Mtj6?= =?Windows-1252?Q?JtuTfQpUaV8Y33rCMjt9n82UCS/5GV9oWWOx6eezq9Nw3DJOZmF4ynk7?= =?Windows-1252?Q?DhSGafgOCVKe9EALIi4Cxo6urF28KlBCXUNpKNDDY9M+A9+wORFNeDi4?= =?Windows-1252?Q?isAQsc5xv5bePi1e6IymZoWK/THXKS/NXWYxEpR1FAri7kHj/JTFgJs6?= =?Windows-1252?Q?ibjFXmqLyrdO2d7Sq3/PIfMgErzA2Kj62h0Xo+BwEsA3vAGitN96SAAN?= =?Windows-1252?Q?aCrpsTnC1UyBfgMRwvnKPHiJ1VAKLipwtPANdduKOBGbvLcK8KBPrfSY?= =?Windows-1252?Q?FVnDuCVhf0TBtRVZdiUcBD5jlUNLdcJfzvayO5KeYAd/7mIk0zSvYkkg?= =?Windows-1252?Q?YEeqzW4rTZRGZtyFDIrJ0JRUB9BV8gC3VmlicS9LOeIKjTkP6ESwSY9A?= =?Windows-1252?Q?WkVh16WcNic3LgHuZznUnwUuKurmTxo7rJigYpOKMX5g7QvD00+s44Zh?= =?Windows-1252?Q?tL1QivJtN/S82UQOF6zLdlziui7zslmpZQje8mtjQP20Yt2vmKBj5Rsf?= =?Windows-1252?Q?SmB+mONZoKbDdviQwX2JVSnIdDs4vP0DvZzaTVN/5+HFkj/aRDMqoXE/?= =?Windows-1252?Q?ZB/2FqWobZW9kIiqTeGBkfxhTEtZP35pORVjMvi5CHpLhBhZzjeqPWq+?= =?Windows-1252?Q?zFL/aRj+kZcjI64wh4G0hrotfXQiJwIW+I68BKwf1deEU1k2GdyxBxUy?= =?Windows-1252?Q?abNA3cTMarISPj2KTdPKASE+iezvg4oQFJ7fbkl1jaRYyRf4Kdo6cheu?= =?Windows-1252?Q?g8ESzuKK7FqdaKbEB0E9umfZjgTWQXzvHSQE5L6pWh4Ktq968+tpYn87?= =?Windows-1252?Q?XqlmR0DxOZoEI7RUPMf7wugJiTAK4WL/ix5HxMLmom8x3c+KEgZYUvxV?= =?Windows-1252?Q?F/PwYrPf6UdqzdVLrU7QO1LuVh4oeGNfynmaBj2E0D9vhwKVVkb/t2k9?= =?Windows-1252?Q?ha6kyPlMysIecEbpPA+BqM4CyNTbUaejdlUI5CeM0cWPNk1wtqlRtlaz?= =?Windows-1252?Q?TrwF3VK/bvbph36ClWFPUTAO36UQtSeIXW5uXCMcr1XTmqr3XnGCM28W?= =?Windows-1252?Q?33hfINTbTyhkDES/Eiktg6xjYaevaavNT37dezkzKBy5ljpcTSGsMqsP?= =?Windows-1252?Q?GTh9b519lsvEzI=3D?= X-Microsoft-Exchange-Diagnostics: 1; MWHPR03MB2445; 6:kS6rTf6lYwXhGbKquz37+7qYS6zIq7MqJq0dmbXzd6755fSQVOiIEl/onkLpZSAjnf+7PhSWmA+M0j7loQLUA8HYXhi5ok9L1gEymko0JJKTQDGfzCyC2fb2ffuBHn+FvYyKo0Q4CBJhxIvhkmy3pM8TPGH+IzvftjP0LjkbmkP8E+Z1UABc5njaniud2H0rfTxZdSP7NEzxZ2HMfd56kme5/enZyTi+PylK9TMAXfE+O6hH8sc0YaLIJf2uZRbQtWzJLpeQUISnPkxVVYxXHiH0+EodOAUL24tkNZ5rpUs=; 5:sWtkYrc6KfpjSYL5f5RDCZA9l2Z9W+3MDobL4FWIvg14jL1xChwXziOSvvmJILiMFvN81fy5ddlQpzTsz8pZxtfqgNHcZ8lMW5iuq6DI0bsnzOR4v74uOiBt3m+two+zAOglMgny6vAkykQvwIbN6OaYHnapa1bPf+LayiLZIRE=; 24:+Yj+/tJ9sPj/iCPRoa/D7jCts7vjSCf2bHojQNmYsnKA5HZl1yVsAV0rFHqyInjBD4pWMh3CCbaOHK4r5cDVrTk/wGR4F7zEqLDi4knhCpc=; 7:D9wlNaWP+9KKEPlaCtFUkJwFeOHatXr7gOaxgixUCXa9rJy9zhikUVtsdvF/tN2ICBpjzvWBt04py8B2Ayd+pmAnNUXTQWJ2QQVAz4DUD63gZPQB8JWaF+fBaOJ8CFut/DHF0KJv5TGBF+fHkgLMTQ0+vdJeCcDWaT7uxEDdRckyeQbjyDx+c7k4HnQefdy14dpR1g0D1j52P1SaQSNEawAb3bPVIAKx6u87jGJZ1Df4TLUsNLbohiqlQW/eMVTz SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 01 Sep 2016 13:55:01.8123 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR03MB2445 Subject: Re: [dpdk-dev] [PATCH v8 22/25] eal/pci: inherit rte_driver by rte_pci_driver X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 01 Sep 2016 13:55:05 -0000 Hi, On Tuesday 30 August 2016 09:17 PM, Ferruh Yigit wrote: > On 8/26/2016 2:57 PM, Shreyansh Jain wrote: >> Remove the 'name' member from rte_pci_driver and move to generic rte_driver. >> >> Most of the PMD drivers were initially using DRIVER_REGISTER_PCI(..) >> as well as assigning a name to eth_driver.pci_drv.name member. >> In this patch, only the original DRIVER_REGISTER_PCI(..) name has been >> populated into the rte_driver.name member - assignments through eth_driver >> has been removed. >> >> Signed-off-by: Jan Viktorin >> Signed-off-by: Shreyansh Jain >> --- > > There are a few name fields: > > 1) eth_dev->data->name > 2) eth_dev->data->drv_name > 3) rte_driver->name > 4) dev_info->driver_name > > > What should be the relation between them? > > I guess 1) is device_name, 2, 3, 4 are same thing and driver_name. Yes, (1) is the ethernet device name. (2), (3) are same, i.e. driver name (4) is an output field for eth_dev_info_get method and would represent same thing as (2) and (3). > > If this is correct, virtual drivers needs to be updated for this, > because for them 3 != (2 == 4). They all use global variable for 2 & 4. Ok. I didn't notice this. I will check it once again. > > And what do you think removing 2) completely? > I guess it exists for virtual devices, since for them eth_driver is not > exists and not able to access to rte_driver->name from eth_dev, but this > is solvable. Ok. Probably, one way to solve is to make eth_dev->driver point to rte_vdev_driver. That way, rte_driver->name would replace eth_dev->data->drv_name. I will give it a thought. Thanks for pointing out. > > > Thanks, > ferruh > - Shreyansh