From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BDCA41DB5; Thu, 2 Mar 2023 16:27:42 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F0A7F40E09; Thu, 2 Mar 2023 16:27:41 +0100 (CET) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2063.outbound.protection.outlook.com [40.107.94.63]) by mails.dpdk.org (Postfix) with ESMTP id AE42E400D6; Thu, 2 Mar 2023 16:27:39 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=F428KLf7Qah57NDWYu0S2MqZpZf1bZNncDibvhMivRNDNctUZelbUU1PetUOCfodax4iRtLrKAhfy+zpBzPx1x3b2R/AnJjU3vO3SSoygH1P0hb56UGPFgTCwiCs/DRKWzNO0gz+01pgMHoGwZIVBI6kuv3XYv2lsBOQMEEnvXizCypkZbzSc56R+0Ck+E7Hn0dlCyahB+9Y2+hvBp5TE/niATXa5l6A23z1Cdn56aesM1B2NU8fEIR5nhL3KAKLiTMmXqQ8lk6HCGzjg0mLw+97gddN6OLXg/QLIHJd4S7/Lg2jRFBTcx5G1N+OoP1/esIjRrnEyHuSipenHmrBTw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ma8ofs/WY2bMm5/pAQxT1Zz5A8XiWKcLYVN6JFQmIxA=; b=Z2FyXKfQJd7j/zvhxtZUFeXDVvlfiPHTJBcdL+mZal6+RmTYyOrGKxHgVF+gx5JucYTORpuQYloWPgjYi7MDVwHUP05WJo6nr4FriGASXaFLMAII439he2vPwFf3cP/ZjmxNc3Lp+uYTY7xWTI8Vq7ZsERzuZH2rOFsg0/PVgW9yz/Uk+h/V0JWhcn9tp50ykICphqzv9F7P447fN9kjQKQKCvBGYbThhzCefdOM8Y5JLYZvd6LytKyH7AiLFrR2TeMSZNXn7+5CyFRf6Z1ATHdgn99UUd9ZuzGUfmHF1hHfJwQvdudsm3BmHYYCqQ+yREJInnj+uqDecRUBA9JN6Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ma8ofs/WY2bMm5/pAQxT1Zz5A8XiWKcLYVN6JFQmIxA=; b=AaWH0RUOdK6nbR/FYI73ptAKQjBmIWeSOHAeSLsKwaorhX7OTlEoBnz5Qhwe4jF9NJT65uZwLoqRud17XvOfMOY80JB04+BYJZn02oUcOhTRk7chSsoLWX8RA+gf4q2C6CF32Gs1Y2VfwGPC1GdVAya5SXCBANL0pOI9D8Wj1KU= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by CH2PR12MB4040.namprd12.prod.outlook.com (2603:10b6:610:ac::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6156.18; Thu, 2 Mar 2023 15:27:37 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::dd5a:8a5c:f493:9640%4]) with mapi id 15.20.6156.017; Thu, 2 Mar 2023 15:27:37 +0000 Message-ID: <9d1106d5-e57e-fd49-0191-48f3e4c377f7@amd.com> Date: Thu, 2 Mar 2023 15:27:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 Subject: Re: [PATCH] ethdev: remove telemetry Rx mbuf alloc failed field Content-Language: en-US To: Andrew Rybchenko , Thomas Monjalon Cc: Gowrishankar Muthukrishnan , dev@dpdk.org, stable@dpdk.org, Bruce Richardson , Qi Zhang References: <20230228180230.3066738-1-ferruh.yigit@amd.com> <9988058.nnTZe4vzsl@thomas> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P265CA0142.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:2c4::16) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|CH2PR12MB4040:EE_ X-MS-Office365-Filtering-Correlation-Id: b60f718b-dbd6-44da-2c9c-08db1b32a73e X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: Klt67DiwS3LBEspOy18G00z7Mmp35j+5Jv7jXEFLfuy8itLYfBKjvec2KYo4xSwl7GOyxil64uxqG707yZikVKc2fNm4i1Cda4XjSzEq/1DQ84d2MVECD3mdgu4hW2Za1h2SAFJJpJHkw7VgRjfXMRpUNddncMa9L1ko9JFULM5QEtYe8WVMi5Tui01u0hsy7jFYfoXxt6KYLXnLSHF79hKfDh8Yvs8b5n9i59R3TR/Au90+muvZVqyBAmbRAce7dTbc5qEc5SltgGXC6guyJWWufdm8v+PzfJkYu+HzjAvZLtVdw+O4Pz7+bAvt9L17bRGtbffa592tjdylVspH2FwW+6YvNgzpKlgioHV0y2QP/VYHDY3ik89jfR4YlK14ISuEUPr2zSbV+qavcudr1LAtwy+iUyfcWIvVO8vEjfkxfYmQ7RexPOZogIKtwdvLhCTj39ZncayxDyqIp+p4M/9GyDmVA7ey7y3w2uV/WSZrylZCPZXgJoSUWK8BeqdtZnXPcLj8XAY4DEHkzyvYhGP9TAO798LAWHMdZTxcd88IzWKuFkWKxPhnQZpZwafwklOmUVvi2JCoNKmsTTaNt3R6V8nEYQdDp0s2Popc1BYEeooQybZP7kAc1pLwSlDTq3HmqdZu/em+PacSD1TPbgOEqIFy28QgQafOdV8fvqS2QPVhJS4zE2E/L0hEeQW78v0xwqdiYabDZZI3mxaHgvkornj9+BTtSCpstiuAn3k= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230025)(4636009)(396003)(136003)(376002)(346002)(366004)(39860400002)(451199018)(66476007)(31686004)(6666004)(36756003)(38100700002)(5660300002)(478600001)(8936002)(86362001)(31696002)(186003)(2616005)(6512007)(26005)(6506007)(53546011)(6486002)(66556008)(4744005)(2906002)(44832011)(4326008)(66946007)(8676002)(316002)(110136005)(41300700001)(54906003)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?bmgyU0xHK3BqWGtaais4aHNsSW1XTHV1RDQ5Y0xyVkp3dmoyQ0VsZW81ZnF0?= =?utf-8?B?TENSYm8rL1Vjd1hXZ2xFLzVycFYrRjIyQmtGbFdGNmJSU3pmcWZMelFJcjhn?= =?utf-8?B?dnJEM3lwYTNhK1hpQjhnYlEyRjYvMUZmMDN1dnJTTzd4cHo2OStIdlRRVjZ6?= =?utf-8?B?Ym1RRGF1V09UYmtteEdUZ3hZN0tYZFZ1Vm9pL01NWTh4Y3RvRnByck9ybEhH?= =?utf-8?B?VzFHRUd3WnhFWVVBcHk2OE5oV25FR1RmUU00dXJpRkFBdm8xQ1c0dm1FdnA1?= =?utf-8?B?WHZxS1pSbVNhb3g2dUxaUHBCRkNWelhOQW9aZWorTDFTVW8zR3FYaXVjRDU2?= =?utf-8?B?VTE4emZZL2tpcEprOURhaHJUMlk5Y3FlKzNJN1RselBTT0VKTXQ3K1FhUCta?= =?utf-8?B?cGxqWjJyUmJnNjRCUG1pd2tLbkNETGFOZFRiWFNtVlBUMTczczNLZStMZkJq?= =?utf-8?B?c1pCZUVvWkR4TGkxSW9GZDNZNU1aQzV0T05ETjZrc0E1NDBpK1U3RXZYOVRQ?= =?utf-8?B?RW8xcDdkSzQ3Ny84NVovWTRXVERRbmlibjhvVHhndm8rN2d6SDZwb2l5a3BK?= =?utf-8?B?Uk1mRVFkcnBsbmIwL2N4cUtKMy9rZXprWDZjTDJoWUhnQ2Q0OVdYY2NtUUZi?= =?utf-8?B?SW0ybUhUclFaZW8rcGZHalVtbnBMTWU3VUJQUFU0SjZ2bDZTRGkxay9sdzB4?= =?utf-8?B?d1VmR0FhMURTR2RwNEFYbVdaaitRTVlldU02TW1pTWNWRUV6VHlZYVdubDJ4?= =?utf-8?B?ajlESVFLTkJLdTNmSFB1c001VllxYmI0SXVEeXZ0ZUJURHRDV1pTbC9teG9y?= =?utf-8?B?ZndrNzEzRFg1WW1pNWFOSDR0S1ZRY0pXYldBd285eFdGNitDM3BMTDh4Zktr?= =?utf-8?B?SER1RTFuQ3hLY1ByTExFWTZYakNzcElZdXZIZWo4aEg0UVZTTzFtV3phUlYv?= =?utf-8?B?ekZacmN2V2NGWGZDL040Uk1mVHA4SGZWekNMM1VoZnFTb1dHTTMyS1BHK3lF?= =?utf-8?B?QmdhZ3NzSUFDL3FoOVFZUzI3V3BwcW9aemI2WlBheHNEN1VoRFh2d04wUzZx?= =?utf-8?B?aldGKzAxc2ZXSi9EVUw5S0p6VWxOK2NUeUwwd0VmVjI0WDhucFVCaHI4R1RW?= =?utf-8?B?Z2JjVElhN2lST0w5U3UzNzJQWW5vTjNQRDkzY044aytmdkoxZkRMSDFNVWhx?= =?utf-8?B?ZVg4Z3lSdHErS2FUOGhManRPMElJK3VZanBGUWZiM2dCNEovQTA5bnJJTFZI?= =?utf-8?B?WTFuSkVTd0p6Z3plTnlva3JldUpmM1dYSHltbG1vSzlramMxRWdldndLK0VT?= =?utf-8?B?ZE5EU3FVbjNWRDZjQkVDcG40dzVzcjAyREpPTlMxeTltZUFLNEQyMWlvV1Fo?= =?utf-8?B?WkJDeDRBM2VOckM1UzAwR2ZoemdtVE9oOGNNTXVUamF4VjJkc0xzc25LMmVT?= =?utf-8?B?dklMK2hQUHRtS0ZUNi9PaW40MFBwRHg2ODJsVG54YS9PTWtVOFhScDN1Y1BW?= =?utf-8?B?VHRpdldOYzF0R2F1L1JZblZEUm85MXVRTFk0a2JJYzJOWVF2dHBRbWl5VERr?= =?utf-8?B?bFNybTBINjVLWVBqbVV1ZGpWK2x4T3JyeWdDb3RCYnZsVURWRVZaV01QNDQ1?= =?utf-8?B?RVRTS2kyemRCeENVejNIZzcydjA2MytUR3hodjhqbEdxN1FlTFJtb1luRVBz?= =?utf-8?B?Wk5xSEZ6WkszSkc4TjNrczc2elUycWFoa3p2OWJCc0RsbkVIWmIvMERoYVlG?= =?utf-8?B?d1E1TFc2RnlQNzdpK2svcFYreG5Qc1BieHpqdXh5Qjh5REd3Rm9nTGdiZzQ4?= =?utf-8?B?MEsvZnA4UXZjU2ZTOTFWMmh1VFQ5S25RUGlFZFBLTkRtdEM2T2hERlNLZWNl?= =?utf-8?B?U0ZWc3N6TE9FenpVa3B6eXpqRlpQbEp2cENGRTlvL3NpcWw3MUpiQ3ozYVlu?= =?utf-8?B?L0lUZmFnWnUxY0cwejJDdVBnbTlpeGpQcDVHY3J5aU1rRDMrMnJtcHJTcWVV?= =?utf-8?B?YW9ablVkM0ZOVCtHMHRaQ1BZZkJ6b3N3bWlWY0NKUUZEYm9VOWJXNXQrSnJ1?= =?utf-8?B?QmJvcDB1RWlqSVBodVduUS9KUGEwb2ZYYklWRll2QW5kenk0NGxqQUpNNW9p?= =?utf-8?Q?q9Nwys0/3GEgzoAqm9zr4Jg0v?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: b60f718b-dbd6-44da-2c9c-08db1b32a73e X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 02 Mar 2023 15:27:37.3741 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: FBd2bsRsEt1obJBM0AQdImDFIWHd8Klh7X/UdDeUXJjBJaAKa+R/iz0L699Jo5Fr X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH2PR12MB4040 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 3/1/2023 2:08 PM, Andrew Rybchenko wrote: > On 3/1/23 14:37, Thomas Monjalon wrote: >> 28/02/2023 19:02, Ferruh Yigit: >>> 'eth_dev->data->rx_mbuf_alloc_failed' field is not directly exposed to >>> user via ethdev APIs but it is used internally to set "stats->rx_nombuf' >>> which is exposed via ehtdev stat APIs. >>> >>> But telemetry exposes this field to user via "/ethdev/info", >>> instead user can get 'rx_nombuf' value from stats via "/ethdev/stats". >>> >>> Removing 'rx_mbuf_alloc_failed' from telemetry to align with ethdev APIs >>> >>> Fixes: 58b43c1ddfd1 ("ethdev: add telemetry endpoint for device info") >>> Cc: stable@dpdk.org >>> >>> Signed-off-by: Ferruh Yigit >>> --- >>> -    rte_tel_data_add_dict_uint(d, "rx_mbuf_alloc_fail", >>> -            eth_dev->data->rx_mbuf_alloc_failed); >> >> Good catch, thanks. >> >> Acked-by: Thomas Monjalon > > Acked-by: Andrew Rybchenko > > Applied to dpdk-next-net/main, thanks.