From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 818644596C; Thu, 12 Sep 2024 10:56:36 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6D4E842788; Thu, 12 Sep 2024 10:56:36 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 5D931406BA for ; Thu, 12 Sep 2024 10:56:35 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 1FB094122 for ; Thu, 12 Sep 2024 10:56:35 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 130C8405C; Thu, 12 Sep 2024 10:56:35 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.2 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.2 Received: from [192.168.1.86] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id AB2AA40B0; Thu, 12 Sep 2024 10:56:32 +0200 (CEST) Message-ID: <9d1d0dcd-7667-4cac-b246-952fe29b71a4@lysator.liu.se> Date: Thu, 12 Sep 2024 10:56:32 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 2/6] eal: add lcore variable test suite To: Jerin Jacob , =?UTF-8?Q?Mattias_R=C3=B6nnblom?= Cc: dev@dpdk.org, =?UTF-8?Q?Morten_Br=C3=B8rup?= , Stephen Hemminger , Konstantin Ananyev , David Marchand References: <20240910070344.699183-2-mattias.ronnblom@ericsson.com> <20240911170430.701685-1-mattias.ronnblom@ericsson.com> <20240911170430.701685-3-mattias.ronnblom@ericsson.com> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-09-12 09:35, Jerin Jacob wrote: > On Wed, Sep 11, 2024 at 11:08 PM Mattias Rönnblom > wrote: >> >> Add test suite to exercise the API. >> >> Signed-off-by: Mattias Rönnblom >> Acked-by: Morten Brørup >> >> -- >> >> RFC v5: >> * Adapt tests to reflect the removal of the GET() and SET() macros. >> >> RFC v4: >> * Check all lcore id's values for all variables in the many variables >> test case. >> * Introduce test case for max-sized lcore variables. >> >> RFC v2: >> * Improve alignment-related test coverage. >> --- >> app/test/meson.build | 1 + >> app/test/test_lcore_var.c | 432 ++++++++++++++++++++++++++++++++++++++ >> 2 files changed, 433 insertions(+) >> create mode 100644 app/test/test_lcore_var.c >> >> diff --git a/app/test/meson.build b/app/test/meson.build >> index e29258e6ec..48279522f0 100644 >> --- a/app/test/meson.build >> +++ b/app/test/meson.build >> @@ -103,6 +103,7 @@ source_file_deps = { >> 'test_ipsec_sad.c': ['ipsec'], >> 'test_kvargs.c': ['kvargs'], >> 'test_latencystats.c': ['ethdev', 'latencystats', 'metrics'] + sample_packet_forward_deps, >> + 'test_lcore_var.c': [], >> 'test_lcores.c': [], >> 'test_link_bonding.c': ['ethdev', 'net_bond', >> +} >> + >> +REGISTER_FAST_TEST(lcore_var_autotest, true, false, test_lcore_var); > > IMO, Good to add one perf test suite for the operations like other > library calls. It may be compared with TLS on same operation. > So that end users can decide to use the scheme based on their use > case, and we get performance test case to avoid future regression > for this library. > OK. I've added a micro benchmark. > It may not show any difference in numbers, but once we have self > monitoring performance counters[1] it can in the future. > [1[] > https://patches.dpdk.org/project/dpdk/patch/20230201131757.1787527-1-tduszynski@marvell.com/ > > > > >> -- >> 2.34.1 >>