From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E8F031B501; Thu, 11 Oct 2018 15:17:21 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 44330308213E; Thu, 11 Oct 2018 13:17:21 +0000 (UTC) Received: from [10.36.112.55] (ovpn-112-55.ams2.redhat.com [10.36.112.55]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 2B69760191; Thu, 11 Oct 2018 13:17:16 +0000 (UTC) To: Tiwei Bie , zhihong.wang@intel.com, dev@dpdk.org Cc: mst@redhat.com, jasowang@redhat.com, stable@dpdk.org References: <20181011130655.5485-1-tiwei.bie@intel.com> From: Maxime Coquelin Message-ID: <9d3be2dd-6dce-00f4-0b73-9fd81c5edd7c@redhat.com> Date: Thu, 11 Oct 2018 15:17:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181011130655.5485-1-tiwei.bie@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.42]); Thu, 11 Oct 2018 13:17:21 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vhost: fix notification for packed ring X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 11 Oct 2018 13:17:22 -0000 On 10/11/2018 03:06 PM, Tiwei Bie wrote: > The notification can't be disabled in packed ring when > application tries to disable notification, because the > device event flags field is overwritten by an unexpected > value. This patch fixes this issue. > > Fixes: b1cce26af1dc ("vhost: add notification for packed ring") > Cc: stable@dpdk.org > > Signed-off-by: Tiwei Bie > --- > lib/librte_vhost/vhost.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > > diff --git a/lib/librte_vhost/vhost.c b/lib/librte_vhost/vhost.c > index e62f4c594..c9270bdec 100644 > --- a/lib/librte_vhost/vhost.c > +++ b/lib/librte_vhost/vhost.c > @@ -667,8 +667,10 @@ vhost_enable_notify_packed(struct virtio_net *dev, > { > uint16_t flags; > > - if (!enable) > - vq->device_event->flags = VRING_EVENT_F_DISABLE; > + if (!enable) { > + flags = VRING_EVENT_F_DISABLE; > + goto out; > + } > > flags = VRING_EVENT_F_ENABLE; > if (dev->features & (1ULL << VIRTIO_RING_F_EVENT_IDX)) { > @@ -677,6 +679,7 @@ vhost_enable_notify_packed(struct virtio_net *dev, > vq->avail_wrap_counter << 15; > } > > +out: > rte_smp_wmb(); > > vq->device_event->flags = flags; > Thanks for spotting this: Reviewed-by: Maxime Coquelin Maxime