From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from NAM01-BN3-obe.outbound.protection.outlook.com (mail-bn3nam01on0045.outbound.protection.outlook.com [104.47.33.45]) by dpdk.org (Postfix) with ESMTP id 03E296CD4 for ; Fri, 14 Oct 2016 07:32:47 +0200 (CEST) Received: from BN6PR03CA0054.namprd03.prod.outlook.com (10.173.137.16) by BLUPR03MB1410.namprd03.prod.outlook.com (10.163.81.144) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.659.11; Fri, 14 Oct 2016 05:32:46 +0000 Received: from BN1AFFO11FD043.protection.gbl (2a01:111:f400:7c10::162) by BN6PR03CA0054.outlook.office365.com (2603:10b6:404:4c::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.669.12 via Frontend Transport; Fri, 14 Oct 2016 05:32:45 +0000 Authentication-Results: spf=fail (sender IP is 192.88.168.50) smtp.mailfrom=nxp.com; caviumnetworks.com; dkim=none (message not signed) header.d=none;caviumnetworks.com; dmarc=fail action=none header.from=nxp.com;caviumnetworks.com; dkim=none (message not signed) header.d=none; Received-SPF: Fail (protection.outlook.com: domain of nxp.com does not designate 192.88.168.50 as permitted sender) receiver=protection.outlook.com; client-ip=192.88.168.50; helo=tx30smr01.am.freescale.net; Received: from tx30smr01.am.freescale.net (192.88.168.50) by BN1AFFO11FD043.mail.protection.outlook.com (10.58.52.190) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_RSA_WITH_AES_256_CBC_SHA) id 15.1.629.5 via Frontend Transport; Fri, 14 Oct 2016 05:32:45 +0000 Received: from [127.0.0.1] ([10.232.133.65]) by tx30smr01.am.freescale.net (8.14.3/8.14.0) with ESMTP id u9E5We61011479; Thu, 13 Oct 2016 22:32:43 -0700 To: Jerin Jacob References: <1471964080-29958-1-git-send-email-hemant.agrawal@nxp.com> <1476384425-11787-1-git-send-email-hemant.agrawal@nxp.com> <20161013133644.GA8096@localhost.localdomain> CC: From: Hemant Agrawal Message-ID: <9d618bd3-f397-7a32-178b-b3c2b241e2fd@nxp.com> Date: Fri, 14 Oct 2016 11:02:40 +0530 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <20161013133644.GA8096@localhost.localdomain> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-Matching-Connectors: 131208967656614134; (91ab9b29-cfa4-454e-5278-08d120cd25b8); () X-Forefront-Antispam-Report: CIP:192.88.168.50; IPV:NLI; CTRY:US; EFV:NLI; SFV:NSPM; SFS:(10009020)(6009001)(7916002)(2980300002)(1109001)(1110001)(339900001)(377454003)(189002)(24454002)(199003)(6916009)(575784001)(31696002)(64126003)(81156014)(31686004)(586003)(81166006)(86362001)(36756003)(11100500001)(105606002)(54356999)(65826007)(230700001)(104016004)(7846002)(50466002)(50986999)(106466001)(76176999)(23746002)(305945005)(2906002)(626004)(97736004)(7246003)(4001350100001)(4326007)(8936002)(65956001)(47776003)(65806001)(356003)(33646002)(110136003)(7126002)(5660300001)(120886001)(68736007)(85426001)(77096005)(19580395003)(87936001)(92566002)(189998001)(2950100002)(8676002)(19580405001)(83506001); DIR:OUT; SFP:1101; SCL:1; SRVR:BLUPR03MB1410; H:tx30smr01.am.freescale.net; FPR:; SPF:Fail; PTR:InfoDomainNonexistent; MX:1; A:1; LANG:en; X-Microsoft-Exchange-Diagnostics: 1; BN1AFFO11FD043; 1:EJjVz1PyVk2E3rWBgpD9RwTH33pcQzvqtB7aAut5XfA5Jh7EYPFXVroUuBg64G+19bwfzNYYH0L20tuto843Lr3osVK0Fwb2iCavn3a67dQACAf075vi6FS43HXfTmXfVj1US90QB9QA+1HkjPA8l2kPYmk/VxIDMxP44aqtw51xhSdnU/Ia5XcB7VHeDPMSfCWt8Xsblv5FA+6RS5vt7+oVpaC2vN9HaxsVrvdhsfAfUGigYEYgBtExvyig30LNafCUIrt749MLdR2LSu2YN8vjaaBNeRD4j3A0W1ZLqmwqEsytHhsO5WBzigFG0pU/wWB4FX8qYez0gQs+P9TxnCV7Iwd/mPb9eMkcnGX5mOb3FPdhRizgIAE734HCd/1yCKdAseSiE4tacG6KjWubP+m1vzsRA058d8U9UxGl+Gjj44Plm9eCt3LsnPWhHL14QtfSn4Ot71PPrHbNJfD5mGdo2nY5lF1vIPi1wOsgsGaSWmJcgZOM2BwjQjrosbmZG0tcQutUbJDP6I6hm69MASNopf9/UngPsDQQHp6lFW9hAHs0lu0dpx3i2oWSFEhkVgW6+GtIs44HZ8gbZr7ezsk0o6SvBqBIqrG/j/czMDU= X-MS-Office365-Filtering-Correlation-Id: ea49e636-cd4c-446c-4794-08d3f3f386f9 X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 2:GmMtTXEPSrB+Q8EwWbcKJ7C3jiaWfJze3CwYrspQoUboeiDe2erqRjVeFpSpMm4vuGb+J9/IEUT7V6C/5igvxfWKNH4B+xPtgJVphzgAjPV9EU1pePIfLRvFFyioL4nEFze1DjwLFp/5u8Pdi5gmMRCDdy5ZbaaWUSo+LzOuAyiamTAj5tr1I+pJybwgbZgpqeNT2yLg9acyuiyG2gu35Q==; 3:k/dM+rGBED1ACcB1eHLeLoEAmHukx2y7B+b85eYG5V70ciRZx9Nfah7rl+HBHWAs7FH2OyLOEcQ0t8zszp8yEQOcAtketMOZgIQ0N1gprZuWSwO/AEu6j1f1c3vINsR5vkzXd9GHkhL7vESM6ryUE6xHPQEXl2yHIC4AowEVIv8fClF1+BmIiFgNgDx04hVs/+MhNZA6s3WW7AJgLAb8fDlu9gstdSl2BJhGPpGRlteAOXVbS88/e0ZxNP48XNtB; 25:d2JfUroFQ4CigC8BvmVAS/6VGPG/75hHHIm1fSjrWWaYbbzBo5PMvuLHsowYlgiLcx2XRSW0P8YVsVctEXzihuobipnXRqzOEPc6nMisQaSfUGsZnBGzMIZPV8YPuEvWzt63AiEivgT2YL4mdjH4lbRijZxesFDR+nRe+r2Lqq2puy7Os5Hhv/ex0UGYuA2+t7oQTcSMFR8ZM+npcGauEOvag/Zwzt7vb+T1w0ck4QT3ni2IbtvNtjJkn5YB90m9w4Svt/v/VNaeB31nahrH56MrZtx3g0bwh0N/ARAvPvHtNEmUepX2kAKIVI3LBOfTH5X0F4UEWABiv3+rwiULn41ZBjsJw/OKEEoCDuMByLf/NCrgcJVsfGg03ODGR28qEZESdzoZvjopHT6oLq+0M//dQ+GAtQhT+jQOvnDoAxI/CKYL8bYmUPzncxd6dd7ClyfvsP0cQy+IgnuQ+d+8sQ== X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:BLUPR03MB1410; X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 31:FDiGeTO0JhDvkGvEgu4Ph53RVgH7+QZDvrQNMZB/qPnhLrFyoV42V47BtTJWrNIHB7VVmRxvHn+sYgNbKmryDj499ib3dcYj5hS1+mQzyw8R1ad5SFH9yjnCaF5rDxMtdQ5EG9PV8JVx5snc+lbhu8sKb3h9q88XP8j3V54Cl8xNkaRVHf2Z6kMZGs/SfhVPTkN4EFq1FHe/niA3R8lhwx6QziMCsK0bm8xpLaZQWkXh2P0Fk1OsmTJsjxwwnNI+/SNuZJckfUmIErOqgEizjg==; 4:ZM0OgyZydvjMy5HC9qqE561yh6nrZhUUhMqAOl0Y0mjdL3j8uLts6oWdMVZqKpV8zB1gxGRomtIDhor4cu/z2XuYfbOuskGAcvsb6KH4zRwnsDXNfjbYeJIlLoi5CciWfZTtdR9KaGHALee8uZhhwdvZOlutLcGcHS8NvIjVXR2PtGFXE4jb8vx5jNKsczkiFoQlJ4HZN9OzkhtwU+j8V62c3Ku2YWvjq2xLjjIOt5aXwyBbpMmP1V+hafNqmVdzeeC7HLCP87uU1+L9i9rNgbNoceyaGPVvRHHC9zOO3ocDeswAgT9HAZyZikKwWvOhDNKhRptfF8Q3rIkiqQ46PCPg9yAhRruhQSPjdvZDjktSBZYyv8OgxEM4CdAfvkcFMdRWCMmvD+YtzExxHkSxb1KCPlB6KAVF6V3KhGJBg+0uu0YorneflaPovM1S/OybgV0aQ4Gbd2HbEdVuEq0a3p4HDVisQls3pXWBjcqiq5/qDN4KkLmnhslpLwj5cHFmyod8Hiy0z4hhgxOeXtxMFm3tNVlNcHWZk6na8HZPS9NbS3BbrPlhTg0VRCuLf5H4 X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(185117386973197); X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(6040176)(601004)(2401047)(8121501046)(13015025)(13024025)(13017025)(13023025)(13018025)(5005006)(3002001)(10201501046)(6055026); SRVR:BLUPR03MB1410; BCL:0; PCL:0; RULEID:(400006); SRVR:BLUPR03MB1410; X-Forefront-PRVS: 0095BCF226 X-Microsoft-Exchange-Diagnostics: =?Windows-1252?Q?1; BLUPR03MB1410; 23:3NvfyxhfNlWlrFs9uw5pIS98PfwA8MHvG+bh9?= =?Windows-1252?Q?zlJYPjale7npLsInAXFMBwHZi76YkokfZG2rwZC1y4+D4/NNtN0/It3d?= =?Windows-1252?Q?c6jKcHMwE509iRQbhD4HXE5ncBmd0UplXYudzcizzTmFnJA9sOEObADJ?= =?Windows-1252?Q?c8zHD5YRW5Q+f3zlqwstHqMip5sRocRgwLP7048VR/eHaTAOpE4z8dq4?= =?Windows-1252?Q?epwdrSimhrs/pRUVh3VSsm9h8kRJNAeMvYC4P5AM7wzOqEvN3M7DXKAw?= =?Windows-1252?Q?5sFdFiLm8QAfn6cb3meXyd+vbb8zy6g6CWF4eMo10PWxwdkYc4J9XjaC?= =?Windows-1252?Q?mzT2Wz/eFnoNYdaLjLJun+AV6cbzcncUGpAvvbsBvqh4LuUBsk/xTdZg?= =?Windows-1252?Q?IzLIPNQMle6Y0dqSl3Bnf5PGC8lPZwI4b0ac4aRnbnm4kkUs/OQiZySU?= =?Windows-1252?Q?OAMp/Hn53wQ21Oc3odxcNjfhOwdIwXV8RaUmRE83fVTDvb8sf5K3NDsM?= =?Windows-1252?Q?BO230/Ri+R7UatkEGfLL7Euszao2/F/oQiit5i38DPUyOnEK34UVjzsJ?= =?Windows-1252?Q?Mamz9fX2S0Ci43E09MxMTjzMRb+SqK36qppUSmsMJxzRtdaeCIyMccsF?= =?Windows-1252?Q?0qBEr9XE5osHM/eUtmoRSSCX6jmlm3mWH6kB1ffNIgMyKSYEAiunbR6+?= =?Windows-1252?Q?iGRc5KdGlQ1HivYh5nvemMQW91UyHDIOFMm+HidQ6vBkDNz/1+LzL0C1?= =?Windows-1252?Q?9onendRDOdy1nkrBfE/6v5bAyDII8kzb8iF6jBO7giXFP7pVjz+xUqeD?= =?Windows-1252?Q?6dewFGINb8Qf/ZbPNeElD9Xi3XiIWJ0/afgy5L5a0fqCBYdFxLysXUxT?= =?Windows-1252?Q?s8qOvP5PQdnX83j+ahYTjYpNftOzWAwB/Iyr5qANE9Makp//Yj6RAiVP?= =?Windows-1252?Q?9viomcHAFziEr4VBLiCOh+bVOF/4I9kp8KWptU5vqetKkLQVlsh+jvrt?= =?Windows-1252?Q?ds50b0N3uka8CmmI8XGteVA4aBwZTkb7YreTJ8pqnjG12USMaU+29T6O?= =?Windows-1252?Q?ae09pFGOeyuiNUrUm/iYIPqGL+/u0wRbtLNOoRh8RkT6VthQJkniEMyO?= =?Windows-1252?Q?3rpPAPLjeaIjqzRCAfvvlhZ0HXeuQ7yEWVC+SmDbkAjkDu7G/dTMx8JN?= =?Windows-1252?Q?GRryLYJedMQzykRo870G/9Qu6sVp8pkjUTNqFwlKF2HPZvO3b5b7B3ZI?= =?Windows-1252?Q?tXKmFP30knqPkuPdLp0Wt0ooa/RuyZW5twp6taCfn4SKZwVFk/qFmr2y?= =?Windows-1252?Q?Sk4T7EqGEE8jG6mc1m7J2bdxyXRU/F8KrvVOujSf3vGyC/tOkm1Zvn+W?= =?Windows-1252?Q?Y7F4Fgi3Za+NQwG2owkHngRpLou8l7Cys1wM/IohHPLCZ8JQtppJC+zr?= =?Windows-1252?Q?Cnh0QfDZo/GWlkDkYoVu+egvpr0SFomd3WtY6xIf+c7+d/mkAxZaSOwR?= =?Windows-1252?Q?siLpUjOzA1Fx3n4COMhz1wsXnFlitjSnM3axvFd5kUZEsITVw=3D=3D?= X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 6:aOxajbzSF1ikRWvR4EdWAun+uOFkhcnpczRk3l6XxunhsAx6W2fdOeXHfMWopLoHG2BR2GoKUnPRp7tF+dw3Dc+UaOUgkaCnQtuQQrih0y3vk8tEif40cD8qIPSXcCM+Zd7xqldGrECzJmTOMNkcxgl+c14tyYE9bsoKgzPXxL3+UoCR0aXbeU2vp5cVW/6JCfHcA+2aQbynYzUyxJ6jF7Ij3cf1e3cgYjW6NLbEZqpei4wnsCy8wm1D1jq8Nt4pUUaMTD6ECl8Wc+DveAzeIKGKcTnXJUjeMr/Ettesxvx1nxhTac0dqBK7VNGnG0a5; 5:5Ujr+0PQABgWdoRvn7Zj76lQICWHHtJHPB181bPw00YLLOke3F/+bHiSWeWywXQjfs4QDQgFRVQ7UwFFKEs2I+/+inmuodSNo8NX6NIGpLYj3zqu+TXzN8y1i1ARL3bsQumH/uILdLmNZXWt5Sqe6b6I3MGguf30rbuFxClZ5DtLtdduupqq7fuq/oq/2NxI; 24:vYnJpcG3yXK8oj2aMYG0Q+cVgvLBAVNlcWdAt2TtBN0RMaDxHQQyhXTDhreQlZn2ihwU9GVwP+JAl3tpudLMKp2KWA+aTDBQnyrSLniphhg= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; BLUPR03MB1410; 7:+FOyHzWUrca40QJibVLZLhHAt/Ksp/wuDN62oQkUAuns9OcgZqu+YP228pb2QhqbKubz+LUsRlivoRjOWc1l4TKd+CLSqFnqAvQx+QOgOHhtwM19GJSXol1h30PDk93BLn2403lIZ9Q+Tlz8tIEkoVIcxuos44VU1rM0OBoTqZc74kIBt5lsPpSuz+veMYqB4wuZeidTYPWa3f/QdRtVgvquJ+Q+kplGgOnPqKHwyAknF+acPqhCOCwT2mYdXVDqIPUpXlM2yABVu/556TQpGZ0b7zNT3xLMUByTixPOHcaozO2P1Qz2JfCNrEV7uxqEv53sPtYTJfJR1Of1/npskpIsxA+K8NCXg0RhHn/DQ4s= X-MS-Exchange-CrossTenant-OriginalArrivalTime: 14 Oct 2016 05:32:45.4430 (UTC) X-MS-Exchange-CrossTenant-Id: 5afe0b00-7697-4969-b663-5eab37d5f47e X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=5afe0b00-7697-4969-b663-5eab37d5f47e; Ip=[192.88.168.50]; Helo=[tx30smr01.am.freescale.net] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLUPR03MB1410 Subject: Re: [dpdk-dev] [PATCH v2] examples/l3fwd: em: use hw accelerated crc hash function for arm64 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 14 Oct 2016 05:32:47 -0000 On 10/13/2016 7:06 PM, Jerin Jacob wrote: > On Fri, Oct 14, 2016 at 12:17:05AM +0530, Hemant Agrawal wrote: >> if machine level CRC extension are available, offload the >> hash to machine provide functions e.g. armv8-a CRC extensions >> support it >> >> Signed-off-by: Hemant Agrawal >> Reviewed-by: Jerin Jacob >> --- >> examples/l3fwd/l3fwd_em.c | 24 ++++++++++++++---------- >> 1 file changed, 14 insertions(+), 10 deletions(-) >> >> diff --git a/examples/l3fwd/l3fwd_em.c b/examples/l3fwd/l3fwd_em.c >> index 89a68e6..d92d0aa 100644 >> --- a/examples/l3fwd/l3fwd_em.c >> +++ b/examples/l3fwd/l3fwd_em.c >> @@ -57,13 +57,17 @@ >> >> #include "l3fwd.h" >> >> -#ifdef RTE_MACHINE_CPUFLAG_SSE4_2 >> +#if defined(RTE_MACHINE_CPUFLAG_SSE4_2) && defined(RTE_MACHINE_CPUFLAG_CRC32) > > The will evaluate as FALSE always. > > Please change to logical OR operation here. ie #if defined(RTE_MACHINE_CPUFLAG_SSE4_2) || > defined(RTE_MACHINE_CPUFLAG_CRC32) > Oops! Will fix it. >> +#define EM_HASH_CRC 1 >> +#endif >