From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 92B1EA0563; Wed, 15 Apr 2020 17:52:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 668561D996; Wed, 15 Apr 2020 17:52:52 +0200 (CEST) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by dpdk.org (Postfix) with ESMTP id 010A71D992; Wed, 15 Apr 2020 17:52:50 +0200 (CEST) Received: by mail-wm1-f68.google.com with SMTP id a201so132293wme.1; Wed, 15 Apr 2020 08:52:50 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=hG17ev2WxmwAN0By7EPePzyxFvFu0w6V55rKI/nw64s=; b=a06KXAVrQowUrHS371nHWGhN97OBxxVL6vSuoM31Lm0Jyi3wtcG4BPTzrDmqQ2LHqL HAkihLaDba6nYKwmxCkLLr8pLRNIf2UZVQgHFHCyzfOzHWW8/8h+Ef9gIyr0mcgtEFIN cbBMjA68PgfPTvoEut/tUu5ToB91nxZOl1F5f58X5HD8u3VgK1J8xd56A5+Uy+o4FNmp wvrVWXkrkntB4NzMHuqJb0yDr50fHI3A7aoqQ9xJs8ddVT2vMFtA9QzvMizRjo0DqRWM rVVOjObzn9Du3xYJpqftZlbk+iu3LGH/MBG74oxRDgH3pihIh6sc4fHKxRK9MEkerYN4 p+wQ== X-Gm-Message-State: AGi0PuYpj6cms63iLJJgxmN+maIZhsCzhdIZXM0cifU7+L5lt9bCCSsd WOJXj9X65hvPsazPaYHWYcM= X-Google-Smtp-Source: APiQypIz23M/NJkk0Gcf6gqlmwMFrFpwD2dYGTQmkJmJY8qDd0xCmzx7bWhvDd8f+JhAa5dFxIORkA== X-Received: by 2002:a05:600c:1008:: with SMTP id c8mr5656488wmc.14.1586965970656; Wed, 15 Apr 2020 08:52:50 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id q8sm22742751wmg.22.2020.04.15.08.52.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 15 Apr 2020 08:52:49 -0700 (PDT) Message-ID: <9d6c2d646675ea293d36ca0df45d61cce6c8cc6b.camel@debian.org> From: Luca Boccassi To: Alexander Kozyrev , Ferruh Yigit , Thomas Monjalon , Kevin Traynor Cc: "dev@dpdk.org" , Raslan Darawsheh , Matan Azrad , Slava Ovsiienko , "stable@dpdk.org" , David Marchand Date: Wed, 15 Apr 2020 16:52:49 +0100 In-Reply-To: References: <1585851108-485-1-git-send-email-akozyrev@mellanox.com> <1586471033-17130-2-git-send-email-akozyrev@mellanox.com> <9093c839-5655-6583-cc10-471a51ecccca@intel.com> <3469922.C4sosBPzcN@thomas> <1c29d98a-68c9-11f6-f4dc-539211ebc185@intel.com> <44ecd81e7176d7f98a2571f7e1c83e793fc15b4c.camel@debian.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v4 1/3] net/mlx5: add a devarg to specify MPRQ stride size X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, 2020-04-15 at 15:34 +0000, Alexander Kozyrev wrote: > On Wed, April 15, 2020 7:26 Luca Boccassi wrote: > > On Wed, 2020-04-15 at 12:01 +0100, Ferruh Yigit wrote: > > > On 4/14/2020 1:52 PM, Thomas Monjalon wrote: > > > > 14/04/2020 13:42, Ferruh Yigit: > > > > > On 4/9/2020 11:23 PM, Alexander Kozyrev wrote: > > > > > > Define a device parameter to configure log 2 of a stride size > > > > > > for MPRQ > > > > > > - mprq_log_stride_size. User is able to specify a stride size i= n > > > > > > a range allowed by an underlying hardware. The default stride > > > > > > size is defined as > > > > > > 2048 bytes to encompass most commonly used packet sizes in the > > > > > > Internet (MTU 1518 and less) and will be used in case a maximum > > > > > > configured packet size cannot fit into the largest possible > > > > > > stride size. Otherwise a stride size is set to a large enough v= alue to > > encompass a whole packet. > > > > > > Cc: stable@dpdk.org > > > > >=20 > > > > > Hi Alexander, > > > > >=20 > > > > > This is a new feature, and you are asking it for to be backported > > > > > to the stable trees. > > > > >=20 > > > > > There is no question on getting the fixes to the stable tree, but > > > > > for backporting features I would like to get the comment of the > > > > > stable tree maintainers first before merging the series. > > > >=20 > > > > As far as I know, there is a fix hidden in this series, for the cas= e > > > > of jumbo frames. > > > > In my understanding, jumbo frames cannot be fixed without a new opt= ion. > > > > I agree it's tricky deciding what is the limit with backports. > > > >=20 > > >=20 > > > I missed the fix bit, so if there is no objection from stable tree > > > maintainers I will continue with the set keeping the stable tag. > >=20 > > Given it's confined to a single PMD it's fine by me, provided that: > >=20 > > 1) Backward compatibility is maintained > > 2) Forward compatibility is maintained (eg: going 19.11.x to 20.02 shou= ld still > > work and not cause any errors) >=20 > The whole point of these patches are to fix the inability to handle 9K ju= mbo frames. > A new devarg is required in order not to break the backward compatibility= . > So I do not expect any issues with backward/forward compatibility with th= ese patches. > One thing I need to mention: backporting requires one small change. > Conversion from MLX5_ASSERT to assert clauses since we reworked them in 2= 0.02. > I can provide a separate list of patches for 19.11 with this change if it= works better for you. > Thank you for you assistance and let me know how we should proceed furthe= r. Ok, thanks. It's not necessary to send a series if the only change is the assert, I can fix it myself when backporting.