From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9566A41C2D; Tue, 7 Feb 2023 11:18:25 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 28CBA410DF; Tue, 7 Feb 2023 11:18:25 +0100 (CET) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mails.dpdk.org (Postfix) with ESMTP id B629840042 for ; Tue, 7 Feb 2023 11:18:23 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1675765103; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=8O/jYspjcryTPEN4smhXrXHfK9XSgOeBwAUG/ygrsbg=; b=ZPCU0ayfxQ+2Nwi5cP6wWSw4KlTssFz5KMpFxh5qRHKZhjaqE5TbeZgRudvcDh/Jx5FnVs eeY6a4JqWrCoyVjKk9xxb4iHvoLvZcaz4d4udbvEAFzO3EiojX5Qm1DeUQMvAyaoxvcuhm VD43TMt7OspFCE/UXgW75iXA0rc7CdU= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-463-3CSUuqCjOqaBqqI9BbvzGw-1; Tue, 07 Feb 2023 05:18:21 -0500 X-MC-Unique: 3CSUuqCjOqaBqqI9BbvzGw-1 Received: by mail-wm1-f72.google.com with SMTP id n7-20020a05600c3b8700b003dc55dcb298so7935789wms.8 for ; Tue, 07 Feb 2023 02:18:21 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8O/jYspjcryTPEN4smhXrXHfK9XSgOeBwAUG/ygrsbg=; b=IcrxWoZGPVNK3NPXCSMNSo5gCdJdl9hCbcWAzKh04F/dvSwLZlGnngZ80mxtSM8gqg ivlkR93uQSbvZkwt1bV3yQ4QhGouuL9pjvxEk9i7oi1jqD5LxI9mBh/Bhb55oSeJaE2B cmNAEmd09cpP6hwg5J9LNhA3J2MFADwxjzKtwsPmifIMHxhxnSv4f4DTY6+L12NKPkcm Hd7G0on5YkOMY5q76yG42XXzLnAwT62jWStmDgaFY6c/AhOiKUuqqWbeBFOngJSyA1Oi q1NHJkny4z6GX8gX+FPtnU7Vai9zh6rItpcs7+2PzfK4+nAGvFRJCE1o8aOd8gJbYgKZ W0og== X-Gm-Message-State: AO0yUKXAShdKgvRQ8cwJBVEFbYN4rsVng7bUiBtyQg5FDYnk3H6xjuEU Th9pZgfkMqPhIQ05XgFcXQcFJbMAttCtzbXv1WvZtrXyGdQ5Wp9LjvXUtwVxmWTevaae8dkDxgN nC08= X-Received: by 2002:adf:d08a:0:b0:236:695b:82d4 with SMTP id y10-20020adfd08a000000b00236695b82d4mr2274881wrh.30.1675765100881; Tue, 07 Feb 2023 02:18:20 -0800 (PST) X-Google-Smtp-Source: AK7set/zv1Y/OKOg8ukuVGR4eq80NYY3L8BIbhlxn9KN92180v5VSn9ewqFcDQW3ksOCvzDooGPneg== X-Received: by 2002:adf:d08a:0:b0:236:695b:82d4 with SMTP id y10-20020adfd08a000000b00236695b82d4mr2274864wrh.30.1675765100623; Tue, 07 Feb 2023 02:18:20 -0800 (PST) Received: from [192.168.0.36] ([78.16.251.63]) by smtp.gmail.com with ESMTPSA id i11-20020a5d630b000000b0029a06f11022sm10765916wru.112.2023.02.07.02.18.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Feb 2023 02:18:20 -0800 (PST) Message-ID: <9d871de0-c9fa-6cb9-1776-c492efcf0126@redhat.com> Date: Tue, 7 Feb 2023 10:18:18 +0000 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v2] vhost: decrease log level for unimplemented requests To: Maxime Coquelin , dev@dpdk.org, chenbo.xia@intel.com, david.marchand@redhat.com Cc: stable@dpdk.org References: <20230206150733.108910-1-maxime.coquelin@redhat.com> From: Kevin Traynor In-Reply-To: <20230206150733.108910-1-maxime.coquelin@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 06/02/2023 15:07, Maxime Coquelin wrote: > This patch changes VHOST_USER_SET_VRING_ERR and > VHOST_USER_SET_LOG_FD "not implemented" log levels from > INFO to DEBUG, as implementing these requests is not > mandatory. Having them being displayed at INFO level > may induce some confusion to the end-user. > > Fixes: fd29c33b651a ("vhost: handle unsupported message types in functions") > Cc: stable@dpdk.org > > Signed-off-by: Maxime Coquelin > --- > lib/vhost/vhost_user.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/lib/vhost/vhost_user.c b/lib/vhost/vhost_user.c > index 8f33d5f4d9..551908df8e 100644 > --- a/lib/vhost/vhost_user.c > +++ b/lib/vhost/vhost_user.c > @@ -1818,7 +1818,7 @@ static int vhost_user_set_vring_err(struct virtio_net **pdev, > > if (!(ctx->msg.payload.u64 & VHOST_USER_VRING_NOFD_MASK)) > close(ctx->fds[0]); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented\n"); > + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented\n"); > > return RTE_VHOST_MSG_RESULT_OK; > } > @@ -2336,7 +2336,7 @@ static int vhost_user_set_log_fd(struct virtio_net **pdev, > return RTE_VHOST_MSG_RESULT_ERR; > > close(ctx->fds[0]); > - VHOST_LOG_CONFIG(dev->ifname, INFO, "not implemented.\n"); > + VHOST_LOG_CONFIG(dev->ifname, DEBUG, "not implemented.\n"); > > return RTE_VHOST_MSG_RESULT_OK; > } Acked-by: Kevin Traynor