From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) by dpdk.org (Postfix) with ESMTP id 6FA0D1B233 for ; Tue, 19 Dec 2017 20:48:54 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga007.jf.intel.com ([10.7.209.58]) by fmsmga102.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 19 Dec 2017 11:48:53 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.45,428,1508828400"; d="scan'208";a="4020733" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.225.69]) ([10.241.225.69]) by orsmga007.jf.intel.com with ESMTP; 19 Dec 2017 11:48:53 -0800 To: Bruce Richardson Cc: Hemant Agrawal , Thomas Monjalon , John McNamara , dev@dpdk.org References: <20171218210616.37502-1-ferruh.yigit@intel.com> <26b4b915-abf5-4eda-7187-827666f30167@intel.com> <20171219101816.GD7384@bricha3-MOBL3.ger.corp.intel.com> <19f21831-355c-345e-669a-9d478facd340@intel.com> <20171219194122.GA12488@bricha3-MOBL3.ger.corp.intel.com> From: Ferruh Yigit Message-ID: <9d8cdb96-4a24-1b91-47bd-87a0107f8871@intel.com> Date: Tue, 19 Dec 2017 11:48:52 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171219194122.GA12488@bricha3-MOBL3.ger.corp.intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/pcap: convert license headers to SPDX tags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 19 Dec 2017 19:48:54 -0000 On 12/19/2017 11:41 AM, Bruce Richardson wrote: > On Tue, Dec 19, 2017 at 11:29:25AM -0800, Ferruh Yigit wrote: >> On 12/19/2017 2:18 AM, Bruce Richardson wrote: >>> On Mon, Dec 18, 2017 at 01:18:33PM -0800, Ferruh Yigit wrote: >>>> On 12/18/2017 1:06 PM, Ferruh Yigit wrote: >>>>> Signed-off-by: Ferruh Yigit >>>> >>>> <...> >>>> >>>>> + * SPDX-License-Identifier: BSD-3-Clause >>>>> + * Copyright(c) 2010-2016 Intel Corporation. All rights reserved. >>>>> + * Copyright(c) 2014 6WIND S.A. >>>>> + * All rights reserved. >>>>> */ >>>> >>>> Hi Hemant, Thomas, >>>> >>>> Can you please suggest about extra "All rights reserved." line. >>>> >>>> It is in the part of the BSD header, and I _assume_ that has been intended to >>>> cover all "Copyright" lines above it. >>>> But since some of the Copyright holders (at least Intel ones) already has that >>>> in same line with copyright and I _assume_ this is intentional because of legal >>>> requirements, can we remove that line. >>>> >>>> I guess we have two options while removing it, applying it to all previous >>>> Copyright lines (B) or just remove it (A): >>>> >>>> (A) >>>> SPDX-License-Identifier: BSD-3-Clause >>>> Copyright(c) 2010-2016 Intel Corporation. All rights reserved. >>>> Copyright(c) 2014 6WIND S.A. >>>> >>>> (B) >>>> SPDX-License-Identifier: BSD-3-Clause >>>> Copyright(c) 2010-2016 Intel Corporation. All rights reserved. >>>> Copyright(c) 2014 6WIND S.A. All rights reserved. >>>> >>>> >>>> Can we go with option (A)? >>> >>> Hi Ferruh, >>> >>> I'm looking to replace a lot of the Intel-copyright license headers - >>> automating it right now. The latest Intel template actually has the >>> "all rights reserved" omitted. [See my patch for meson.build files] >> >> Batch update is good idea, thanks. >> If your patch doesn't cover this I update the patch to omit that part. >> > My patches don't cover files with multiple copyright holders, so > additional patches here will be needed. OK, I will send it, and as I understand from Hemant's comment, we can't omit the standalone "All rights reserved." although I would like to remove it (just for simplicity, not with any legal basis :)), so final header becomes: SPDX-License-Identifier: BSD-3-Clause Copyright(c) 2010-2016 Intel Corporation. Copyright(c) 2014 6WIND S.A. All rights reserved. > > Thanks, > /Bruce >