From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3CCA346CBA; Tue, 5 Aug 2025 09:08:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 01F8240A4B; Tue, 5 Aug 2025 09:08:47 +0200 (CEST) Received: from agw.arknetworks.am (agw.arknetworks.am [79.141.165.80]) by mails.dpdk.org (Postfix) with ESMTP id 94961402E3 for ; Tue, 5 Aug 2025 09:08:45 +0200 (CEST) Received: from debian (unknown [78.109.79.251]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by agw.arknetworks.am (Postfix) with ESMTPSA id C210BE048E; Tue, 5 Aug 2025 11:08:43 +0400 (+04) DKIM-Filter: OpenDKIM Filter v2.11.0 agw.arknetworks.am C210BE048E DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=arknetworks.am; s=default; t=1754377724; bh=XaAiI0Fy+l5ZmZnCykwoYIs1WzRhnuFb9sApwvV00Jo=; h=Date:From:To:cc:Subject:In-Reply-To:References:From; b=4XFG+bYdYC0F/7sdtSaqbrzHWDGiRGJpGeWspKeMUjvXnzfP/7AywCAwj6Oal5PE4 PaAR/4Ww9ePAysqvO9XbCDrYmV9j2ToVZsH8bv0Nv4hNkIduheVutEyDXPZB+wgWK0 ISPcr7yzL6P/l/vrtiUtScko7T2YEcjZL2HSqw5L3IYZ+/2rchfUKidjat/naUa1ot VLtnfXq1zqvclb3m64AjcsPl1XQ9CixbgpeGBPVdy6/koisHJ5ZXP+JhzlmHNfklSH wS/HkalX5QOimlKawv2zhsV/1QfG06O5r1tb0y2pULlqCO5u9BIq0Uh7bzn1plSRVz Tr0TVWTuepuNQ== Date: Tue, 5 Aug 2025 11:08:36 +0400 (+04) From: Ivan Malov To: =?ISO-8859-15?Q?Morten_Br=F8rup?= cc: fengchengwen , dev@dpdk.org, Aman Singh , Thomas Monjalon , Andrew Rybchenko , Stephen Hemminger , Konstantin Ananyev Subject: RE: [PATCH v3 1/3] testpmd: Do not enable mbuf fast release TX offload by default In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35E9FDFF@smartserver.smartshare.dk> Message-ID: <9da405ec-8a1c-4cb3-f44e-1293c85bb49f@arknetworks.am> References: <20250731090731.671589-1-mb@smartsharesystems.com> <20250803194218.683318-1-mb@smartsharesystems.com> <4102ec21-46b6-4512-bc2f-3cd61f63f8c2@huawei.com> <98CBD80474FA8B44BF855DF32C47DC35E9FDFF@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="8323328-1331010236-1754377724=:10250" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org This message is in MIME format. The first part should be readable text, while the remaining parts are likely unreadable without MIME-aware tools. --8323328-1331010236-1754377724=:10250 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8BIT Hi, On Tue, 5 Aug 2025, Morten Brørup wrote: >> From: fengchengwen [mailto:fengchengwen@huawei.com] >> Sent: Tuesday, 5 August 2025 02.59 >> >> On 8/4/2025 3:42 AM, Morten Brørup wrote: >>> Enabling some offload by default may conflict with a manually >> configured >>> offload. >>> Specifically, the mbuf fast release TX offload, which conflicts with >> multi >>> segment packet TX offload, was enabled by default. >>> Therefore, mbuf fast release TX offload (the only TX offload which was >>> enabled by default) is not enabled by default anymore. >> >> This may impact default performance, many vendor performance report has >> testpmd iofwd or macfwd case. > > Yes. > > IMO, any optimizations, mbuf-fast-free or mbuf-recycle, must be explicitly enabled, and documented in the performance reports when used. Good point. Thank you. > Otherwise the performance reports give a false impression of higher performance, which is only available under certain circumstances. > I have complained about this before. > Which is also why mbuf-recycle must be explicitly enabled. > With this patch, the same finally applies to mbuf-fast-free too. > I could add a Fixes tag, but I think it is better to categorize this patch as an improvement rather than a bug fix. > > --8323328-1331010236-1754377724=:10250--